libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-03 17:33:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCI32: Reuse DrawLists when rendering frames

Browse Source 
When converting DrawList to use Common::Array in the previous commit,
I couldn't see a reason to not reuse them in frameOut() and avoid
the extra heap allocations on every frame.
This commit is contained in:
sluicebox 2023-09-25 13:02:41 -07:00 committed by Filippos Karapetis
parent b016bcdf70
commit e8c7f6f7e8
2 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
engines/sci/graphics/frameout.cpp
View File

@ -130,6 +130,7 @@ void GfxFrameout::clear() {
_planes.clear();
_visiblePlanes.clear();
_showList.clear();
_screenItemLists.clear();
}
bool GfxFrameout::detectHiRes() const {
@ -481,23 +482,23 @@ void GfxFrameout::frameOut(const bool shouldShowBits, const Common::Rect &eraseR
// SSCI allocated these as static arrays of 100 pointers to
// ScreenItemList / RectList
ScreenItemListList screenItemLists;
EraseListList eraseLists;
screenItemLists.resize(_planes.size());
eraseLists.resize(_planes.size());
_screenItemLists.resize(_planes.size());
for (DrawList::size_type i = 0; i < _screenItemLists.size(); ++i) {
_screenItemLists[i].clear();
}
EraseListList eraseLists(_planes.size());
if (g_sci->_gfxRemap32->getRemapCount() > 0 && _remapOccurred) {
remapMarkRedraw();
}
calcLists(screenItemLists, eraseLists, eraseRect);
calcLists(_screenItemLists, eraseLists, eraseRect);
for (ScreenItemListList::iterator list = screenItemLists.begin(); list != screenItemLists.end(); ++list) {
for (ScreenItemListList::iterator list = _screenItemLists.begin(); list != _screenItemLists.end(); ++list) {
list->sort();
}
for (ScreenItemListList::iterator list = screenItemLists.begin(); list != screenItemLists.end(); ++list) {
for (ScreenItemListList::iterator list = _screenItemLists.begin(); list != _screenItemLists.end(); ++list) {
for (DrawList::iterator drawItem = list->begin(); drawItem != list->end(); ++drawItem) {
(*drawItem)->screenItem->getCelObj().submitPalette();
}
@ -507,7 +508,7 @@ void GfxFrameout::frameOut(const bool shouldShowBits, const Common::Rect &eraseR
for (PlaneList::size_type i = 0; i < _planes.size(); ++i) {
drawEraseList(eraseLists[i], *_planes[i]);
drawScreenItemList(screenItemLists[i]);
drawScreenItemList(_screenItemLists[i]);
}
if (robotIsActive) {

6
engines/sci/graphics/frameout.h
View File

@ -328,6 +328,12 @@ private:
*/
RectList _showList;
/**
* A list of DrawLists used by frameOut(). This is a field to avoid
* constructing and destroying DrawLists on every frame.
*/
ScreenItemListList _screenItemLists;
/**
* The amount of extra overdraw that is acceptable when merging two show
* list rectangles together into a single larger rectangle.