libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-13 07:14:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

AGS: Safer impl of Set/GetGlobalString

Browse Source 
From upstream dfdba6c4648267ea19136420ae8019de984869a4
This commit is contained in:
Paul Gilbert 2022-03-23 21:43:33 -07:00
parent c6ddeae2df
commit ee119e9611
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engines/ags/engine/ac/global_game.cpp
View File

@ -219,15 +219,13 @@ void SetGlobalString(int index, const char *newval) {
if ((index < 0) | (index >= MAXGLOBALSTRINGS))
quitprintf("!SetGlobalString: invalid index %d, supported range is %d - %d", index, 0, MAXGLOBALSTRINGS - 1);
debug_script_log("GlobalString %d set to '%s'", index, newval);
strncpy(_GP(play).globalstrings[index], newval, MAX_MAXSTRLEN);
// truncate it to 200 chars, to be sure
_GP(play).globalstrings[index][MAX_MAXSTRLEN - 1] = 0;
snprintf(_GP(play).globalstrings[index], MAX_MAXSTRLEN, "%s", newval);
}
void GetGlobalString(int index, char *strval) {
if ((index < 0) | (index >= MAXGLOBALSTRINGS))
quitprintf("!GetGlobalString: invalid index %d, supported range is %d - %d", index, 0, MAXGLOBALSTRINGS - 1);
strcpy(strval, _GP(play).globalstrings[index]);
snprintf(strval, MAX_MAXSTRLEN, "%s", _GP(play).globalstrings[index]);
}
// TODO: refactor this method, and use same shared procedure at both normal stop/startup and in RunAGSGame