libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-21 01:05:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

TINSEL: Resolve FIXMEs

Browse Source 
We already verify the data read for the hopper screen via stream err().
Also, LockMem() has no side-effects when removing unused references.
Thanks to @digitall for spotting the unused variables
This commit is contained in:
Filippos Karapetis 2022-01-10 01:51:02 +02:00
parent e009773aa3
commit effed966dd
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engines/tinsel/dialogs.cpp
View File

@ -900,8 +900,7 @@ void Dialogs::PrimeSceneHopper() {
// allocate a buffer for it all
assert(_pHopper == NULL);
// FIXME: validate vSize against size?
//uint32 size = f.size() - 8;
_numScenes = vSize / sizeof(HOPPER);
_pHopper = new HOPPER[_numScenes];

2
engines/tinsel/movers.cpp
View File

@ -720,8 +720,6 @@ static void InitialPathChecks(PMOVER pMover, int xpos, int ypos) {
static void MoverProcessHelper(int X, int Y, int id, PMOVER pMover) {
const FILM *pfilm = (const FILM *)_vm->_handle->LockMem(pMover->walkReels[0][FORWARD]);
const MULTI_INIT *pmi = (const MULTI_INIT *)_vm->_handle->LockMem(FROM_32(pfilm->reels[0].mobj));
// FIXME: pFrame unused, but LockMem call may have side-effects so unclear if this can be removed
/* const FRAME *pFrame = (const FRAME *) */_vm->_handle->LockMem(FROM_32(pmi->hMulFrame));
assert(_vm->_bg->BgPal()); // Can't start actor without a background palette
assert(pMover->walkReels[0][FORWARD]); // Starting actor process without walk reels