libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-01-20 00:45:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GUI: Enable EGA Undithering in global options dialog

Browse Source 
GUIO_EGAUNDITHER is a positive flag unlike the rest of the GUIO
negative flags like GUIO_NOASPECT and GUIO_NOSPEECH.
This means the gui option is only enabled if the flag exists.

This caused the gui option to be disabled in the global options dialog due
to the flag not existing in the global confman domain.
It is an inconvenience and a regression IMHO to have to set this flag on
a game by game basis with no option to set it globally and have the games
override it.

Thanks Strangerke for making me clarify.

Thanks LordHoto for feedback on code style.
This commit is contained in:
Tarek Soliman 2011-10-25 23:34:15 -05:00
parent 44e4e16819
commit f30df9aa70
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gui/options.cpp
View File

@ -216,7 +216,7 @@ void OptionsDialog::open() {
#endif // SMALL_SCREEN_DEVICE
// EGA undithering setting
if (_guioptions.contains(GUIO_EGAUNDITHER)) {
if (_guioptions.contains(GUIO_EGAUNDITHER) || _domain == Common::ConfigManager::kApplicationDomain) {
_disableDitheringCheckbox->setEnabled(true);
_disableDitheringCheckbox->setState(ConfMan.getBool("disable_dithering", _domain));
} else {
@ -609,7 +609,7 @@ void OptionsDialog::setGraphicSettingsState(bool enabled) {
else
_aspectCheckbox->setEnabled(enabled);
#endif
if (_guioptions.contains(GUIO_EGAUNDITHER))
if (_guioptions.contains(GUIO_EGAUNDITHER) && enabled)
_disableDitheringCheckbox->setEnabled(true);
else
_disableDitheringCheckbox->setEnabled(false);