libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-04-03 23:31:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes possible illegal writes/segfaults in compressToType0 (added a comment about the changes).

Browse Source 
svn-id: r21853
This commit is contained in:
Johannes Schickel 2006-04-13 23:13:56 +00:00
parent 1444a1ab9f
commit fac96dfb34
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sound/midiparser_smf.cpp
View File

@ -238,9 +238,15 @@ bool MidiParser_SMF::loadMusic(byte *data, uint32 size) {
void MidiParser_SMF::compressToType0() { void MidiParser_SMF::compressToType0() {
// We assume that _buffer has been allocated // We assume that _buffer has been allocated
// to sufficient size for this operation. // to sufficient size for this operation.
byte *track_pos[16];
byte running_status[16]; // using 0xFF since it could write track_pos[0 to _num_tracks] here
uint32 track_timer[16]; // this would cause some illegal writes and could lead to segfaults
// (it crashed for some midis for me, they're not used in any game
// scummvm supports though). *Maybe* handle this in another way,
// it's at the moment only to be sure, that nothing goes wrong.
byte *track_pos[0xFF];
byte running_status[0xFF];
uint32 track_timer[0xFF];
uint32 delta; uint32 delta;
int i; int i;