libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-03-06 10:17:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ENGINES: Show pop-up message for save/load in GMM and explain the reason

Browse Source 
This is very confusing to the users, so now instead of hiding or disabling
the buttons, we show message explaining the reason why it is disabled now

  - The engine is not supporting loading from GMM at all
  - The engine does not allow save/load at this time

These messages could be overridden by the engines
This commit is contained in:
Eugene Sandulenko 2023-12-04 21:37:09 +01:00
parent ec2dd2726b
commit fef8f51503
2 changed files with 38 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
engines/dialogs.cpp
View File

@ -66,13 +66,8 @@ MainMenuDialog::MainMenuDialog(Engine *engine)
new GUI::ButtonWidget(this, "GlobalMenu.Resume", _("~R~esume"), Common::U32String(), kPlayCmd, 'P');
_loadButton = new GUI::ButtonWidget(this, "GlobalMenu.Load", _("~L~oad"), Common::U32String(), kLoadCmd);
_loadButton->setVisible(_engine->hasFeature(Engine::kSupportsLoadingDuringRuntime));
_loadButton->setEnabled(_engine->hasFeature(Engine::kSupportsLoadingDuringRuntime));
_saveButton = new GUI::ButtonWidget(this, "GlobalMenu.Save", _("~S~ave"), Common::U32String(), kSaveCmd);
_saveButton->setVisible(_engine->hasFeature(Engine::kSupportsSavingDuringRuntime));
_saveButton->setEnabled(_engine->hasFeature(Engine::kSupportsSavingDuringRuntime));
new GUI::ButtonWidget(this, "GlobalMenu.Load", _("~L~oad"), Common::U32String(), kLoadCmd);
new GUI::ButtonWidget(this, "GlobalMenu.Save", _("~S~ave"), Common::U32String(), kSaveCmd);
new GUI::ButtonWidget(this, "GlobalMenu.Options", _("~O~ptions"), Common::U32String(), kOptionsCmd);
@ -152,11 +147,6 @@ void MainMenuDialog::handleCommand(GUI::CommandSender *sender, uint32 cmd, uint3
}
void MainMenuDialog::reflowLayout() {
if (_engine->hasFeature(Engine::kSupportsLoadingDuringRuntime))
_loadButton->setEnabled(_engine->canLoadGameStateCurrently());
if (_engine->hasFeature(Engine::kSupportsSavingDuringRuntime))
_saveButton->setEnabled(_engine->canSaveGameStateCurrently());
// Overlay size might have changed since the construction of the dialog.
// Update labels when it might be needed
// FIXME: it might be better to declare GUI::StaticTextWidget::setLabel() virtual
@ -198,6 +188,24 @@ void MainMenuDialog::reflowLayout() {
}
void MainMenuDialog::save() {
if (!_engine->hasFeature(Engine::kSupportsSavingDuringRuntime)) {
GUI::MessageDialog dialog(_("This game does not support saving from the menu. Use in-game interface"));
dialog.runModal();
return;
}
Common::U32String msg;
if (!_engine->canSaveGameStateCurrently(&msg)) {
if (msg.empty())
msg = _("This game cannot be saved at this time. Please try again later");
GUI::MessageDialog dialog(msg);
dialog.runModal();
return;
}
int slot = _saveDialog->runModalWithCurrentTarget();
if (slot >= 0) {
@ -221,6 +229,24 @@ void MainMenuDialog::save() {
}
void MainMenuDialog::load() {
if (!_engine->hasFeature(Engine::kSupportsLoadingDuringRuntime)) {
GUI::MessageDialog dialog(_("This game does not support loading from the menu. Use in-game interface"));
dialog.runModal();
return;
}
Common::U32String msg;
if (!_engine->canLoadGameStateCurrently(&msg)) {
if (msg.empty())
msg = _("This game cannot be loaded at this time. Please try again later");
GUI::MessageDialog dialog(msg);
dialog.runModal();
return;
}
int slot = _loadDialog->runModalWithCurrentTarget();
_engine->setGameToLoadSlot(slot);

2
engines/dialogs.h
View File

@ -67,8 +67,6 @@ protected:
GUI::GraphicsWidget *_logo;
GUI::ButtonWidget *_returnToLauncherButton;
GUI::ButtonWidget *_loadButton;
GUI::ButtonWidget *_saveButton;
GUI::ButtonWidget *_helpButton;
GUI::Dialog *_aboutDialog;