Commit Graph

140 Commits

Author SHA1 Message Date
Strangerke
8dbfcc37fb CRUISE: Add a safeguard to avoid a potential null pointer derefenrece 2014-06-15 18:19:11 +02:00
Strangerke
51184eab9d CRUISE: Remove some useless variables, use a boolean for a variable 2014-06-10 07:25:35 +02:00
Strangerke
10f65a3c6f CRUISE: some more renaming, remove another useless variable 2014-06-09 18:01:04 +02:00
Strangerke
58bfb3b435 CRUISE: Remove a couple of useless variables 2014-06-09 17:57:14 +02:00
Strangerke
ff93aef6ec CRUISE: Initialize some variables in the contractor, change some variables to boolean 2014-06-09 17:53:27 +02:00
Johannes Schickel
9e4dfe556e CRUISE: Directly use assert.
This fixes an ASSERT macro redefinition when compiling the Symbian port.
See bug #6622 "SYMBIAN: CRUISE: warning: `ASSERT' redefined".
2014-06-08 17:57:02 +02:00
Strangerke
52bcc9dd25 CRUISE: Fix a null pointer dereference 2014-06-07 12:13:30 +02:00
Strangerke
a6ead6bba8 CRUISE: Comment out some useless code 2014-06-01 11:50:42 +02:00
Strangerke
c15f211486 CRUISE: Reduce the scope of some variables in actor and cruise_main 2014-06-01 11:50:40 +02:00
Strangerke
1dbcd74988 CRUISE: Reduce the scope of variables used in the for loops 2014-06-01 01:21:32 +02:00
Strangerke
659b7bfeed CRUISE: Replace some more strcpy 2014-05-31 17:30:53 +02:00
Johannes Schickel
00b6dfe9cf CRUISE: Make GPL headers consistent in themselves. 2014-02-18 02:39:33 +01:00
D G Turner
a5745434d3 CRUISE: Fix update of background animations while waiting for user.
This is the third and final part of the patch supplied by Ignaz Forster
on bug #3423955 ("CRUISE: Slow / unresponsive game behaviour") for
avoiding blocking graphical updates during user wait loops.

The removal of the continue statement fixes the update of background
animations while waiting for user to respond i.e. try opening a locked
door on the upper deck of the boat and check the sea background
animation, but it also has the side effect of allowing hotspots to
respond during this period if the user clicks fast enough.

However, this bug was also present in the original interpreter, and
a workaround has been added to inhibit this.
2012-04-21 01:55:05 +01:00
D G Turner
f351a1d7ba CRUISE: Modification to main loop to update cursor, even in FastMode.
This is the second part of the patch supplied by Ignaz Forster on
bug #3423955 ("CRUISE: Slow / unresponsive game behaviour") for
avoiding blocking graphical updates during user wait loops.

This removes the check for fastMode from the cursor update code and
other code in this "idle" loop, and moves it down to qualifying
only a few of the function calls.
2012-04-21 01:55:04 +01:00
D G Turner
c4b08c0b98 CRUISE: Move cursor update to upper "idle" loop in main function.
This is the first part of the patch supplied by Ignaz Forster on
bug #3423955 ("CRUISE: Slow / unresponsive game behaviour") for
avoiding blocking graphical updates during user wait loops.

Hotspots passed during the idle loop do _not_ give any user feedback
without this patch.

The original patch has been split to allow for better understanding of
the changes and to allow fine grained bisection if this introduces any
regressions.
2012-04-21 01:55:03 +01:00
Tarek Soliman
a4798602d7 JANITORIAL: Fix missing whitespace in pointer cast
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g'

This seems to have caught some params as well which is not undesirable IMO.
It also caught some strings containing this which is undesirable so I
excluded them manually. (engines/sci/engine/kernel_tables.h)
2012-02-15 10:07:10 -06:00
Tarek Soliman
921f602ab8 JANITORIAL: Fix whitespace in pointer template arg 2012-02-15 10:07:08 -06:00
Eugene Sandulenko
f51116bb46 CRUISE: Remove unused variables 2011-11-14 22:21:56 +02:00
D G Turner
3b71a3a7fb CRUISE: Revert part of mouse movement patch applied from Bug #3423955.
The removal of updateScreen() when DisplayOn is not set may cause a
regression and is not related to fixing of the mouse jerkiness.
2011-10-18 01:59:08 +01:00
D G Turner
fca8ac60de CRUISE: Fix For Unresponsive Mouse Movement noted in Bug #3423955.
This patch was supplied on the bug by Ignaz Forster (ifo).
2011-10-16 21:49:43 +01:00
Christoph Mallon
715c07930d CRUISE: Replace casts and offset calculations for memory debugger by a simple struct. 2011-08-07 15:19:07 +02:00
eriktorbjorn
5dd8f2575b JANITORIAL: Silence a couple of "variable set but not used" warnings. 2011-06-30 23:47:10 +02:00
Max Horn
88913c0139 ALL: Remove trailing whitespaces
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
  git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-20 00:59:48 +02:00
strangerke
69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion
9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
dhewg
d83a83ef50 JANITORIAL: Remove/comment unused vars
Found by GCC 4.6's -Wunused-but-set-variable
2011-03-29 21:57:56 +02:00
Paul Gilbert
0d6069e571 CRUISE: Bugfix for #3188309 - black text at end of introduction 2011-02-23 19:47:07 +11:00
Paul Gilbert
cb2a20cbd0 CRUISE: Bugfix for #3064846 - Raoul appearing in Book screen
svn-id: r54405
2010-11-21 05:31:13 +00:00
Max Horn
a905682cf8 LURE: Convert printf to debug/warning
Exception: The "decompiler" code still uses fopen/fprintf etc.
but it is disabled by default, hence I am ignoring it for now.

svn-id: r54108
2010-11-07 01:03:58 +00:00
Eugene Sandulenko
15b881386a CRUISE: Eliminate global constructors
svn-id: r51936
2010-08-09 10:30:40 +00:00
Max Horn
1d4c82885d DEBUGGER: Simplify how our console debugger works / is used
* Remove _isAttached member var and isAttached method
* Engines now always call the onFrame method; whether it does
  something is decided by the debugger class resp. its subclasses
* Make detach() protected instead of private, so that subclasses
  can invoke it
* Remove _detach_now member var (call detach() instead).
* Rename _frame_countdown to _frameCountdown and properly
  document it.
* Add more doxygen comments
* Cleanup

svn-id: r50963
2010-07-17 18:38:42 +00:00
Yotam Barnoy
ef330ed9b4 Patch for bug 2943361 by littleboy, adding full kb modifier support to all engines + GUI and proper keypad handling
svn-id: r48101
2010-02-21 04:04:13 +00:00
Johannes Schickel
aed02365ec Strip trailing spaces/tabs.
svn-id: r47541
2010-01-25 01:39:44 +00:00
Johannes Schickel
0d995c5920 Rename all "Adlib" uses to "AdLib" to match the real name of the sound card / company.
Check this for reference:
http://en.wikipedia.org/wiki/Ad_Lib,_Inc.
http://www.crossfire-designs.de/images/articles/soundcards/adlib.jpg (note the upper left of the card)

This commit does not touch "adlib" and "ADLIB" uses!

Also it does not update all the SCUMM detection entries, which still use "Adlib".

svn-id: r47279
2010-01-12 21:07:56 +00:00
Max Horn
51933629d1 Changed foo(void) to foo() in almost all non-backend source files
svn-id: r45616
2009-11-02 21:54:57 +00:00
Paul Gilbert
df3fbd432d Further memory leak fixes
svn-id: r44861
2009-10-10 04:15:38 +00:00
Paul Gilbert
857a35f748 Fixed all memory leaks as far as the initial title screen
svn-id: r44814
2009-10-09 10:32:33 +00:00
Paul Gilbert
8694b48ae3 Set up a basic tracing system for all memory allocations to help track down memory leaks
svn-id: r44808
2009-10-09 08:15:30 +00:00
Paul Gilbert
1f39c1b569 Bugfix for freeze when the in-game Pause 'P' key is used
svn-id: r43690
2009-08-24 10:23:22 +00:00
Paul Gilbert
58ec3e67ef Switched event loop while/do to do/while, to ensure event handling occurs even when the game is under heavy load
svn-id: r43471
2009-08-17 11:51:42 +00:00
Paul Gilbert
ef8597d806 Fix bug with the event loop that was discarding pending events rather than leaving them to be processed in the following frame
svn-id: r42965
2009-07-31 23:27:19 +00:00
Max Horn
3f673b899d Patch #2828669: CRUISE: Fix cruise compilation with mingw32ce toolchain
svn-id: r42950
2009-07-30 21:45:09 +00:00
Paul Gilbert
da4367096e Bugfix for mouse button clicks getting counted multiple times
svn-id: r42798
2009-07-26 09:40:35 +00:00
Paul Gilbert
6235f9e176 Minor tweak to prevent mouse clicks that close a user wait message also being further interpreted as a user walk destination
svn-id: r42578
2009-07-18 01:22:43 +00:00
Paul Gilbert
db81b0a185 Added an explicit break out of the event processing loop for mouse buttons and/or key-presses - this should allow stylus-based systems to properly process 'mouse down' events before the 'mouse up' is processed
svn-id: r42558
2009-07-17 05:10:24 +00:00
Paul Gilbert
324ba3703b Bugfix to cursor updates - it previously required that both X and Y positions had changed before a cursor change could occur
svn-id: r42472
2009-07-14 10:55:51 +00:00
Paul Gilbert
f278432144 Added support for sub-relation message types - this fixes trying to attach the chain to the hook on the deck
svn-id: r42405
2009-07-12 07:23:50 +00:00
Paul Gilbert
5270c82523 Bugfix so that user delays work correctly
svn-id: r42197
2009-07-07 02:49:33 +00:00
Paul Gilbert
7f7edabbdd Bugfix so the game speed will correctly change after showing the credits when the game is restarted
svn-id: r42196
2009-07-07 01:14:55 +00:00
Paul Gilbert
3abc1e8375 Removed all the current special cases coding for user (mouse press) waiting, and reimplemented it exactly the way the original did
svn-id: r42173
2009-07-06 12:33:05 +00:00