Commit Graph

406 Commits

Author SHA1 Message Date
D G Turner
b7b66c5049 VIDEO: Fix Missing Default Switch Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-11-30 19:47:06 +00:00
Dmitry Blau
cf179868c8 VIDEO: Fix embedded subtitles in VMD videos
This fixes the subtitles in Woodruff - bug 10960
2019-09-13 11:27:24 +03:00
Bastien Bouclet
0f57aea2df COMMON: Use a prefix table to speed up the Huffman decoder
Symbols for codes shorter than the prefix table index width are stored
in the table. All the entries in the table with an index starting with
the code are set to the symbol value. That way, when decoding it is
possible to get the number of bits corresponding to the table width from
the bitstream and directly find the symbol value. Longer code still need
to be searched for in the codes list.
2019-04-13 16:24:25 +03:00
Bastien Bouclet
43e04d19c4 VIDEO: Fix Bink clearing color comment
YUV 000 is a green, not black. Thanks DrMcCoy for noticing and fixing
the issue.
2019-04-01 20:49:51 +02:00
Bastien Bouclet
195b4cbd20 VIDEO: Fix an integer overflow when dequantizing the DCT coeffs
See 2968bedf12
2019-04-01 20:49:45 +02:00
Torbjörn Andersson
9785d5007a ZVISION: Boost volume for MPEG cutscenes
The high-resolution videos play back at much lower volume than the
original ones. This adds hard-coded values for how much to amplify
each cutscene. It's all done by ear, and it does introduce some
clipping, but I think it should be acceptable.

Of course, it could also be a problem with the audio decoder, so
this may be the wrong approach entirely.
2019-02-10 16:32:02 +02:00
Bastien Bouclet
f72f71a6cc VIDEO: Keep track of the duration of ignored edits
Fixes inconsistent videos playing in Caldoria in the DVD version of JMP
Pegasus Prime.
2019-02-02 13:30:44 +01:00
Torbjörn Andersson
7c58534f4f VIDEO: Add buffering demuxer to MPEG-PS decoder
In all my attempts to get the audio and video to sync up in the
ZGI videos, there have always been 9-10 frames of video before the
audio even starts, even though the audio is timestamped to start
before. This attempts to fix that by prioritizing sending audio
packets to the decoder in a timely fashion.

I do not know if this is the correct way of doing this, and there
are still some things that need to be fixed. But pragmatically, it
does procude significantly better sync, so...
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
a5b5b68a1a VIDEO: Use all video PTS's
Sometimes (only at the very start of a movie?) there will be a
video packet that has a PTS but no frame to display. Save that PTS
and use it for the next frame. This doesn't actually improve
anything, as far as I can tell, but feels right.
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
1255e8de4d VIDEO: Removed _psmESType
We weren't doing anything with it anyway. And I'm not sure it's
even available in the ZGI videos.
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
1d69564876 VIDEO: Moved MPEGStream creation out of readNextPacket()
I think it makes things easier to read, and I have some ideas
that I want to try which should be easier this way...
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
ac40828ed2 VIDEO: Make the video pts sync easier to understand 2018-11-04 22:33:22 +01:00
Torbjörn Andersson
b672a694b9 VIDEO: Synchronize video to pts timestamps
This is another attempts at improving the audio/video sync in the
MPEG-PS decoder. Unfortunately, the audio probably also needs to
be synced to its pts timestamps...
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
43b29a93d7 VIDEO: Use the standalone AC-3 decoder in the MPEG-PS code
This code comes from clone2727's now defunct (?) ac3 branch, with
some minor compile fixes. This represents the latest version of
the stalled AC-3 decoder work for Zork: Grand Inquisitor. Note,
however, that I have not yet asked for clone2727's permission to
use this. I'm just experimenting.
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
ef70af5e99 VIDEO: Some minor cleanups to the AC-3 decoder 2018-11-04 22:33:22 +01:00
Torbjörn Andersson
e6abe39752 VIDEO: Skip DVD code. The sound plays, but audio/video sync is off
Like most things that make this branch actually work, this comes
from clone2727.
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
89ec9766a1 VIDEO: After figuring out sample rate, rewind the AC-3 stream 2018-11-04 22:33:22 +01:00
Torbjörn Andersson
ad41dfb7ff VIDEO: Committed fixes from clone2727
This collects the whole frame before trying to decode it. It's
still now working right, but it's way better than it was before.
2018-11-04 22:33:22 +01:00
Torbjörn Andersson
fc7fa1de3a VIDEO: Use liba52 to decode audio. This is still laughably broken
At the moment, this produces nothing but misery in the form of
Valgrind warnings and horrible noise.
2018-11-04 22:33:22 +01:00
Cameron Cawley
06446d36f5 VIDEO: More fixes when building with Theora and Tremor 2018-08-18 13:33:43 +02:00
Cameron Cawley
5cf3b75deb VIDEO: Fix Theora playback when building with Tremor 2018-08-03 14:52:09 +02:00
Bastien Bouclet
b8abe40085 VIDEO: QT: Make sure all the edits are in the media bounds
In the Spanish version of Riven, the last edit of the video ogk.mov
ends one frame after the end of the media causing the playback to fail
without this check.

Fixes Trac#10633.
2018-07-21 08:02:40 +02:00
Eric Fry
2d836d4ec0 VIDEO: Warn instead of error when unhandled TXTS stream found in AVI 2018-07-20 06:43:33 +00:00
Andrei Prykhodko
7703b3617e VIDEO: fix seeking to first/second frame if it exceeds uint16 2018-06-29 13:41:44 +03:00
Bastien Bouclet
c76c052259 VIDEO: Fix seeking the the last frame of QT videos while playing backwards
Fixes Trac#10590.
2018-06-29 07:20:28 +02:00
whiterandrek
abf17aaa59 VIDEO: fix rewinding of FLIC files 2018-06-15 00:25:57 +02:00
Adrian Frühwirth
fa6a9280b2 VIDEO: Add PRINCE to list of engines using the FLIC decoder 2018-05-17 19:52:15 +02:00
whiterandrek
ff1b7ff89d VIDEO: FLIC: Fix decoding of BYTE_RUN/FLI_BRUN chunks
Our decoder currently only supports the standard FLC format which
does not rely on the stored packet count (which is part of the FLI
format and limited to 255 packets per line).
Instead, the image width should be used as criterion when decoding
a frame which allows for more than 255 packets per line.

See also https://www.compuphase.com/flic.htm
2018-05-17 19:45:16 +02:00
Adrian Frühwirth
9bee9e1ba6 JANITORIAL: Fix whitespace 2018-04-19 12:08:31 +02:00
Bastien Bouclet
9b9600a50f VIDEO: Express VideoDecoder::endOfVideo using easier to understand logic 2017-11-02 19:49:43 +01:00
Bastien Bouclet
6e6fab5b83 VIDEO: BINK: Fix plane data clobbering caused by incorrect pitch value
When decoding blocks, the YUV planes' pitches were computed using the
target video surface size instead of the block based size, resulting in
decoded plane data being overwritten for some video sizes.

Affected videos are LEOS-11102.bik and LEOS-11152.bik from Myst III.
2017-10-08 08:54:40 +02:00
Bastien Bouclet
8547c89b86 VIDEO: Change QT edit list to a Common::Array
And fix an out of bounds acces when seeking to the end of a video.
Skipping samples is needed even when seeking through silent edits
because a silent stream is queued for those.

Fixes #10219.
2017-09-21 13:06:18 +02:00
Torbjörn Andersson
59f8e62adf JANITORIAL: Silence GCC 7 warnings
These fall throughs have to be deliberate, or they wouldn't have to
check if mode equals 2 in the mode == 2 cases.
2017-09-11 06:48:34 +02:00
Paul Gilbert
be208264dd VIDEO: Fix reverse playback right to the very start of the video 2017-09-04 12:03:34 -04:00
Paul Gilbert
e72a1d7c46 VIDEO: Simplify AVIDecoder reverse playback special handling 2017-09-03 19:52:48 -04:00
Paul Gilbert
22e24d7c0b VIDEO: Fix reverse playback in AVIDecoder 2017-09-03 17:29:09 -04:00
Willem Jan Palenstijn
47539e1939 VIDEO: Use new BitStreamMemory class for PSXStreamDecoder 2017-08-24 19:46:59 +02:00
Willem Jan Palenstijn
e72f681ceb VIDEO: Use new BitStreamMemory class for SmackerDecoder 2017-08-24 19:46:59 +02:00
Willem Jan Palenstijn
dde259f068 COMMON: Remove BitStream base class to allow inlining calls
All users of BitStream were in fact using a specific, hardcoded variant,
so we can hardcode that variant, removing the need for virtual calls,
and enabling inlining.
2017-08-24 19:46:59 +02:00
Colin Snover
4ba87013a9 VIDEO: Support old-style stereo in VMDs
This format is used by the stereo audio VMDs in Lighthouse.
2017-08-20 11:36:26 -05:00
Bastien Bouclet
ec49730711 VIDEO: Allow setting the mixer sound type used to play audio tracks 2017-07-27 06:40:07 +02:00
Paul Gilbert
371a594b8d VIDEO: Fix AVIDecoder skipping alternate frames in reverse playback 2017-07-22 21:02:26 -04:00
Paul Gilbert
2838776c4b VIDEO: Refactor AVIDecoder for better handling of transparency track
A lot of the standard VideoDecoder methods were still treating the
transparency track as part of the video, so methods like getFrameCount
would return double the amount it should be. This refactoring properly
separates the transparency track into a separate field entirely.
2017-06-30 21:31:17 -04:00
Paul Gilbert
a897ad9e72 VIDEO: Add method to VideoDecoder to erase a track 2017-06-30 20:34:28 -04:00
Paul Gilbert
680b668614 VIDEO: Fix transparency track seeking in AVIDecoder 2017-06-25 20:48:12 -04:00
Colin Snover
0d63d2a7ad VIDEO: Wrap out-of-range VMD audio samples instead of clipping
The 16-bit DPCM decompressors in SSCI and Urban Runner use a 16-bit
register to store sample data, without any special handling of
overflow. As such, out-of-range samples simply wrap around, rather
than getting clipped.

It is not totally clear if the wrapping behaviour was intentionally
exploited to handle extreme transients, but in any case, videos
like GK2 5280.VMD that generate samples outside the signed 16-bit
range cause a loud pop when using clipping, but play back correctly
when wrapping.
2017-06-17 13:09:27 -05:00
Colin Snover
53fb26550d VIDEO: Unexpose audio sync API in AdvancedVMDDecoder
This change was inadvertently added in commit
44dd029cb1 but is not actually used.
2017-04-29 14:30:09 -05:00
Colin Snover
7b90f0693a IMAGE: Return correct pixel format for Indeo3
This gives Indeo3 the same behavior as other codecs when
encapsulated in a container that provides bit depth information
(e.g. AVI).

Closes #888.
2017-01-11 10:59:55 -06:00
D G Turner
cff454d5e7 VIDEO: Fix Two Further Signed vs. Unsigned Compiler Warnings. 2017-01-10 03:23:31 +00:00
Paul Gilbert
cc4ede6509 VIDEO: Further work on 2-track AVI videos
It turns out that at least one video in Starship Titanic, for the
Lift Indicator, has only a single transparency frame in track 2.
The added code, therefore, when it doesn't find an index entry
for the desired frame number, works backwards until it finds a valid
frame (likely frame 0), and then scans forward. If it hits the end
of the video, then it simply uses whatever last frame it last decoded.
2016-12-29 22:23:16 -05:00