Commit Graph

1637 Commits

Author SHA1 Message Date
Sven Hesse
5bec0cbb9d GOB: Make coordinate parameters in Surface::fillRect() signed
And clip to [0, width), [0, height) before drawing.

This fixes bug #6864, which is a regression I introduced in
51fd528fe5 when I changed all
the drawing code to use the Surface class.

I thought that having unsigned coordinates makes sense, but
for some reason, Fascination sets _destSpriteX (which maps
to left in fillRect()) to -1, expecting the drawing code to
clip.
2015-05-07 00:34:02 +02:00
Sven Hesse
7bdf48170a GOB: Remove useless memcpy()
Happened while removing Draw::_vgaSmallPalette in 0f9b1364c.

Fixes Coverity issue #1230309.
2014-10-19 00:08:32 +02:00
Thierry Crozat
a050d61af8 GOB: Update list of files that contain translatable strings 2014-10-04 01:02:03 +01:00
Sven Hesse
24595ede3b GOB: Remove duplicate entries for Ween DOS
Seems like that happened when I sorted them by platform
after splitting up the big detection table in 07b17f711.

This fixes bug #6676.
2014-07-08 21:03:47 +02:00
Johannes Schickel
ae4ffe01f0 ALL: Rename Debugger::DCmd_Register to Debugger::registerCmd. 2014-05-27 02:04:08 +02:00
Johannes Schickel
daa8d57a86 ALL: Rename Debugger::DebugPrintf to Debugger::debugPrintf. 2014-05-27 02:04:07 +02:00
Sven Hesse
dba4084c8a GOB: Calculate _totResStart even if no resources follow
It's also used as a base offset for TOT strings.
This fixes a crash in the Amiga version of Bargon Attack.
2014-03-16 16:40:08 +01:00
Sven Hesse
0f9b1364cf GOB: Remove the last remnants of Draw::_vgaSmallPalette
Draw::_vgaSmallPalette was supposed to be a 16-color VGA
palette / EGA palette, but we've been using the first 16
entries of Draw::_vgaPalette for that for ages now.

The only parts where we didn't were codepaths never
actually taken in the gob games, so for the sake of
clarity (and fixing Coverity issues), this commit removes
those as well.

Fixes Coverity issues 1192648 and 1192649.
2014-03-16 15:35:35 +01:00
Matthew Hoops
740b6e8fbd IMAGE: Move all ImageDecoders to image/ 2014-02-28 00:27:28 -05:00
Johannes Schickel
ea21bc939a GOB: Make GPL headers consistent in themselves. 2014-02-18 02:39:34 +01:00
Strangerke
78eff8fea9 GOB: Fascination - Reduce the scope of a couple of variables 2014-02-09 20:26:47 +01:00
Sven Hesse
2aadd55ae6 GOB: Correct the language field for Croustibat 2014-01-31 12:16:35 +01:00
Sven Hesse
ca861961a9 GOB: Add a game type and detection table for Croustibat 2014-01-31 12:04:08 +01:00
Sven Hesse
edacb7ada7 GOB: Move getTotTextItemPart() from Inter_v3 to Inter_v2 2014-01-31 11:54:44 +01:00
D G Turner
ef85456859 BUILD: Remove need for engine.mk in each engine directory.
Each engine now only has to provide a single configure.engine file
adding the engine into the configure script, which then produces the
required other files automatically.
2013-11-24 00:48:01 +00:00
D G Turner
1ac01d2333 BUILD: Remove need for engine-plugin.h in engines.
This is now generated automatically by the configure script from the
engine directory names.
2013-11-24 00:48:01 +00:00
D G Turner
00c27a28f9 BUILD: Split engines/plugins_table header down to a file per engine.
This is the third and final commit enabling fully pluggable engines.

Now providing an engine folder contains a configure.engine, engine.mk
and engine-plugin.h file, it will be picked up automatically by the
configure script.
2013-11-24 00:48:01 +00:00
D G Turner
d77cf95a18 BUILD: Split engines.mk down to a single file per engine.
This is the second part of allowing engines to be added dynamically.
Each folder in engines/ which must contain a file named "engine.mk"
containing the make definitions for that engine.
2013-11-24 00:48:01 +00:00
D G Turner
aa947c9474 BUILD: Split configure.engines down to a single file per engine.
This is the first part of allowing engines to be added dynamically.
They are placed into a folder in engines/ which must contain a file
named "configure.engine" to add the engine, which is pulled into the
top level configure script automatically.
2013-11-24 00:45:38 +00:00
Johannes Schickel
378387c903 I18N: Move specification of engine specific files to enginedir/POTFILES.
This allows to keep the engines to specfiy the files for translation close to
the engine sources itself.

Thanks to criezy for his suggestion on this approach.
2013-08-12 17:54:31 +02:00
Johannes Schickel
63750d6780 COMMON: Rename ConfigFile to INIFile.
This clears up that 'ConfigFile' is actually a class handling only INI-files.
2013-08-08 16:28:38 +02:00
Johannes Schickel
63a2e47bfe GOB: Take advantage of Surface::getPixels. 2013-08-03 04:02:50 +02:00
Johannes Schickel
690d55d763 GOB: Prefer getBasePtr over direct Surface::pixels access. 2013-08-03 02:52:32 +02:00
Sven Hesse
9a88fe8485 GOB: Add hypothetical 32bpp support 2013-06-30 19:00:05 +02:00
Matthew Hoops
0031c41db8 COMMON: Change kPlatformPC to kPlatformDOS
"PC" was very ambiguous and now it matches what we show in the GUI.

This also corrects sword2's platform to Windows.
2013-05-02 18:43:10 -04:00
Johannes Schickel
2785c3a528 Merge pull request #322 from fingolfin/fix-clang-warnings
Fix clang warnings
2013-04-19 06:43:47 -07:00
Sven Hesse
4a59c02a8f GOB: Add a call to Inter::animPalette() in the hotspot checker
The original has the call there too, as confirmed using
the disasm of the gob3 binary.

This fixes bug #3611208.
2013-04-19 11:40:18 +02:00
Max Horn
b791edabf7 ENGINES: Remove a bunch of unused private member variables
All instances uncovered by clang warnings.
2013-04-18 23:50:20 +02:00
Sven Hesse
642708de4c GOB: Fix a misplaced continue / fallthrough 2013-04-15 19:07:55 +02:00
Sven Hesse
fc50db1545 GOB: Change strcpy/strcat to strlcpy/strlcat for safety 2013-04-15 19:00:26 +02:00
Sven Hesse
61b1a594b8 GOB: Change strcpy to strlcpy for safety 2013-04-15 18:49:00 +02:00
Sven Hesse
bbe4372f5b GOB: Add another sanity check 2013-04-15 18:42:46 +02:00
Sven Hesse
2a1308b4e1 GOB: Add a sanity check 2013-04-15 18:36:44 +02:00
Sven Hesse
e589bd4525 GOB: Fix another potential array overrun 2013-04-15 18:35:33 +02:00
Sven Hesse
3540b943cf GOB: Fix a potential array overrun 2013-04-15 18:30:12 +02:00
Sven Hesse
eb55db436d GOB: Fix a leak 2013-04-15 18:25:01 +02:00
Sven Hesse
658608d0dd GOB: Correct a delete/delete[]-mismatch 2013-04-15 18:24:09 +02:00
Sven Hesse
c053f715d6 GOB: Remove unused member variable in SaveLoad_v6 2013-04-15 18:22:49 +02:00
Sven Hesse
172aed0441 GOB: Remove unused member variables in SaveLoad_Fascination 2013-04-15 18:22:18 +02:00
Sven Hesse
3e1622d68a GOB: Add another Spanish DOS version of Geisha
As supplied by alestedx in bug report #3610207
2013-04-08 11:05:50 +02:00
Sven Hesse
0de198c997 GOB: Plug a leak 2013-03-20 08:28:45 +01:00
Sven Hesse
19d9071841 GOB: iterator++ -> ++iterator 2013-03-20 08:27:51 +01:00
Johannes Schickel
71304b6e77 GOB: Fix const away cast warning.
Thanks to DrMcCoy for looking over this.
2013-01-06 20:53:08 +01:00
Tomas Jakobsson
b85d51c4a3 GOB: Update to new IFFDecoder for ILBM images 2013-01-06 20:04:42 +01:00
Sven Hesse
ef8e15255d GOB: Add a Spanish/Italian DOS version of Geisha
As supplied by einstein95 in bug report #3544449.
2012-08-05 10:43:41 +02:00
Sven Hesse
b001168658 GOB: Implement the parents section in Once Upon A Time
The text lines are not drawn completely correct yet, because
apparently, GCTFile needs to wrap long lines.
2012-07-30 01:48:40 +02:00
Sven Hesse
dd2768a2e4 GOB: Reorder a few things 2012-07-30 01:44:46 +02:00
Sven Hesse
25bc7467b4 GOB: Use Sound::sampleLoad in PreGob 2012-07-30 01:44:46 +02:00
Sven Hesse
3189729c97 GOB: Don't leak in sampleLoad() when loading fails 2012-07-30 01:44:46 +02:00
Sven Hesse
850472f21e GOB: Implement the proper Once Upon A Time title sequence 2012-07-30 01:44:46 +02:00