Commit Graph

58113 Commits

Author SHA1 Message Date
Johannes Schickel
11eb168582 GUI: Use Domain::const_iterator in EventRecorder code when possible. 2013-08-08 03:12:02 +02:00
Johannes Schickel
fffb2ee3ff HOPKINS: Respect pitch when drawing on OSystem's screen surface. 2013-08-07 22:01:19 +02:00
Johannes Schickel
952a119ae1 IPHONE: Fix accidental double free.
This was a copy&paste error. I also adapted the comment to be more clear.
2013-08-07 21:41:24 +02:00
Johannes Schickel
7f8308e0eb Merge pull request #365 from lordhoto/protected-pixels
Make Graphics::Surface::pixels protected.
2013-08-07 12:24:59 -07:00
Matthew Hoops
6e9390feb8 VIDEO: Don't allow VideoDecoder::seek() to be overridden
A new seekIntern() that performs the actual seeking is to be overriden instead. Having the caller override seek() and then call VideoDecoder::seek() kind of defeated the purpose of stopping/starting the audio.
2013-08-06 22:26:15 -04:00
Johannes Schickel
e5f0c42a65 WINTERMUTE: Fix incorrect parameter order for getBasePtr.
This is a regression from 19fa89b8f5. Thanks to
fuzzie for noticing.
2013-08-06 20:11:27 +02:00
Filippos Karapetis
d041177e2f SCI: Add another version of Jones CD (bug #3614668) 2013-08-06 12:46:44 +03:00
Matthew Hoops
043bd1b9f9 VIDEO: Clean up the AVI decoder 2013-08-05 23:29:22 -04:00
Johannes Schickel
363a5a95cf GRAPHICS: Make Surface::pixels protected. 2013-08-06 03:51:49 +02:00
Johannes Schickel
911c74e82c VKEYBD: Do not access Surface::pixels anymore. 2013-08-06 03:51:12 +02:00
Johannes Schickel
c28f3baa77 N64: Do not access Surface::pixels anymore. 2013-08-06 03:51:12 +02:00
Johannes Schickel
30d2eb7a97 DC: Do not access Surface::pixels directly. 2013-08-06 03:51:12 +02:00
Johannes Schickel
d9b90d67d3 ANDROID: Do not access Surface::pixels directly. 2013-08-06 03:51:12 +02:00
Johannes Schickel
9179f0b78f PSP: Do not access Surface::pixels directly. 2013-08-06 03:51:11 +02:00
Johannes Schickel
09f7e4d5d4 IPHONE: Do not access Surface::pixels directly. 2013-08-06 03:51:11 +02:00
Johannes Schickel
6d86a66493 NDS: Do not access Surface::pixels directly. 2013-08-06 03:51:11 +02:00
Johannes Schickel
6639958d7a PS2: Do not access Surface::pixels directly. 2013-08-06 03:30:38 +02:00
Johannes Schickel
0f050fe797 WII: Do not access Surface::pixels directly. 2013-08-06 03:29:16 +02:00
Alyssa Milburn
c5c2fde52e Merge pull request #368 from fingolfin/fix-test
BUILD: fix 'make test' compile error
2013-08-05 03:19:58 -07:00
Max Horn
a993b8dc30 NEVERHOOD: Remove NRect constructor
Otherwise, every global variable of type NRect requires a constructor to be
run, which can cause portability issue.
2013-08-05 11:49:03 +02:00
Max Horn
bd0db73a64 BUILD: fix 'make test' compile error 2013-08-05 11:44:27 +02:00
Einar Johan Trøan Sømåen
a932e51b14 WINTERMUTE: Fix formatting. 2013-08-05 03:25:22 +02:00
Strangerke
71a1d18b0c MORTEVIELLE: Fix flags in playSong(). Thanks clone2727 for telling about it 2013-08-05 00:40:47 +02:00
Strangerke
80cc1700a7 MORTEVIELLE: Fix leak in playSong, refactor it a bit 2013-08-05 00:13:57 +02:00
Paul Gilbert
0d2f812387 TSAGE: Bugfixes for further R2R scene 1000 cutscenes 2013-08-04 10:16:26 -04:00
Paul Gilbert
c92ffa95df TSAGE: Completed R2R starship cutscene 2013-08-04 10:00:10 -04:00
Alyssa Milburn
89e14f6862 SCUMM: Fix backwards-in-same-array case of v72he::copyArray. 2013-08-04 15:54:37 +02:00
Thierry Crozat
7b517f7fd1 MORTEVIELLE: Improve looping of the intro song
Using a LoopingAudioStream gets rid of the pause between each loop
(and simplifies the code).
2013-08-04 12:59:34 +01:00
Thierry Crozat
deef0b955c MORTEVIELLE: Fix crash in sound mixer when closing the engine
This was due to the _speakerHandle being reused between its
initialisation in the SoundManager constructor and the destructor
causing it to have a wrong value when trying (and failing) to stop
the PCSpeaker channel in the mixer before deleting the stream.
2013-08-04 12:56:15 +01:00
Strangerke
fbb1137f94 MORTEVIELLE: Take shouldQuit() into account while a song is played 2013-08-04 10:49:06 +02:00
Strangerke
c1f93815ee MORTEVIELLE: Compute real buffer size in order to avoid ticks at the end of the song 2013-08-04 10:46:10 +02:00
Alyssa Milburn
2af07d5d8e SCUMM: Add detection/version for Moonbase Commander v1.1. 2013-08-04 10:42:44 +02:00
Strangerke
134532090b MORTEVIELLE: Implement music in intro screen 2013-08-04 10:39:34 +02:00
Torbjörn Andersson
870a583c8b MORTEVIELLE: Pass Pattern struct by reference
This should avoid unnecessary copying of a 400+ byte struct. This
was a low-priority Coverity issue, for some reason without a CID.
2013-08-04 09:24:33 +02:00
Torbjörn Andersson
38071bc5c5 MORTEVIELLE: Fix out-of-bounds read
This should be sufficient. At this point, cy is at most 23, and if
cx is 41 it's either 23 or less than 20. That means ix is either
46 or less than 43. If it's less than 43, there is no out of bounds
access, and now we look at the special case first.

This was a Coverity issue, but for some reason I don't see any CID
for it.
2013-08-04 09:14:11 +02:00
Johannes Schickel
a96a427fc8 SCUMM: Add comment about getPixels uses in BaseCostumeRenderer. 2013-08-04 02:41:40 +02:00
Johannes Schickel
6485b291e9 SCUMM: Fix Loom (and some other graphics regressions).
These are regressions from c05cb7f3bb. They were
caused by VirtualScreen::getPixels differing from Surface::getBasePtr and I
accidently used the former in some cases in the conversion.

I also fixed a bug in debugger.cpp which exchanged x and y.
2013-08-04 02:29:13 +02:00
Johannes Schickel
68b5de7cd4 Merge pull request #364 from lordhoto/sub-surface
GRAPHICS: Allow to query a Surface describing a subarea in Surface.
2013-08-03 16:18:35 -07:00
Johannes Schickel
8fc54d6d77 VIDEO: Fix regression in Urban Runner videos.
This is a regression from 6fce92b0ea. Thanks to
DrMcCoy for tracking this down.
2013-08-04 01:07:34 +02:00
Johannes Schickel
604e1b0070 GRAPHICS: Fix typo. 2013-08-04 01:01:15 +02:00
Johannes Schickel
b95858bb91 WINTERMUTE: Small formatting fixes. 2013-08-04 00:53:25 +02:00
Johannes Schickel
1ce54c217a WINTERMUTE: Fix end of namespace comments. 2013-08-04 00:51:09 +02:00
Paul Gilbert
c02934df37 TSAGE: Cleanup of code in R2R scene 1000 to use AnimationPlayer 2013-08-03 16:57:17 -04:00
Thierry Crozat
0a2e64b903 DEVTOOLS: Include English menu in mortevielle dat file 2013-08-03 16:50:14 +01:00
Strangerke
178feb8e8b MORTEVIELLE: Rename ROOM9 into JULIA_ROOM 2013-08-03 14:55:19 +02:00
Strangerke
6d2f53a63c MORTEVIELLE: Fix error in c79ce89680 2013-08-03 13:18:34 +02:00
Strangerke
65b0b59bd5 MORTEVIELLE: Some more renaming 2013-08-03 12:56:21 +02:00
Strangerke
c79ce89680 MORTEVIELLE: Rework code using _openObjects 2013-08-03 12:09:13 +02:00
Johannes Schickel
0cb1504a5b VIDEO: Do not set Surface::pixels directly anymore. 2013-08-03 04:14:08 +02:00
Johannes Schickel
9a80fa88e0 SDL: Do not set Surface::pixels directly anymore. 2013-08-03 04:14:08 +02:00