In DW2, some large TINSEL_EVENT values are read, and they're bigger than
the last TINSEL_EVENT value, but we cast them to `enum TINSEL_EVENT`
values in tinlib.cpp, which is apparently "unspecified behavior up to
C++17 and undefined behavior starting from C++17".
tinlib.cpp:1925:39: runtime error: load of value 9041, which is not
a valid value for type 'Tinsel::TINSEL_EVENT'
tinlib.cpp:1935:31: runtime error: load of value 77, which is not
a valid value for type 'Tinsel::TINSEL_EVENT'
Found with UBSan but the really clear help comes from PVS-Studio
documentation.
The red text for the Suffrajester in the cemetery was printed in black
on big-endian PowerPC.
It appears that the color given to SetActorRGB() is already in native
endianness, so there's no need to call TO_32() which would do a double
conversion on big-endian hosts.
1839780513 made a mistake by
confusing the IO-attributes with the non-IO_-attributes,
as there is a difference in the order of the flags between
these two sets.
Fixes bug: https://bugs.scummvm.org/ticket/13810
../scummvm/engines/tinsel/handle.cpp: In member function 'void Tinsel::Handle::LoadFile(Tinsel::MEMHANDLE*)':
../scummvm/engines/tinsel/handle.cpp:293:27: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
293 | if (bytes == (pH->filesize & FSIZE_MASK)) {
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Revert "TINSEL: Fix int32 discrepancy"
- This reverts commit a640e6b489.
Revert "TINSEL: Refactor Notebook and System reels to follow naming conventions"
- This reverts commit 2cfc3b4ed2.
Revert "TINSEL: Rename IsConvAndNotMove -> isConvAndNotMove"
- This reverts commit 5ba099f408.
Revert "TINSEL: Rename the public methods in Dialogs to follow convention"
- This reverts commit 8ef52754a1.
Revert "TINSEL: Rename the private methods in Dialogs to follow convention"
- This reverts commit a3d0b5206b.
Revert "TINSEL: Add debug commands to add all clues, as well as listing them."
- This reverts commit fdfede64ca.
Revert "TINSEL: Implement pointer handling for Notebook"
- This reverts commit 195b04c9cf.
Revert "TINSEL: Implement polygon-handling for Notebook"
- This reverts commit 10cce703dc.
Revert "TINSEL: Add initial event support to Notebook."
- This reverts commit 61c94379cd.
Revert "TINSEL: Close Inventories when switching between them."
- This reverts commit 337aed1915.
Revert "TINSEL: Implement library function CROSSCLUE"
- This reverts commit 9519288acd.
Revert "TINSEL: Implement Notebook logic for adding clues and showing pages."
- This reverts commit 3580c17cc5.
Revert "TINSEL: Implement InventoryOrNotebookActive"
- This reverts commit 89aefb7794.
Revert "TINSEL: Minor style-fixes"
- This reverts commit e92fafb955.
Revert "TINSEL: Refactor IsInPolygon to be partially a member-function"
- This reverts commit fa7d448051.
Revert "TINSEL: Replace LockMem with GetFrame for FRAME"
- This reverts commit ec9c630fc5.
Revert "TINSEL: Replace LockMem with GetMultiInit for MULTI_INIT"
- This reverts commit fa8e3c506b.
Revert "TINSEL: Further refactor InventoryObjects"
- This reverts commit 1a2f18e421.
