Martin Kiewitz
f1b0a77408
SCI: fix music start code fixes eq2 bug #3037267
...
we start at offset 10 for sound SCI1 games. This is hardcoded in the interpreter. Also removing not handling signals on tick 0. This fixes Eco Quest 2 / Gonzales dancing in room 530. Thanks to wjp for the help.
2013-09-22 15:40:51 +02:00
m-kiewitz
bac818ccb7
SCI: patch for camelot sierra bug fixes #3614969
...
fixes sierra script bug for Conquests of Camelot (peeking through window)
2013-09-22 02:26:19 +02:00
m-kiewitz
fa41ee132b
SCI: fix for heap corruption during lsl3 ending
2013-09-21 22:35:53 +02:00
Willem Jan Palenstijn
4b5ca10f68
Merge branch 'master' into sci_midiparser
...
Conflicts:
engines/sci/sound/midiparser_sci.cpp
2013-09-21 20:05:47 +02:00
m-kiewitz
97b255ab33
SCI: fix dataInc signalling fixes bug #3035159
...
we set signal in parseNextEvent on dataInc events, which then effectively triggered 2 cues through kDoSoundUpdateCues instead of one. Fixes Freddy Pharkas Ballad intro on floppy + demos
2013-09-21 19:41:45 +02:00
Willem Jan Palenstijn
a6d902df28
SCI: Handle !fireEvents in processEvent
2013-09-21 14:42:59 +02:00
m-kiewitz
158d12e555
SCI: abbrev. ffs to FE and priority check fix
2013-09-21 14:34:42 +02:00
m-kiewitz
4443793b97
SCI: sfx/music priority int16 fixes bug #3615038
...
it seems that sound system up till SCI0_LATE uses int16, afterwards it seems they changed to byte
main music object (conMusic) in Laura Bow 1 uses -1 as priority. This was truncated to 255 till now, which resulted in many sound effects not getting played, because those used priority 0
2013-09-21 14:27:16 +02:00
Filippos Karapetis
ac0c890bcc
SCI: Add source of the checksums for RAMA German
2013-09-21 14:59:26 +03:00
Enrico Horn
c85698e87f
SCI: Add detection entry for the German version of RAMA
2013-09-21 14:54:09 +03:00
Willem Jan Palenstijn
3792af8e95
AUDIO: Simplify SCI inFastForward flag by moving it to MidiParser
2013-09-21 09:31:08 +02:00
Willem Jan Palenstijn
11d425b76c
SCI: Move MIDI event processing out of parseNextEvent
2013-09-21 01:43:04 +02:00
Willem Jan Palenstijn
5b23a251ce
SCI: Fix too strict assert triggering in LSL5
2013-09-19 23:54:27 +02:00
m-kiewitz
448063a8df
SCI: Fully explain qfg1vga script patch
2013-09-18 23:11:07 +02:00
Willem Jan Palenstijn
6c85ad12aa
SCI: Explain qfg1vga script patch slightly
2013-09-18 23:00:38 +02:00
m-kiewitz
e4568817bb
SCI: QfG1VGA script patch fixes bug #3585793
2013-09-18 22:52:32 +02:00
m-kiewitz
ed865856dc
SCI: PQ1 script patch, fixes gun locker crash
...
fixes bug #3303802 / bug #3036933
2013-09-17 23:27:02 +02:00
m-kiewitz
32d28c9f7a
SCI: script patch for larry 2 - fixes no points granted when wearing parachute - was a sierra script bug - fixes bug #3614419
2013-09-17 21:58:05 +02:00
m-kiewitz
ce63a32510
SCI: QfG1VGA: script patch to fix a typo in a Sierra script -> looking at a cheetaur returned the text for saurus rex, fixes bug #3604943
2013-09-16 21:07:49 +02:00
m-kiewitz
1c9316cee0
SCI: longbow intro night rider fix (with help of wjp) - seems to fix bug 3489094
2013-09-16 00:34:49 +02:00
m-kiewitz
0fd15e6db3
SCI: fix tabs in last commit
2013-09-15 23:21:23 +02:00
m-kiewitz
0367d40647
SCI: disable signals when resuming music, so that debugger will work properly for longbow intro
2013-09-15 22:14:35 +02:00
Johannes Schickel
01dea8bd67
Merge pull request #378 from lordhoto/pluggable-engines-translations
...
RFC: Pluggable Engines: I18N: Move specification of engine specific files to enginedir/POTFILES
2013-09-12 15:38:13 -07:00
Filippos Karapetis
f6b61291a7
SCI: Fix script bug #3614968 - "SCI: Camelot - crash at the pool of Siloam"
2013-09-03 10:55:48 +03:00
Filippos Karapetis
7520aea2ec
SCI: Fix several script bugs in Hoyle 4 (Bridge)
...
This also fixes bug #3361925 - "SCI: HOYLE4: Crash in bridge"
2013-08-23 13:45:19 +03:00
Filippos Karapetis
9095c4124d
SCI: Give more verbose error messages on arithmetic errors
2013-08-23 13:45:19 +03:00
Filippos Karapetis
bd945bc756
SCI: Add support for the King's Questions mini-game
...
This can be found in the KQ collection
2013-08-20 19:48:33 +03:00
Filippos Karapetis
3a2b629a17
SCI: Fix script bug #3604939 - "SCI: QFG1VGA: Game hangs when meeting Baron while sneaking"
2013-08-19 12:31:37 +03:00
Filippos Karapetis
0885a003c5
SCI: Fix bug #3614914 - "SCI: Castle of Dr Brain Spanish crashes after Computer Room"
...
Ignore the unused x/y displacement fields of cels embedded in pics.
Dr. Brain Spanish, pic 261 contains garbage in these fields (probably
left overs)
2013-08-19 06:30:50 +03:00
Johannes Schickel
378387c903
I18N: Move specification of engine specific files to enginedir/POTFILES.
...
This allows to keep the engines to specfiy the files for translation close to
the engine sources itself.
Thanks to criezy for his suggestion on this approach.
2013-08-12 17:54:31 +02:00
Johannes Schickel
7f8308e0eb
Merge pull request #365 from lordhoto/protected-pixels
...
Make Graphics::Surface::pixels protected.
2013-08-07 12:24:59 -07:00
Filippos Karapetis
d041177e2f
SCI: Add another version of Jones CD (bug #3614668 )
2013-08-06 12:46:44 +03:00
Johannes Schickel
dbda889e63
SCI: Take advantage of Surface::getPixels.
2013-08-03 04:02:52 +02:00
Johannes Schickel
dd67e9f099
SCI: Prefer getBasePtr over direct Surface::pixels access.
2013-08-03 02:52:33 +02:00
Filippos Karapetis
2088a77388
SCI: Add a hack to fix the inventory in GK1
...
For some reason, the top left nsRect coordinates get swapped in the GK1
inventory screen, investigate why
2013-07-30 04:21:51 +03:00
Willem Jan Palenstijn
06cc30cf6c
SCI: Add FIXME
2013-07-19 21:22:36 +02:00
Sven Hesse
989ea7cb56
JANITORIAL: Remove trailing whitespace
2013-07-14 19:01:47 +02:00
Filippos Karapetis
fef7d59c54
SCI: Rewrite the song loop comments in commit 6fa668e
to make more sense
2013-07-08 12:32:12 +03:00
Filippos Karapetis
6fa668e32a
SCI: Add some comments a possible TODO regarding song looping
2013-07-08 12:19:15 +03:00
Filippos Karapetis
0f30ba2f10
SCI: Fix bug #3614566 - "LSL6: ScummVM locks up at Electro-Shock room"
...
We now do the jumpToTick() for hold events after waiting for the delta
of the current event, like we do for the signal set events. This keeps
the fixes for the hold timings in QFG3, while not breaking LSL6.
Many thanks to wjp for pinpointing the actual cause of the issue.
2013-07-07 19:41:42 +03:00
Filippos Karapetis
d530985a6b
SCI: Avoid using g_sci for usesOldGfxFunctions() in the GfxPorts class
2013-06-21 13:19:37 +03:00
Filippos Karapetis
125b146b06
SCI: Implement the 4-param version of kDoSoundSendMidi - bug #3614447
...
Many thanks to wjp for his help with disassembly
2013-06-19 02:08:06 +03:00
Willem Jan Palenstijn
6e3510ac61
SCI: Add note about LSL1vga DoSoundSendMidi
2013-06-18 18:46:54 +02:00
Filippos Karapetis
f38c7d76ef
SCI: Add a workaround for a script bug in SQ5, room 800 - bug #3614145
2013-05-31 05:59:25 +03:00
Matthew Hoops
80e3002105
SCI: Add an alternate version of the GK1 demo
2013-05-17 23:13:07 -04:00
Matthew Hoops
ddf3472895
SCI: Add detection for an interactive KQ7 demo
...
Thanks to DrMcCoy
2013-05-17 23:04:10 -04:00
Matthew Hoops
0031c41db8
COMMON: Change kPlatformPC to kPlatformDOS
...
"PC" was very ambiguous and now it matches what we show in the GUI.
This also corrects sword2's platform to Windows.
2013-05-02 18:43:10 -04:00
Filippos Karapetis
b8eaefbf8a
SCI: Silence some false positive warnings - CID 1003539, 1003540, 1003541, 1003542
2013-05-01 01:51:12 +03:00
Filippos Karapetis
5b25c40c40
SCI: Fix a non-initialized variable in GfxScreen - CID 1003105
2013-05-01 01:51:12 +03:00
Filippos Karapetis
012a5ef040
SCI: Fix a non-initialized variable in GfxCursor - CID 1003112
2013-05-01 01:51:12 +03:00
Filippos Karapetis
3012aaa14f
SCI: Fix a non-initialized variable in GfxControls16 - CID 1003114
2013-05-01 01:51:11 +03:00
Filippos Karapetis
66fce6d156
SCI: Fix some non-initialized variables in SegManager - CID 1003116
2013-05-01 01:51:11 +03:00
Filippos Karapetis
70f1c4d315
SCI: Fix a non-initialized variable in MessageState - CID 1003119
2013-05-01 01:51:11 +03:00
Filippos Karapetis
abef7f64bd
SCI: Fix a non-initialized variable in MessageReader - CID 1003120
2013-05-01 01:51:11 +03:00
Filippos Karapetis
2d90cc4ac3
SCI: Fix a non-initialized variable in GfxMenu - CID 1003110
2013-05-01 01:51:11 +03:00
Filippos Karapetis
619baf67ae
SCI: Initialize some members of GfxPaint16 - CID 1010057
2013-05-01 01:51:10 +03:00
Filippos Karapetis
d0697addab
SCI: Change wording for a function reference
2013-04-28 23:31:11 +03:00
Filippos Karapetis
d840aa4dec
SCI: Change wording for the cursor position workarounds
2013-04-28 23:31:10 +03:00
Matthew Hoops
9eb5d23a5e
SCI: Fix patched save/load dialogs in SCI32 Mac games
2013-04-28 14:56:06 -04:00
Matthew Hoops
ee86e671f1
SCI: Fix Phantasmagoria Mac's kDoSound
2013-04-28 13:43:17 -04:00
Filippos Karapetis
99e90b98f0
SCI: Fix incorrect detection of NRS patches in QFG3 (bug #3574541 )
2013-04-27 14:40:08 +03:00
Filippos Karapetis
46ebf37ec9
SCI: Change wording for bug/further info references
2013-04-27 14:04:27 +03:00
Matthew Hoops
81f5a89093
SCI: Fix SCI32 BE selector name count
2013-04-26 21:31:32 -04:00
Matthew Hoops
f2ae99791f
SCI: Add script patch for Freddy Pharkas Mac inventory
...
Thanks to waltervn for figuring this mess out!
2013-04-26 20:38:43 -04:00
Willem Jan Palenstijn
38fa74d24a
SCI: Fix (unlikely) memory leak
2013-04-25 20:48:32 +02:00
Filippos Karapetis
d8eb01a729
SCI: Add the French floppy version of GK1 (bug #3611487 )
2013-04-25 11:10:36 +03:00
Filippos Karapetis
c47a516430
SCI: Reorder the LSL3 detection entries a bit
2013-04-25 11:08:11 +03:00
Filippos Karapetis
40865bc79e
SCI: Add another version of LSL3 (bug #3611488 )
2013-04-25 11:07:01 +03:00
Filippos Karapetis
41e02baff1
SCI: Fix scaling in the back room of the bookstore in GK1
2013-04-25 02:36:03 +03:00
Matthew Hoops
829847cb88
SCI: Fix kMessage REF subop ordering
...
Thanks to waltervn for testing values from running in DOSBox.
Fixes bug #3034704
2013-04-23 22:34:37 -04:00
Willem Jan Palenstijn
f279cc0e51
SCI: Add extra sanity check
2013-04-20 23:53:06 +02:00
Willem Jan Palenstijn
24b0b6aa43
SCI: Fix memory leak
2013-04-20 16:27:59 +02:00
Willem Jan Palenstijn
9694cbbaaf
SCI: Fix resource type range checks
2013-04-20 16:17:49 +02:00
Willem Jan Palenstijn
09fc458f15
SCI: Report sound stream loading errors
2013-04-20 16:13:41 +02:00
Willem Jan Palenstijn
e273a387a7
SCI: Replace workaround for bug #3605269 by script patch
2013-04-19 23:50:04 +02:00
Max Horn
51bde6ced5
SCI: Remove a bunch of unused private member variables
...
All instances uncovered by clang warnings.
2013-04-18 23:50:20 +02:00
Willem Jan Palenstijn
430db6719f
SCI: Fix confusing use of strncpy
2013-04-17 23:55:01 +02:00
Willem Jan Palenstijn
b1534913c1
SCI: Remove dead code
2013-04-17 23:49:08 +02:00
Willem Jan Palenstijn
e89c8c1923
SCI: Remove useless delete
2013-04-17 23:43:02 +02:00
Willem Jan Palenstijn
23da164136
SCI: Fix memory leak
2013-04-17 23:34:06 +02:00
Willem Jan Palenstijn
f280789afe
SCI: Don't suppress loop delta in SCI1 midi
...
This fixes bug #3293354 .
2013-04-16 23:10:09 +02:00
Willem Jan Palenstijn
457f5da095
SCI: Don't suppress end-of-track delta in SCI0 midi
...
This fixes the main part of bug #3487090 .
This seems to be a conversion error from SCI1's channel mixing to SCI0's
channel filtering code.
2013-04-16 23:04:33 +02:00
Matthew Hoops
8a50d87445
SCI: Fix potential memory leak with Mac cursor's hotspot
2013-04-16 11:14:04 -04:00
Matthew Hoops
6c1b019056
SCI: Fix mac cursor memory leak
2013-04-16 11:09:30 -04:00
Willem Jan Palenstijn
0250fd8ee1
SCI: Fix hunk entry leak
2013-04-15 21:46:09 +02:00
Willem Jan Palenstijn
2c9fe1d2c6
SCI: Fix memory leak
2013-04-15 21:40:11 +02:00
Willem Jan Palenstijn
f5a6ad6ab9
SCI: Fix memory leak
2013-04-15 21:38:21 +02:00
Willem Jan Palenstijn
8d184cddf7
SCI: Add missing break
2013-04-15 21:35:18 +02:00
Willem Jan Palenstijn
d17029dca2
SCI: Add missing break
2013-04-15 21:14:32 +02:00
Willem Jan Palenstijn
e34bfce2c2
SCI: Remove useless checks
2013-04-15 21:05:44 +02:00
Willem Jan Palenstijn
fbc1aac6a9
SCI: Fix uninitialized variables
2013-04-15 21:02:27 +02:00
Willem Jan Palenstijn
3f8d2fae8a
SCI: Remove unused variable
2013-04-15 20:58:22 +02:00
Filippos Karapetis
0b4ceb8bf7
SCI: Fix the entry of LSL7 French (patch #3610842 )
2013-04-15 12:26:22 +03:00
Willem Jan Palenstijn
cdf1900ce0
SCI: Add signal/fade related CHECKME
2013-04-07 18:22:41 +02:00
Willem Jan Palenstijn
6f3c83bd51
SCI: Minor cleanup
...
(Thanks waltervn)
2013-04-06 22:28:42 +02:00
Willem Jan Palenstijn
1e1cc7309f
SCI: Further clarify comment
2013-04-06 22:11:15 +02:00
Willem Jan Palenstijn
173a022f91
SCI: Clarify comment
2013-04-06 20:48:52 +02:00
Willem Jan Palenstijn
d0d9894b22
SCI: Revert "Fixed fading-related bugs #3267956 and #3041738 "
...
This reverts commit bfef0f5a6f
.
2013-04-06 20:46:15 +02:00
Willem Jan Palenstijn
6f3716ae74
SCI: Re-initialize more of MusicEntry on play
...
This fixes bug #3267956 .
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
18feefbe40
SCI: Notify scripts of completed fade when aborting it
...
This tweaks a fix/workaround (commit 96540686
) for bugs #3266480 and #3041738 .
Also add CHECKME to verify the accuracy of this workaround further.
This fixes the regressions #3291115 , #3555404 , #3596335 and #3610063 .
2013-04-06 20:31:34 +02:00