65 Commits

Author SHA1 Message Date
Eugene Sandulenko
ef385b14bc HDB: Plug a few memory leaks. Bug #11142 2020-08-26 22:44:19 +02:00
Eugene Sandulenko
4f8a6ae527 HDB: Free sounds when they're not needed 2020-08-26 22:44:09 +02:00
Eugene Sandulenko
a37e9a8f9a HDB: Replace NULL with nullptr 2020-04-28 09:42:27 +02:00
Eugene Sandulenko
c212217063 HDB: Remove redundant check 2020-04-27 18:29:39 +02:00
Henrik "Henke37" Andersson
1d9e7568fd HDB: Have a return value if the needed codec isn't included in the build. 2019-10-11 18:10:46 +02:00
Henrik "Henke37" Andersson
5675a00d8f HDB: Bail if the music stream couldn't be created. 2019-10-11 18:10:46 +02:00
Henrik "Henke37" Andersson
89b20bbb86 HDB: Factor out the song code into the Song class, avoiding a lot of duplicate code. 2019-10-11 18:10:46 +02:00
Eugene Sandulenko
9d028ac4ac HDB: Guard for corrupted sound data 2019-09-20 21:55:08 +02:00
D G Turner
df940b17af HDB: Close Memory Leaks in Sound Class 2019-09-13 21:20:19 +01:00
D G Turner
ec677b3fe9 HDB: Fix Crash on Invalid Sound String Pointers
This was causing a crash with buffer overflow on Windows builds, but
diagnosing with Valgrind showed invalid strings being accessed in the
sound code. Some analysis showed that these were mainly the reference
to c_str() buffers from a local heap Common::String which was out of
scope and thus destructed, giving an invalid pointer.

The fix here also simplifies the code as well as avoiding this issue.
2019-09-13 20:14:22 +01:00
Strangerke
220ef998bb HDB: Fix song 2 fading volume 2019-09-07 00:19:24 +02:00
Strangerke
82c47d75cd HDB: Fix the check for no free sound handle 2019-09-06 22:28:37 +02:00
Strangerke
555cd7d33e HDB: Fix potential out of bound 2019-09-06 22:25:33 +02:00
Strangerke
cf001b1116 HDB: Turn _voicesOn into a boolean 2019-09-06 22:14:12 +02:00
Strangerke
a9be9c1453 HDB: Small loop changes in sound 2019-09-06 00:44:54 +02:00
Strangerke
9ed4c340a2 HDB: Fix uninitialized variable in sound 2019-09-06 00:32:39 +02:00
D G Turner
541689eeb2 HDB: Add Missing Initializer in Sound Class
This fixes CID 1404916.
2019-09-05 08:47:02 +01:00
Eugene Sandulenko
73b6724b92 HDB: Do not allocate sound handles dynamically 2019-09-03 17:17:35 +02:00
Eugene Sandulenko
43f39b30de HDB: FUrther simplification of sound code 2019-09-03 17:17:35 +02:00
Eugene Sandulenko
d1ef6fc008 HDB: Cache sounds as data pointers. This fixes problem with distorted sounds 2019-09-03 17:17:34 +02:00
Eugene Sandulenko
9907ebed0a HDB: Simplified sound loading code 2019-09-03 17:17:34 +02:00
Nipun Garg
429bb7af4d HDB: Fix Sound caching to prevent Vorbis crash 2019-09-03 17:17:34 +02:00
Strangerke
2178770898 HDB: Change init functions to handle errors 2019-09-03 17:17:34 +02:00
Nipun Garg
6fbadccf08 HDB: Fix voice playing when no message on screen 2019-09-03 17:17:34 +02:00
Strangerke
29eb9dc9d6 HDB: Remove an unused member of Song, get rid of the return value of several sound functions 2019-09-03 17:17:33 +02:00
Eugene Sandulenko
da005a6118 HDB: Portability fixes 2019-09-03 17:17:32 +02:00
Nipun Garg
6581e48230 HDB: Add OGG Support for Linux 2019-09-03 17:17:32 +02:00
Strangerke
22251ec2a7 HDB: Introduce two new enums for the sound 2019-09-03 17:17:32 +02:00
Nipun Garg
c63d716180 HDB: Rewind played-out sounds 2019-09-03 17:17:31 +02:00
Nipun Garg
b51881c446 HDB: Change song names for PPC 2019-09-03 17:17:31 +02:00
Nipun Garg
d93c6ec724 HDB: Set Music and Voice to DisposeAfterUse::YES 2019-09-03 17:17:30 +02:00
Nipun Garg
13d7a0c934 HDB: Set DisposeAfterUse::NO in playStream() 2019-09-03 17:17:30 +02:00
Nipun Garg
bcb0171891 HDB: Fix WAV format checker and other minor fixes 2019-09-03 17:17:30 +02:00
Nipun Garg
b8bbc32a89 HDB: Add support for the PPC version 2019-09-03 17:17:30 +02:00
Nipun Garg
5fe9b6f6e7 HDB: Minor fixes in Sound Effects code 2019-09-03 17:17:29 +02:00
Eugene Sandulenko
0a6cd0a99a JANITORIAL: Beautify table formatting 2019-09-03 17:17:29 +02:00
Eugene Sandulenko
421ae7165e HDB: Added heuristic to determing sound file type 2019-09-03 17:17:29 +02:00
Eugene Sandulenko
fc0dd1fb1a HDB: Added demo sound constants 2019-09-03 17:17:29 +02:00
Nipun Garg
588d0235ae HDB: Comment out SND code until data is found 2019-09-03 17:17:29 +02:00
Nipun Garg
d3eacb7e0f HDB: Add playSound(), playSoundEx(), stopChannel() 2019-09-03 17:17:29 +02:00
Nipun Garg
2bb60c69cd HDB: Add Music/Song data and functions 2019-09-03 17:17:29 +02:00
Nipun Garg
3aa373ab2b HDB: Fix misplaced Enum value 2019-09-03 17:17:28 +02:00
Nipun Garg
123b65931e HDB: Add playVoice() 2019-09-03 17:17:28 +02:00
Nipun Garg
a09ac7b114 HDB: Add voice related data 2019-09-03 17:17:28 +02:00
Nipun Garg
4a44f62b10 HDB: Add extension field to SoundCache 2019-09-03 17:17:28 +02:00
Nipun Garg
1a7fc846cf HDB: Add Sound Cache 2019-09-03 17:17:28 +02:00
Eugene Sandulenko
a50e1469b7 HDB: Reduce header dependency 2019-09-03 17:17:28 +02:00
Eugene Sandulenko
e0b0d85f5b HDB: Reduce header dependency 2019-09-03 17:17:28 +02:00
Eugene Sandulenko
951943ecec HDB: Reduce header dependency 2019-09-03 17:17:28 +02:00
Eugene Sandulenko
91da8c7aab HDB: Reduce header dependency 2019-09-03 17:17:27 +02:00