Commit Graph

382 Commits

Author SHA1 Message Date
Orgad Shaneh
9937cc49bb DRAGONS: Use nullptr
Using clang-tidy modernize-use-nullptr
2021-11-14 15:51:59 +02:00
Orgad Shaneh
ee57380de7 ENGINES: JANITORIAL: Remove 'virtual' when override is specified 2021-11-14 14:32:04 +02:00
Orgad Shaneh
78ef6203de ENGINES: Fix getSavegameFile for almost all engines
Use kSimpleSavesNames correctly, add where needed, remove where needed.

Trac #12977
2021-11-10 21:49:48 +00:00
Orgad Shaneh
fe104cc337 ENGINES: Use MetaEngine consistently for getting autosave slot
The autosave refactoring that was done in
7adad5aaf5 used g_engine for identifying the
autosave slot. This worked for in-game save/load, but doesn't fit when
called from the launcher.

Fix by passing MetaEngine to SaveStateDescriptor ctor and using it for this
query.

Amends 7adad5aaf5.
2021-10-24 16:46:06 +02:00
Orgad Shaneh
7adad5aaf5 ENGINES: Streamline auto-save write/delete protection
Some engines call setAutosave and some don't. isAutosave is used to
determine if a saved game is an autosave, but in fact, on most cases it
just falls back to comparing the name to "Autosave".

This is wrong for several reasons:
* Older versions of ScummVM used Autosave 0.
* The name "Autosave" is translated, so if you change the language, it
  won't be detected.

Instead of relying on the name, use the well-known getAutosaveSlot() from
Engine/MetaEngine.

Fixes #12735.
2021-08-23 13:34:35 +02:00
Max Horn
2f1f8f502e DEVTOOLS: move credits from devtools/credits.pl to engines
This employs a "lazy" approach: the "format" for the credits stays
exactly as it was, i.e., perl code. Of course one may want to change
this to another format (e.g. YAML, JSON, XML; or also shell script or
AWK, like `configure.engine` uses). But I deliberately kept it simple,
to get a minimal change that is easy to verify. Any further changes to
e.g. the format can be layered atop this.
2021-08-05 00:01:46 +02:00
Donovan Watteau
77cad3b5d6 DRAGONS: More visual fixes for big-endian systems
Fix text and shadows so that graphics are now nearly the same between
little-endian and big-endian systems.

See https://bugs.scummvm.org/ticket/11710.
2021-04-27 04:01:44 +01:00
Cameron Cawley
ef0048fa77 COMMON: Add standard actions for mouse button clicks 2021-04-06 11:15:42 +03:00
Orgad Shaneh
e97fe996f2 DRAGONS: Fix format warning on MinGW64
pointer and long are not equivalent. Cast to int.
2021-03-24 22:56:01 +02:00
Donovan Watteau
b40541d0fb DRAGONS: Incomplete attempt at improving big-endian compatibility
It seems that screen content must be written in native endianness
here, not in little-endian.

This appears to fix most scenes, cutscenes, and the bag.

Shadows, menus, and text are still wrong. Audio hasn't been tested
yet.

See https://bugs.scummvm.org/ticket/11710.
2021-03-17 01:10:52 +02:00
Orgad Shaneh
cb7c6fb83e DRAGONS: Remove unused private member
Reported by Clang.
2021-03-16 02:44:37 +02:00
SupSuper
70dc08f46e JANITORIAL: Cleanup inconsistent includes 2021-02-22 10:54:07 +00:00
Cameron Cawley
4ced49acd4 ENGINES: Changed AdvancedMetaEngine::createInstance to return a Common::Error 2020-12-04 20:57:14 +00:00
Eugene Sandulenko
10793ed9fa DRAGONS: Use AD_ENTRY2s in the detection table 2020-11-28 14:06:41 +01:00
Eugene Sandulenko
5936026209 ALL: Clarify POTFILES, remove redundant common/translations.h includes 2020-11-10 03:03:49 +01:00
Fiodar Stryzhniou
6a7340f744 SYMBIAN: sync with 2.2.0 release.
Added new project files, build fixes.
2020-10-16 17:06:05 +02:00
Eugene Sandulenko
366a5f479d DRAGONS: Added override keyword 2020-10-14 19:39:46 +02:00
Eugene Sandulenko
7ff34bc9ec PLUGINS: MetaEngineStatic -> MetaEngineDetection 2020-10-11 23:14:39 +02:00
Eugene Sandulenko
7ea6781043 PLUGINS: PLUGIN_TYPE_METAENGINE -> PLUGIN_TYPE_ENGINE_DETECTION 2020-10-11 23:12:32 +02:00
aryanrawlani28
d26bbe521c ENGINES: ALL: Finish renaming ME & AME classes
- ME -> MetaEngineStatic (static parts)
- MEC -> MetaEngine (dynamic parts)
2020-10-03 14:56:36 +02:00
aryanrawlani28
a56dc094b9 ENGINES: ALL: Move detection_enums -> detection.h
- Cleans up headers quite a bit.
2020-10-03 14:56:36 +02:00
aryanrawlani28
29ceb07959 ENGINES: ALL: Revert detection submodule to be directly present in the engine directory
- DETECT_OBJS are present and added inside an engine's modules.mk file.
2020-10-03 14:56:36 +02:00
aryanrawlani28
f3b9477893 ENGINES: ALL: Add header guards for the new detection-header files. 2020-10-03 14:56:36 +02:00
aryanrawlani28
8189a05316 ENGINES: ALL: Adapt to changes for new plugins by defining a new detection module
For each engine:
- Make a new folder detection
- Move detection-related files inside the folder
- Add a new module "enginename/detection"
- Add DETECT_OBJS here
- Adjust the normal engine module to remove detect_objs
- Adjust every file for the new changes.
2020-10-03 14:56:36 +02:00
aryanrawlani28
cf69fce865 DRAGONS: Split detection features & adapt to new plugins. 2020-10-03 14:56:36 +02:00
aryanrawlani28
794909c7fc DRAGONS: Move common game-detection code to new header files. 2020-10-03 14:56:36 +02:00
Eric Fry
8f6fb1d4bf DRAGONS: Fixed alpha blending for scaled sprites. Fixes #11689 2020-09-13 15:35:36 +10:00
Eugene Sandulenko
5e888a601e DRAGONS: Add detection and support for Russian version 2020-09-13 01:06:47 +02:00
Eugene Sandulenko
5e2381eff9 DRAGONS: Improve error messages 2020-09-13 01:06:47 +02:00
Eric Fry
aae9d6cc97 DRAGONS: Remove unstable tag from DE and FR versions. Remove testing tag 2020-09-13 00:11:13 +10:00
Eric Fry
1470fb68de DRAGONS: Fixed mini game dialog for non US versions Fixes #11691 2020-09-13 00:02:25 +10:00
Eric Fry
bc59673407 DRAGONS: Fixed background dialog for non US versions. Fixes #11616 2020-09-11 23:41:38 +10:00
Eric Fry
c4d394654a DRAGONS: Fixed cutscene subtitles for non US versions. 2020-09-11 09:01:52 +10:00
Eric Fry
45b57f18d2 DRAGONS: Fixed cutscene dialogs for non US versions Trac#11613 2020-09-10 23:37:21 +10:00
Eric Fry
97294bcab4 DRAGONS: Fixed flicker not animating while talking with default responses 2020-09-09 22:22:36 +10:00
Cameron Cawley
2c88bb7c8f DRAGONS: Fix name of keymapper action 2020-09-08 08:51:38 +10:00
Eric Fry
f63025dc30 DRAGONS: Fixed coverity warning about negative indexing 2020-09-07 22:15:32 +10:00
Eric Fry
2dce756c50 DRAGONS: Allow quitting while talking to actors 2020-09-07 21:55:44 +10:00
Eric Fry
b657a83cf0 DRAGONS: Fixed dialog clearing in dance mini game 2020-09-07 21:46:39 +10:00
Eric Fry
43fe44f4bb DRAGONS: Fixed SFX play back volume. 2020-09-05 23:05:26 +10:00
Eric Fry
419009b684 DRAGONS: Fixed music volume when starting game. 2020-09-05 22:01:16 +10:00
Eric Fry
29487ad7e6 DRAGONS: Fixed incorrect sfx pitch. Trac#11638 2020-09-04 15:54:28 +10:00
Eric Fry
dea5af11f4 DRAGONS: Fixed crash on mini game 3 for non-english versions. Trac#11609 2020-09-04 13:25:19 +10:00
Eric Fry
ed63a2cbcb DRAGONS: Fix initial display of rabbits under the hats in the mini game. Trac#11641 2020-09-04 13:25:19 +10:00
Eric Fry
67d3753ef9 DRAGONS: Fixed missing dialog for jester in end credits Trac#11610 2020-09-03 23:27:33 +10:00
Eric Fry
1f359ee731 DRAGONS: Fixed actor dialog position 2020-09-03 23:26:40 +10:00
Eric Fry
11475ca989 DRAGONS: Fixed loading screen text in non-english versions Trac#11614 2020-09-01 23:47:30 +10:00
Eric Fry
e005e03089 DRAGONS: Fix cursor when selecting bag in non-english versions. Trac#11612 2020-09-01 23:46:01 +10:00
Eric Fry
913546593d DRAGONS: Fixed Flicker sprite priority when walking off screen. Trac#11642 2020-09-01 22:45:23 +10:00
aryanrawlani28
e22b32abfe GUI: U32: Use Common::U32String::format where necessary and GUIError to u32
- Where necessary as in, where translated messages are used.
- GUIErrorMessage now takes in U32String
- error messages across some engines use U32Strings. they are changed because they show a message dialog.
2020-08-30 14:43:41 +02:00