When adding/removing an engine, config.mk is changed, and this effectively
passes different -DENABLE_* command-line arguments to the compiler.
If base/plugins is not recompiled, the list of active plugins is not updated.
Before b813d1ca0d config.h was created every
time configure was executed, so everything was recompiled anyway. Now we need
to have an explicit dependency.
The only source file that's supposed to be affected is base/plugins, so there
is no reason to rebuild everything. Just add this dependency to update the
plugin list.
Different platforms have different levels of support of encodings and
often have slight variations. We already have tables for most encoding
with only CJK missing. Full transcoding inclusion allows us to get reliable
encoding results independently of platform. The biggest con is the need for
external tables encoding.dat.
It removes a duplicate table for korean in graphics/korfont.cpp
The output directory is not defined by the DOXYGEN_OUTPUT_DIRECTORY
environment variable instead of being hardcoded to `html`. Both the
make rule and the bash script set that variable to `html` by default,
but in the case of the bash script we can override it by defining
the variable in the environement before running the script.
Note: No detection objects added currently. It's just an empty variable uptill now.
- These DETECT_OBJS will be seen in action in the new commits
- They contain engine_name/detection.o
- They have MetaEngine code, which has detection features.
- This way, Executable will have linked against the detection.o files
- Detection.cpp files will be individually compilable and not dependent on engine
The main reason for that change is that there is a link to it from
the README.md file, so distributing CONTRIBUTING.md avoids having
a dead link in the distributed README.md.
In this case, the linker optimizes out Debugger which get required
later by Engine due to @dreammaster rework. Building with all engines
prevents optimization because several engines subclass Debugger and they
are included before gui.a in linker command line
Due to a quirk of target specific make variables which means they
are added to all pre-requisities, this resulted in the defines which
were meant to be applied only to the version module being applied to
most of the codebase.
This did not cause any direct issues, but was untidy and unexpected
behaviour which was reported in Pull Request 1946 by janisozaur.
Fix it by defining a special rule for version.o with own flags
instead of using template rule.
Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
