Eugene Sandulenko
7724e51936
FULLPIPE: Added debug output for GameObject
2017-12-08 23:57:48 +01:00
Eugene Sandulenko
1408ffc427
FULLPIPE: Better debug output for movement
2017-12-08 23:57:48 +01:00
Eugene Sandulenko
c728c29857
FULLPIPE: More debug output to loading
2017-12-08 23:57:48 +01:00
Bastien Bouclet
0bd2e53cd4
FULLPIPE: Fix handleInteraction for non static ani objects
...
cce851d1af introduced a check to allow only static ani objects. However
after this change, only part of the pipes for vertical movement were
interactive.
This change aims to restore functionality for the other object types
while still preventing the invalid casts.
2017-11-26 08:51:36 +01:00
Colin Snover
a8b635e4cd
FULLPIPE: Fix leaks of DynamicPhases
...
I am not entirely sure this is a correct fix for these leaks;
there is still the issue of the last member of _dynamicPhases being
invalidated and not removed sometime before the destruction of
Movement. Also, some of the items in this array are not actually
owned by Movement so deleting them will cause double-frees or
use-after-frees. It may be the case that a second list should be
maintained instead containing only the objects that are created
internally within Movement. Further testing will tell for sure.
2017-11-18 22:35:12 +01:00
Colin Snover
c7b1f6b26c
FULLPIPE: Clarify ownership of DynamicPhase::_exCommand
2017-11-18 22:35:12 +01:00
Colin Snover
a6fc77ec65
FULLPIPE: Clarify ownership of pointer arrays in StaticANIObject
2017-11-18 22:35:12 +01:00
Colin Snover
715d4bd76a
FULLPIPE: Fix memory leaks, ownership issues with various point lists
2017-11-18 22:35:12 +01:00
Colin Snover
bb26bf7994
FULLPIPE: Fix memory leaks and unnecessary indirect allocations in Motion and Sc2
2017-11-18 22:35:12 +01:00
Colin Snover
e2367f3ed2
FULLPIPE: Remove unnecessary and unsafe C-style casts
2017-11-18 22:35:12 +01:00
Colin Snover
384d68b679
FULLPIPE: Correctly fix Bitmap leaks
2017-11-18 22:35:12 +01:00
Colin Snover
14a6ff0810
FULLPIPE: Fix memory leaks of MovTable and remove unnecessary extra class
2017-11-18 22:35:12 +01:00
Colin Snover
7514c5289b
FULLPIPE: Remove manual memory management of streams
2017-11-18 22:35:12 +01:00
Colin Snover
350ddcee10
FULLPIPE: Take references instead of pointers for required arguments in statics, remove unnecessary Picture allocation
2017-11-18 22:35:12 +01:00
Colin Snover
6f8a65c739
FULLPIPE: Fix memory leak & unnecessary heap allocation of Rects
2017-11-18 22:35:12 +01:00
Colin Snover
0cc0b1932e
FULLPIPE: Fix memory leaks, ownership issues, and endianness issues in graphics code
2017-11-18 22:35:12 +01:00
Colin Snover
8e0c53de18
FULLPIPE: Fix whitespace errors
2017-11-18 22:35:12 +01:00
Colin Snover
88a2eaba93
FULLPIPE: Make dimensions/coordinate getters pure functions
2017-11-18 22:35:12 +01:00
Colin Snover
136223026e
FULLPIPE: Remove illegal C-style cast to incompatible type
2017-11-18 22:35:12 +01:00
Filippos Karapetis
b0b0971b3e
FULLPIPE: Plug one more memory leak in the Movement class destructor
2017-03-24 00:56:12 +02:00
Filippos Karapetis
a93c8c5d3e
Unify all string function parameters to be const Common::String &
...
Thanks to wjp for the suggestion
2017-03-24 00:56:11 +02:00
Filippos Karapetis
3e515890e8
FULLPIPE: Plug a memory leak in _dynamicPhases
...
Free the pixel data of each entry in the _dynamicPhases array before
emptying it
2017-03-22 23:05:38 +02:00
Filippos Karapetis
8bc03c87c5
FULLPIPE: Fix corruption in flipped bitmaps
...
The TODO in the code in question should be reviewed, but the call to
freePixelData() unconditionally deleted the original bitmap, which is
not correct
2017-03-22 23:02:52 +02:00
Filippos Karapetis
808e465e7e
FULLPIPE: _data is unused in the Statics and DynamicPhase classes
2017-03-22 22:58:22 +02:00
Filippos Karapetis
2649e2b1fc
FULLPIPE: Change genFileName() and loadFile() to use Common::String
2017-03-22 04:50:37 +02:00
Filippos Karapetis
93982b2ca9
FULLPIPE: Change more object-related functions to use Common::String
2017-03-22 04:32:23 +02:00
Filippos Karapetis
f3e81b5f17
FULLPIPE: Use Common::String in all scene object names
2017-03-22 04:11:49 +02:00
Filippos Karapetis
728b23af2a
FULLPIPE: Change transCyrillic() to accept a Common::String
2017-03-22 04:07:33 +02:00
Filippos Karapetis
93e93b5640
FULLPIPE: Use Common::String with _memfilename and loadFile()
...
There are several calls to loadFile() with _memfilename, which is why
these two changes are interconnected
2017-03-22 03:10:32 +02:00
Filippos Karapetis
a2b4d637db
FULLPIPE: Change _staticsName to be a Common::String
2017-03-22 03:02:58 +02:00
Aaryaman Vasishta
cc917882a6
FULLPIPE: Fix leaks in surface and bitmap usage.
...
Fixes part of bug #9654 .
2016-12-31 00:55:33 +09:00
Eugene Sandulenko
a62d29ab86
FULLPIPE: Revert memory leak fixing as that introduced tons of regressions
2016-12-13 18:15:41 +01:00
Eugene Sandulenko
c5e55878ad
FULLPIPE: Plug more memory leaks
2016-12-12 23:35:32 +01:00
Eugene Sandulenko
9075cbc1ba
FULLPIPE: Fix memory leak in bitmap code
2016-12-12 23:00:41 +01:00
Eugene Sandulenko
3653f03d30
FULLPIPE: Plug more memory leaks
2016-12-12 20:19:31 +01:00
Eugene Sandulenko
88a3a2bc4d
FULLPIPE: Clarify null callback usage across the scenes
2016-12-10 14:42:36 +01:00
Eugene Sandulenko
56490360c2
FULLPIPE: Fix if statement. Thanks to PVS-Studio
2016-10-26 01:51:39 +02:00
Retro-Junk
fb66de5bb9
FULLPIPE: Fix Movement::calcDuration
2016-09-24 17:32:20 +02:00
Eugene Sandulenko
726b54d15c
FULLPIPE: Added more debug output to scene09. Clarified pixel data type.
2016-09-21 21:22:22 +02:00
Eugene Sandulenko
25d1522166
FULLPIPE: Remove obsolete warning
2016-09-21 08:11:55 +02:00
Eugene Sandulenko
d9457c2f07
FULLPIPE: Remove workaround and follow the original in StaticANIObject copy constructor
2016-09-18 00:16:29 +02:00
Retro-Junk
f67bbd9f8c
FULLPIPE: Fix StaticANIObject::getMovementIdById
2016-09-18 00:16:29 +02:00
Retro-Junk
782e31d78c
FULLPIPE: Fix reversed statics initialization
2016-09-11 00:29:34 +02:00
Retro-Junk
9ef6980770
FULLPIPE: Fix out of bounds write in Movement::removeFirstPhase
2016-09-10 23:55:46 +02:00
Retro-Junk
45732d0b03
FULLPIPE: Fix Movement::loadPixelData
2016-09-10 23:55:40 +02:00
Eugene Sandulenko
a021b4c7e8
FULLPIPE: Added and using StaticANIObject::isPixelHitAtPos()
2016-09-07 12:12:31 +02:00
Eugene Sandulenko
5dddde199f
FULLPIPE: Further work on the hangers in scene09
2016-09-07 10:36:51 +02:00
Eugene Sandulenko
b4153bef61
FULLPIPE: Fix invalid read
2016-09-07 09:45:18 +02:00
Eugene Sandulenko
2cbf7da319
FULLPIPE: Rename is GabeObject
2016-09-05 00:11:07 +02:00
Eugene Sandulenko
26f55005b3
FULLPIPE: Rename in ExCommand structure
2016-09-04 23:54:43 +02:00
