58294 Commits

Author SHA1 Message Date
D G Turner
8a65f44311 HDB: Remove Another Fixed Size String Buffer
This reduces the scope for buffer overflow issues.
2019-09-15 00:03:11 +01:00
sluicebox
00548e15ed SCI32: Remove QFG4 "a:" prefix from export filename
Trac #11082
2019-09-14 12:53:25 -07:00
Filippos Karapetis
6accd633b8 SCI: Add a sanity check when loading vocab 901 (suffixes)
An invalid access error, uncovered by the Span mechanism. Fixes the
QFG2 demo (bug #11147)
2019-09-14 20:53:10 +03:00
Eugene Sandulenko
e00b2064a5 SCI: Add special check for Russian versions of the games 2019-09-14 16:13:11 +02:00
Filippos Karapetis
9dd63b12b1 SCI: Add more script patcher checks for games without a selector vocab
Fixes the LSL1 demo
2019-09-14 11:39:35 +03:00
D G Turner
8555657207 HDB: Improve String Code Usage in HDB Engine Code 2019-09-14 03:03:17 +01:00
D G Turner
076514da3f HDB: Improve String Buffer Usage in AI Inventory Code 2019-09-14 02:47:55 +01:00
D G Turner
8fe7f80d0c HDB: Replace Unecessary Buffer in AI Inventory Code 2019-09-14 02:38:53 +01:00
D G Turner
64e2a21a17 HDB: Avoid String Buffer Overruns from Save Load Code 2019-09-14 02:27:06 +01:00
D G Turner
817bcc4c24 HDB: Remove Fixed String Buffer Usage in Window Code 2019-09-14 02:12:13 +01:00
D G Turner
7064698b60 HDB: Removed Fixed String Buffer from AI Player Code
This is replaced by simpler Common::String equivalent.
2019-09-14 02:01:57 +01:00
D G Turner
0d498a2036 HDB: Remove More Fixed Sized String Buffers in Menu Code 2019-09-14 01:43:09 +01:00
Ben Castricum
d7af4a8c1c ENGINES: More consistent error messages 2019-09-14 01:36:37 +01:00
D G Turner
04d522121b HDB: Remove Fixed Sized String Buffers in Menu Code
These are replaced by Common::String usage.
2019-09-14 01:22:25 +01:00
Thierry Crozat
011a9cd43f SUPERNOVA: Fix warning 2019-09-14 00:32:25 +01:00
D G Turner
a7c881e56d SUPERNOVA: Replace String Copy With Safer ScummVM Common Version 2019-09-14 00:26:47 +01:00
D G Turner
117733ad0a HDB: Fix More GCC Compiler Warnings 2019-09-14 00:07:47 +01:00
Thierry Crozat
7f05cba9f1 SUPERNOVA: Change type of an array to avoid casting 2019-09-13 23:51:22 +01:00
D G Turner
2c5cdfb37e SUPERNOVA: Fix Reported MSVC Compiler Warnings
These are from Henke37 via IRC.
2019-09-13 23:20:31 +01:00
D G Turner
c0d6a8fc7a HDB: Further Fixes for GCC Compiler Warnings 2019-09-13 23:06:32 +01:00
D G Turner
c01598484e HDB: Fix Some GCC Compiler Warnings
These were of the type memset of a complex structure.
2019-09-13 22:41:41 +01:00
D G Turner
b940fb7588 HDB: Fix Major Memory Leak in File Manager Class 2019-09-13 21:50:55 +01:00
D G Turner
df940b17af HDB: Close Memory Leaks in Sound Class 2019-09-13 21:20:19 +01:00
Thierry Crozat
ced80c6da4 SUPERNOVA: Add testing flag and build engine by default 2019-09-13 21:16:52 +01:00
D G Turner
6f265805ec HDB: Ensure Demos are Indicated in ScummVM GUI Launcher List 2019-09-13 20:33:55 +01:00
D G Turner
ec677b3fe9 HDB: Fix Crash on Invalid Sound String Pointers
This was causing a crash with buffer overflow on Windows builds, but
diagnosing with Valgrind showed invalid strings being accessed in the
sound code. Some analysis showed that these were mainly the reference
to c_str() buffers from a local heap Common::String which was out of
scope and thus destructed, giving an invalid pointer.

The fix here also simplifies the code as well as avoiding this issue.
2019-09-13 20:14:22 +01:00
sluicebox
db3e3285d4 SCI32: Disable QFG4 Change Directory import button 2019-09-12 21:07:37 -07:00
Thierry Crozat
a7a312ec2f SUPERNOVA: Enable improved mode by default
Masochists who want to experience the original frustrating
experience can disable it in the game settings.
2019-09-13 01:32:15 +01:00
Thierry Crozat
71e0f58775 SUPERNOVA: Stop any playing sound before loading a savegame
This fixes for exemple loading a savegame from the Museum in part 2
after triggering the alarm but before being caught. Before this
commit the alarm would continue to play after loading the savegame.
2019-09-13 01:08:30 +01:00
Thierry Crozat
2999d77dd8 PRINCE: Build engine by default 2019-09-13 01:08:30 +01:00
Cameron Cawley
c786b139db BLADERUNNER: Remove use of unaligned memory access (#1839) 2019-09-12 22:02:52 +02:00
sluicebox
debe259074 SCI32: Fix loading system font for Mac games
Fixes GK1 Mac crash on load due to reading hard-coded
little endian font data as big endian
2019-09-12 12:02:56 -07:00
sluicebox
698ca464d7 SCI32: Fix loading autosaves (slot 0)
Fixes bugs in trac #11029:

- Slot 1 loading when user selects slot 0 in ScummVM UI
- Slot 1 loading when slot 0 specified on command line
- QFG4 slot 0 not appearing in game's original Restore UI
2019-09-12 11:58:20 -07:00
Cameron Cawley
5413e89a6b BLADERUNNER: Ensure the Color256 struct is correctly packed (#1838) 2019-09-11 18:47:44 +02:00
David Fioramonti
1ed2cd40f3 CRYO: EDEN: Move graphics into a separate class
Eden game object now contains a graphics object with which to
delegate graphics operations and store states of the graphics.

Much of the video playing is done in the graphics class
so I have moved a lot of the video state into there.

Some graphics related variables were moved out of eden and into
graphics, but many are still in eden.

Since they are still coupled there are lots of getters and setters.
For example both eden_graphics and eden share a handle to the same
video object.

I have made a few more things public than desirable.

I changed graphics to eden_graphics since it is specialized to eden
and not just cryo.
2019-09-11 12:28:28 +03:00
sluicebox
b8bdc6ccc3 SCI32: Fix QFG4 Gate options after dungeon
Fixes bug #11044
2019-09-10 18:49:22 -07:00
sluicebox
76ddbe7bd9 HDB: Fix empty string test 2019-09-10 16:20:19 -07:00
Cameron Cawley
d8820de8b0
BLADERUNNER: Fix -Wsign-compare warning 2019-09-10 22:36:22 +01:00
Thanasis Antoniou
2003c12bc3 BLADERUNNER: Move shutdown() in Engine destructor 2019-09-10 19:18:45 +03:00
Thanasis Antoniou
bef3f902e6 BLADERUNNER: Add DebugMan.clearAllDebugChannels() in shutdown 2019-09-10 19:18:45 +03:00
Strangerke
299c28e93e HDB: Remove useless check on array vs null 2019-09-09 23:22:22 +02:00
Strangerke
5e0fa2a71c HDB: Fix more uninitialized variables in Gfx and Window 2019-09-09 23:16:26 +02:00
Strangerke
0e04da2cc8 HDB: Fix more uninitialized variables in ai-init 2019-09-09 22:47:27 +02:00
Strangerke
9de42a143a HDB: Fix a pointer to local variable outside of scope 2019-09-09 22:30:17 +02:00
Thanasis Antoniou
cd6ebdc88b BLADERUNNER: Allow McCoy to perform both turns when feeding Maggie
First animated turn is to the counter, second is towards Maggie
2019-09-09 22:01:36 +03:00
Thanasis Antoniou
f5b79a4cdf BLADERUNNER: Play full exit KIA sound before quit via KIA 2019-09-09 21:09:36 +03:00
Thanasis Antoniou
e3ebca78dc BLADERUNNER: Improve interaction with Gordo in the city 2019-09-09 20:37:02 +03:00
Thanasis Antoniou
8f4d3654f2 BLADERUNNER: Fix Leon Clerk encounter bug
When McCoy leaves CT09 they should be both gone. They were not

This was our bug, a bad translation of an if clause.
Also added in this commit is a bit different behavior for the restored content case.
In restored content, the player is not allowed to leave until the situation is resolved.
2019-09-09 18:07:21 +03:00
Thanasis Antoniou
3827000fe1 BLADERUNNER: Replace animation mode values with their proper enums 2019-09-09 16:10:31 +03:00
Thanasis Antoniou
a4f9842065 BLADERUNNER: Fix CT02 map obstacles glitches 2019-09-09 16:10:31 +03:00