The previous commit was not sufficient as getIconsSet() returns a
reference to the SearchSet and it could then be used after the
mutex had been unlocked and while it was being modified in
initIconsSet() called in another thread.
The icons download dialog was triggering the grid launcher update after
icons had been downloaded. But that means no update was done if the
dialog had been closed during the download.
Now the GUIManager triggers the update. This fixes the missing update
when hiding the download dialog while downloading an icon set.
The detection was done on the dropped path, so it worked when
dropping a directory, but not a file. Now we can drop a file
and it will run the detection on the parent directory.
* GUI: rename buttons
Rename Edit Game to Game Options and Options to Global Options to make it less confusing.
Remove ellipsis on launcher buttons.
* GUI: put ellipsis back
* GUI: abbreviate options button texts for lowres
* GUI: use 320 width for lowres
* GUI: remove ellipsis from About button
The current recommended and de factor behavior from both Microsoft and Apple is to have "About" menus be without trailing ellipses. Therefore, I think we should follow suit.
Traditionally, About menus and buttons had a trailing ellipsis. [This article](https://uxdesign.cc/dot-dot-dot-7ce6170bfc7f) demonstrates this behavior for both Mac OS 1.0 (technically "System 1.0") and Windows 1.0.
However, current versions of macOS and Windows do not have a trailing ellipsis in About menus. Moreover, their design guidelines recommend not using them. From [Apple](https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/):
> Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice.
Since no additional input is required from the user for the About menu, it is inappropriate to use an ellipsis according to these guidlelines.
Microsoft [explicitly says](https://docs.microsoft.com/en-us/windows/win32/uxguide/ctrl-command-buttons) that About menus should not have an ellipsis (emphasis mine):
> This doesn't mean you should use an ellipsis whenever an action displays another window only when additional information is required to perform the action. Consequently,** any command button whose implicit verb is to "show another window" doesn't take an ellipsis, such as with the commands About**, Advanced, Help (or any other command linking to a Help topic), Options, Properties, or Settings.
Given all this, I think we should be in line with current best practices and remove it from the menu.
- Replace inscription with an icon to save space
- Reduced size of the search box
- Disbled grid for low-res layouts
- Fixed classic theme
- Regenerated built-in theme
