841 Commits

Author SHA1 Message Date
Strangerke
976410c4a4 BAGEL: Fix comments in list.h, reduce a couple of variable scopes 2024-05-24 08:08:20 +01:00
Strangerke
f357df8bb4 BAGEL: Remove unused parameters in bofMemFree(), fix function doc for encrypt() 2024-05-24 08:08:20 +01:00
Strangerke
4991699bda BAGEL: Use fatalError when bofMemAlloc doesn't manage to allocate memory ALLOC_FAIL_RETRIES times in a row 2024-05-23 23:17:31 +01:00
Strangerke
2f8d8567d3 BAGEL: Initialize two variables in CBofTextBox 2024-05-23 23:17:31 +01:00
Strangerke
3d78ac4d81 BAGEL: Don't check for errCode in datalError(), so there's no path which returns instead or erroring out 2024-05-23 08:14:11 +01:00
Strangerke
52fcf3ef58 BAGEL: Fix some more PVS Studio issues, add some missing override keywords 2024-05-22 23:44:26 +01:00
Strangerke
c333222e3a BAGEL: Remove scrollDown, change the definition of fadeLines and scrollUp in order to remove the unused parameters, clean the implementation 2024-05-22 08:32:12 +01:00
Strangerke
62f9284afe BAGEL: Fix a couple of potential memory leaks in CBagMovieObject, remove a useless part of a check (mention by PVS Studio) 2024-05-22 08:18:44 +01:00
Strangerke
3f09c38747 BAGEL: Fix several PVS Studio issues 2024-05-21 23:50:38 +01:00
Strangerke
2c562525c1 BAGEL: Fix several PVS Studio issues 2024-05-21 18:50:44 +01:00
Strangerke
87dafae34d BAGEL: Fix some PVS Studio issues 2024-05-21 18:33:22 +01:00
Paul Gilbert
6203267f0b BAGEL: Fix rendering of checkboxes in sraf computer 2024-05-20 20:37:44 -07:00
Strangerke
7f6189b7b9 BAGEL: Fix for two mostly false positives (null dereferencing before check a value which isn't null, and an error in variable names) 2024-05-20 15:55:38 +01:00
Strangerke
7b76ec5f73 BAGEL: Initialize variables in CBagPanBitmap 2024-05-20 15:27:29 +01:00
Strangerke
7f5f248ecb BAGEL: Fix several false positive null dereferencing before null check by remove useless nulls checks 2024-05-20 12:32:19 +01:00
Strangerke
cb83247d61 BAGEL: remove useless nullptr check causing false positive of null derenference in Coverity (Fix CID 1545892 and 1545905) 2024-05-20 08:55:17 +01:00
Strangerke
e6257e1e32 BAGEL finish removing useless null checks and asserts after new in spacebar folder 2024-05-19 22:20:57 +01:00
Strangerke
7c4cb6f3c2 BAGEL: start working on useless null checks after new in spacebar folder 2024-05-19 22:20:56 +01:00
Strangerke
5e47f541f7 BAGEL: Remove some more useless checks in dialogs 2024-05-19 22:20:56 +01:00
Strangerke
dbe6620007 BAGEL: Remove 3 unused includes and a constant in boflib 2024-05-19 22:20:56 +01:00
Strangerke
d120d3822f BAGEL: Remove some more useless checks in boflib 2024-05-19 22:20:55 +01:00
Strangerke
f75fef4626 BAGEL: Remove some more useless checks in boflib/gui 2024-05-19 20:37:44 +01:00
Strangerke
c7229574ef BAGEL: Remove an unused function in CBofSprite 2024-05-19 20:27:29 +01:00
Strangerke
23a8fccd85 BAGEL: Remove some more useless checks, turn some functions into void functions 2024-05-19 20:27:29 +01:00
Strangerke
c2727b1d1d BAGEL: Change the type pour CBagSoundObject::newSound to avoid an unused return value 2024-05-19 13:25:27 +01:00
Strangerke
a17658a6f4 BAGEL: More work on useless null checks 2024-05-19 13:24:35 +01:00
Strangerke
c26b99ae9d BAGEL: More work on null checks after new 2024-05-19 13:12:56 +01:00
Strangerke
b5698f8f76 BAGEL: Remove useless null checks after variable creation by new (as it's covered by an exception) 2024-05-19 13:12:55 +01:00
Strangerke
3aba291b72 BAGEL: Fix several PVS studio issues 2024-05-18 21:59:42 +01:00
Strangerke
687e66656c BAGEL: Fix 2 other PVS Studio issues + use a constant instead of a hardcoded value in setCorrection 2024-05-18 16:26:41 +01:00
Strangerke
4514cc67aa BAGEL: Fix some pvs-studio issues in CBagButtonObject 2024-05-18 13:48:22 +01:00
Strangerke
64f09fa4af BAGEL: Add safeguards in SrafComputer to avoid out of bounds writes 2024-05-18 13:21:12 +01:00
Strangerke
54247f9ba7 BAGEL: Remove useless variable in SBarSlotWnd 2024-05-18 09:52:46 +01:00
Strangerke
53f262df50 BAGEL: In SBarSlotWnd, add some variable initialization, fix null dereferencing (CID 1544829, 1544880) 2024-05-18 09:51:04 +01:00
Strangerke
9a3dd02b56 BAGEL: Fix null dereferencing in CMainWindow (CID 1544851, 1544860, 1544882) 2024-05-18 09:44:44 +01:00
Strangerke
5219ecbedd BAGEL: Ensure that storage device has been found bedore using it in VildroitFilter (CID 1544844) 2024-05-18 09:25:56 +01:00
Strangerke
ba6d6c65ca BAGEL: Fix potential null dereferencing (CID 1544820, 1544876) 2024-05-18 09:18:48 +01:00
Strangerke
9626df189b BAGEL: Add missing initialization in CBibbleWindow (CID 1544869) 2024-05-18 08:52:58 +01:00
Strangerke
7c167364c0 BAGEL: Add a check to avoid a potential null dereferencing in CBagSaveDialog(CID 1544826) 2024-05-18 08:48:26 +01:00
Paul Gilbert
4ddad9fcd5 BAGEL: Minor bibble area defs field renamings 2024-05-17 20:21:21 -07:00
Paul Gilbert
b2456f04e4 BAGEL: Fix positioning of bibble betting odds 2024-05-17 20:17:37 -07:00
Paul Gilbert
96e134ad59 BAGEL: Changed console fleebix cmd to jammer, say whether it's correctly set 2024-05-17 19:03:03 -07:00
sentrywasbored
c635929f37 BAGEL: Added 'megawave' and 'microwave' Console Commands 2024-05-17 18:49:56 -07:00
Strangerke
007e377148 BAGEL: Add a check to avoid a potential null dereferencing in CBagRestoreDialog(CID 1544883) 2024-05-17 22:33:53 +01:00
Strangerke
f43eb286de BAGEL: Add a check to avoid a potential null dereferencing (CID 1544863) 2024-05-17 22:28:09 +01:00
Strangerke
e6c993271f BAGEL: Revert sound assert change, modify the sound flags used for blue and green ships in VildroidFilter(). Reduce some if depths. 2024-05-17 22:07:19 +01:00
Paul Gilbert
7acd975534 BAGEL: Fix SAVTURNCOUNT getting reset as conv starts 2024-05-16 21:47:47 -07:00
Paul Gilbert
a8a01575e7 BAGEL: Make console var command case insensitive 2024-05-16 21:47:47 -07:00
SupSuper
a5253b169b BAGEL: Disable keymapper during save text input 2024-05-16 22:16:17 +01:00
Strangerke
9407e9f46a BAGEL: Fix crash due to incorrect assert in sound code 2024-05-16 19:27:03 +01:00