Bug #11430.
Enabling Dark Mode compatibility, either by using NSRequiresAquaSystemAppearance
on older SDKs, or by using 10.14+ SDKs, makes the display blurry on
Retina screens on Mojave (and probably Catalina).
This is probably a macOS bug:
https://bugzilla.libsdl.org/show_bug.cgi?id=5087
Revert commit 485e8bee17 for now.
On macOS Catalina, the application needs to ask for permissions to
access some folders, such as the Desktop, Downloads, and Documents
folder. It for example asks for permission when listing files in
one of those folders or trying to read a file that was created by
another application and not selected using the system Open panel.
Since the default savegame path on macOS is in the Documents
folder it will ask for permissions to access this folder when we
open the Load Game dialog or try to load a savegame that was
copied there manually). So, while not required, it seems a good
idea to provide an explanation why ScummVM wants access to the
Documents folder.
macOS 10.14 introduced a dark theme in addition to the nornal
aqua theme. Applications compiled with the 10.14 SDK or above
are automatically opt in for both, but applications compiled
with an older SDK are not and still use the aqua theme even
when the system is set to use the dark theme. Those applications
need to explicitely opt in to use the dark theme.
This fixes bug #11305: Dark Mode is not supported
It appears that Mac Sparkle does not ignore the Windows binaries,
and offers to upgrade to Windows executable. Thus, in the meantime
we supply binary with the version change only.
This involves moving the NSDockTilePlugIn code to backend/taskbar
and fixing style to follow our coding conventions. One make target
was also renamed. All in all there is no change in functionality with this
commit.