Commit Graph

135 Commits

Author SHA1 Message Date
Le Philousophe
3276c7d501 ENGINES: Fix global constructor warning
I don't know why Clang (and GCC) creates a global constructor when we
use a global variable with a pointer.
Using an array instead seems to please both of them.
2024-08-28 17:09:56 +02:00
Le Philousophe
65c0429045 ALL: Declare the Game not implemented message in only one place 2024-08-17 17:51:06 +03:00
Le Philousophe
07daa6c225 ENGINES: Simplify EngineManager::findTarget
Do not make it return the detection plugin. It's never used anymore and
tends to imply that detection plugin can be used alongside the engine
plugin.
2024-06-30 18:39:06 +02:00
Le Philousophe
55ac8ba07f PLUGINS: Remove default value for EngineMan::getPlugins argument
This is now obvious of which type is the list of plugins returned.
2024-06-30 18:39:06 +02:00
Le Philousophe
ebdcf6ccd6 ENGINES: Mark getName() functions as overrides
They do override PluginObject::getName().
This is more readable that calling this method is the same as calling it
on PluginObject.
2024-06-30 18:39:06 +02:00
Le Philousophe
2645b1431c PLUGINS: Rename findPlugin to findDetectionPlugin
This function does return a MetaEngineDetection plugin
2024-06-30 18:39:06 +02:00
Le Philousophe
a7d0db4947 ENGINES: Let MetaEngine delete the engine
This will allow to cleanup other data managed by the MetaEngine (game
descriptors).
2024-06-30 18:39:06 +02:00
Le Philousophe
98d6f155d2 ENGINES: Split Engine::createInstance in two
This brings a cleaner separation between AdvancedMetaEngineDetection and
AdvancedMetaEngine.
2024-06-30 18:39:06 +02:00
Cameron Cawley
1357bfe672 COMMON: Avoid including engine headers in common code for DebugChannelDef 2024-06-20 20:15:57 +01:00
scemino
599adef9d5 ACHIEVEMENTS: Allow to override the default achievements platform 2024-04-23 13:37:01 +02:00
scemino
8807ab74db BACKENDS: New imgui proposition 2024-03-07 20:08:26 +01:00
scemino
0cba66b204 TWP: Move ImGui to backends 2024-03-07 20:08:26 +01:00
Cameron Cawley
9c86add634 ENGINES: Remove MetaEngineDetection::parseAndCustomizeGuiOptions() 2023-08-28 22:59:50 +02:00
Abhinav Chennubhotla
bb20579bee BASE: Add dumpAllDetectionEntries() to commandLine
- Add virtual function dumpDetectionEntries() to
   MetaEngine
 - Glk, Sky and SCUMM do not have proper
   definitions for dumpDetectionEntries()
 - Add md5PropToGameFile() to extract prefixes for
   md5s
 - AdvancedDetector writes content of DAT file to
   STDOUT
2023-07-03 13:54:50 +03:00
elasota
d1571d0195 ENGINES: Add functions to decompose the date and time values from a savegame header 2023-06-19 08:32:01 +03:00
Thierry Crozat
ede44360b7 ENGINES: Add function in MetaEngineDection to get the number of game variants 2023-06-09 18:21:47 +02:00
Eugene Sandulenko
d80de9511e
ENGNES: Reduced MASSIVE and unneeded dependency from gui_options.h header 2023-02-23 14:03:08 +01:00
Roberto Sánchez
e2b0259d29 BASE: Add function EngineManager::generateUniqueDomain 2022-12-07 22:58:48 +01:00
Eugene Sandulenko
8f8d522913
COMMON: Move achievements.* to engines/ 2022-12-02 00:12:22 +01:00
Cameron Cawley
6506e59064 ENGINES: Add getMD5Bytes to the base MetaEngineDetection class 2022-11-30 23:29:37 +02:00
Cameron Cawley
2c8a7d3900 ENGINES: Remove support for GUI options in MetaEngineDetection subclasses 2022-11-16 23:58:54 +01:00
Cameron Cawley
fd37e09acb ENGINES: Allow getExtraGuiOptions() to be implemented in MetaEngine subclasses 2022-11-16 23:58:54 +01:00
athrxx
a84336c583 COMMON: more flexible gui options handling
This allows the meta engines to post process the gui options,
before they get to be used in the GUI. This allows adding or
removing options on a larger scale without having to modify
each detection entry individually. In this case, it is meant to be
used in the SCUMM engine, to allow adding render mode
gui options wothout modifying the tables.
2022-11-07 00:27:34 +02:00
Cameron Cawley
f3b094e53f ENGINES: Change the MetaEngineDetection interface to match MetaEngine 2022-07-23 23:31:58 +02:00
athrxx
54af166305 COMMON: (AD) - further reduce output of mass add detection
Follow-up to the feature that allows skipping certain ADGF flags.

This here now also allows skipping of incomplete file/md5/size matches. It is basically the same behavior as the graylist. For the mass add all files are treated as if they are on the list.
2022-06-12 10:12:39 +02:00
athrxx
e01416ef32 COMMON: (AD) - allow mass add to skip targets with certain ADGF flags
I added skipping for the ADGF_WARNING and ADGF_UNSUPPORTED flags.

For me, this is mostly about fixing bug no. 13282. We sometimes have bogus entries which only have the purpose of presenting the error message (reasons for being unsupported) contained in the extra field of the detection entry.
2022-06-12 10:12:39 +02:00
Torbjörn Andersson
e06f3c9a5a GUI: Allow game option checkboxes to be disabled
Depending on other game option checkboxes. This is used to
enable/disable the semi-smooth scrolling checkboxes for FM Towns Loom,
since it's only used when smooth scrolling is enabled.
2022-04-21 11:07:17 +02:00
Orgad Shaneh
eed2e93d03 ENGINES: Fix GCC warnings
In file included from C:/Projects/scummvm/common/array.h:25,
                 from C:/Projects/scummvm/common/achievements.h:25,
                 from C:/Projects/scummvm/engines/metaengine.h:25,
                 from C:/Projects/scummvm/engines/advancedDetector.h:25,
                 from C:/Projects/scummvm/engines/sci/detection.cpp:22:
C:/Projects/scummvm/common/scummsys.h:400:44: warning: attribute ignored [-Wattributes]
  400 |                 #define WARN_UNUSED_RESULT [[nodiscard]]
      |                                            ^
C:/Projects/scummvm/engines/metaengine.h:565:16: note: in expansion of macro 'WARN_UNUSED_RESULT'
  565 |         static WARN_UNUSED_RESULT bool readSavegameHeader(Common::InSaveFile *in, ExtendedSavegameHeader *header, bool skipThumbnail = true);
      |                ^~~~~~~~~~~~~~~~~~
C:/Projects/scummvm/common/scummsys.h:400:44: note: an attribute that appertains to a type-specifier is ignored
  400 |                 #define WARN_UNUSED_RESULT [[nodiscard]]
      |                                            ^
C:/Projects/scummvm/engines/metaengine.h:565:16: note: in expansion of macro 'WARN_UNUSED_RESULT'
  565 |         static WARN_UNUSED_RESULT bool readSavegameHeader(Common::InSaveFile *in, ExtendedSavegameHeader *header, bool skipThumbnail = true);
      |                ^~~~~~~~~~~~~~~~~~
2022-01-12 23:53:27 +02:00
Eugene Sandulenko
abea37c9bb
ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Eugene Sandulenko
ccfaf478ab
AD: Make sure that we initialize hashmaps. Unfortunately, this leads to less const'ness 2021-11-29 01:50:03 +01:00
Orgad Shaneh
78ef6203de ENGINES: Fix getSavegameFile for almost all engines
Use kSimpleSavesNames correctly, add where needed, remove where needed.

Trac #12977
2021-11-10 21:49:48 +00:00
Cameron Cawley
2f99746d8d ENGINES: Allow implementing registerDefaultSettings in the MetaEngine class 2021-09-18 11:57:29 +02:00
Orgad Shaneh
c8c429a425 ENGINES: Document -1 as return value of getAutosaveSlot when not supported 2021-09-10 19:38:39 +03:00
Orgad Shaneh
6aeda12247 ENGINES: Warn when overwriting a non-autosave on autosave 2021-08-23 13:34:35 +02:00
Orgad Shaneh
f32624c8f2 ENGINES: Remove unimplemented function declaration 2021-08-21 23:58:33 +03:00
Cameron Cawley
d79f1eb55e ENGINES: Remove getExtraGuiOptions from MetaEngine 2021-08-14 13:57:54 +02:00
Eugene Sandulenko
0fcb6aa3e5
METAENGINE: Add optional offset parameter for extended saves 2021-07-16 01:18:56 +02:00
a/
17b2c657ae ENGINES: METAENGINE: Add method to append extended save header to stream 2021-07-16 05:43:27 +09:00
Martin Gerhardy
dfd6b6a9a4 COMMON: moved AchievementDescriptionList into Common namespace
getAchievementsInfo is also moved into the MetaEngine to reduce code duplication
2021-06-16 00:25:14 +03:00
ysj1173886760
859d9acef3 ENGINE: add doxygen comments fo DebugChannelDef and getDebugChannels 2021-05-22 01:34:57 +02:00
ysj1173886760
5feac6bdff BASE: add list-all-debugflags and list-debugflags to commandLine 2021-05-22 01:34:57 +02:00
ysj1173886760
96aa98ed14 ENGINE: change the name of the delimiter of DebugChannelDef 2021-05-22 01:34:57 +02:00
ysj1173886760
dde0961225 ENGINE: return the pointer of array instead of a array of getDebugChannels in metaengine 2021-05-22 01:34:57 +02:00
ysj1173886760
9d149b7988 ENGINE: add method getDebugChannelOptions for metaegine detection 2021-05-22 01:34:57 +02:00
a/
bad9008a89 DETECTOR: Modify getFileProperties to cache md5 results 2021-05-14 22:35:23 +02:00
a/
45aa165b80 Modify getFileProperties to cache md5 results 2021-05-14 22:35:23 +02:00
Orgad Shaneh
a05e54f00c JANITORIAL: Remove trailing whitespaces 2021-05-04 11:46:30 +03:00
Paul Gilbert
ae4da8bce0 ENGINES: Make creation of savegame thumbnails an overrideable method 2021-03-07 09:34:33 -08:00
Thierry Crozat
67720ef658 JANITORIAL: Remove obselete references to MetaEngineConnect
At some point when splitting the MetaEngine to a detection
plugin and a static meta engine, the former was called
MetaEngine while the latter was called MetaEngineConnect.
Thus was then later change to MetaEngineDetection and
MetaEngine. But some references were left to the former
names in comments and documentation.
2021-02-14 14:32:36 +00:00
Bartosz Gentkowski
f04056519a DOXYGEN: Review of high prio headers from engines
This is a doxygen review for 4 header files that have been
identified as high priority for GSoD:

- advancedDetector.h
- metaengine.h
- engine.h
- util.h

It also adds doxy groups to other headers from this folder to
make them appear properly in the structure.
2020-12-02 00:13:49 +00:00