We used to use a bitfield there, which was restricting the total
number of flags to 32 (unless we switch to uint64, which is suboptimal).
Moreover, with the introduction of the global debug flags, we have
even fewer bits to flip, and this shared nature was restricting
the introduction of more global debug channels.
The goal for the bitfield was to make it possible to put a debug message into
more than one channel. But this feature was practically not used by the engines.
This was removed by the previous commits.
This commit turns the debug channels into a hashmap and puts the global channel
IDs after 100000.
There is no absolute need to renumber the existing debug channels, but
I could follow with an engine or two.
Make the backend options widget be of type ScrollContainerWidget.
This will allow backends to decide whether the options dialogue
should be scrollable or not.
Note, this changes the default padding. If not changing the padding
the scrollbar might disappear. Update the padding in each backend
instead.
There were two main issues:
1. The intermediate surface on which the rich text is drawn was not
resized when the widget was resized. This resulted in text being
cut.
2. The Graphics::MacText does not properly handle width changes,
Resize is not handled at all if there is a table, but even when
there is no table it can have issues with the font.
As a workaround it is now recreated instead of being resized.
No specific layout was defined for the rich text widget. It tried
to use the layout of the tab widget, but that did not work properly.
The rich text widget was at the correct location, but did not have
the correct size. It was bigger than the parent tab widget, which
can be clearly seen when the scrollbar is visible.
This updates the FluidSynth settings to the value ranges and defaults used by
the current version 2.3.4.
Reverb
- Room size: 0.00-1.20 / 0.20 to 0.00-1.00 / 0.20
- Width: 0-100 / 1 to 0.0-100.0 / 0.5
Chorus
- Level: 0.00-1.00 / 1.00 to 0.00 - 10.00 / 2.00
- Speed: 0.30-5.00 / 0.30 to 0.10-5.00 / 0.30
- Depth: 0.0-21.0 / 8.0 to 0.0-256.0 / 8.0
Fixes Console output in debug (stdout/scummvm.log) when lines
are built with multiple calls to ConsoleDialog::debugPrintf.
See: a7d4d0f232231eb3d22c85d35ddfbcc2be0e587c