Commit Graph

9309 Commits

Author SHA1 Message Date
Matthew Jimenez
5219c99400 GRAPHICS: Move PaletteManager definition to a separate header 2024-03-12 12:24:00 +02:00
sluicebox
d80e830156 SCI: Fix SQ5 message talker when looking at Cliffy
Thanks to @CommanderProton for finding this!
2024-02-17 20:47:42 -05:00
sluicebox
5a12df7b4b SCI32: Fix LIGHTHOUSE uninit variable read on VMD playback
Fixes bug #14924
2024-02-05 22:33:26 -08:00
sluicebox
32fa3679ea SCI: Reduce g_system use 2024-01-30 13:22:44 -08:00
Иван Марчуков
97dae516e2 SCI: Fix after code review 2024-01-22 08:50:52 +02:00
Marchukov Ivan
a1171dce97 SCI: Apply suggestions from code review
Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
2024-01-22 08:50:52 +02:00
Иван Марчуков
3f1c050cbe SCI: More information. Moved vocab parse into separate function 2024-01-22 08:50:52 +02:00
Иван Марчуков
7fad58be1d SCI: Add detection table entries for russian translate of
Conquests of Camelot, Laura Bow and Police Quest 2
2024-01-22 08:50:52 +02:00
Иван Марчуков
073469293f SCI: Add cyrillic input support for text-based games 2024-01-22 08:50:52 +02:00
sluicebox
f5aec9593b SCI: Fix HOYLE4 unexpected discard in Euchre
Fixes bug #14874

Thanks to @Karunamon for reporting this
2024-01-19 15:32:54 -07:00
Cameron Cawley
01e7071315 SCI: Use OSystem::fillScreen() where possible 2024-01-07 11:09:34 +02:00
sluicebox
d2efce1c64 SCI: Fix LSL5 TPrint script patch
The patch altered the frame size of a call instruction, but I failed
to update the matching argument count on the stack.

This caused Print to receive an incorrect argc and crash the
gymnastics scene in room 920.

See: 4a40ac92ea3d7d6efe76583b91b2769463c8f8db

Fixes bug #14791

Thanks to @EricTSten for reporting this
2024-01-02 00:17:23 -08:00
Cameron Cawley
30b977c272 DETECTION: Mark more symbols as const 2023-12-26 20:23:59 +01:00
Le Philousophe
45286ad131 SCI: Migrate engine to Path 2023-12-24 13:19:25 +01:00
Le Philousophe
93a8f7f4d6 COMMON: Move Archive API to Path 2023-12-24 13:19:25 +01:00
sluicebox
a26252fadf SCI: Fix PQ3 wrong ending 2023-12-21 13:19:42 -08:00
Walter Agazzi
237e6231dd SCI: Also show qfg2-agdi characters in import
This allows importing characters created by the AGDI remake of QFG2 with no
need to rename.
Fixes TRAC #14754
2023-12-16 15:55:24 +02:00
sluicebox
9a9a13605f SCI: Fix SQ1VGA buckazoid inventory crash
Big thank you to @codengine for discovering this script bug, performing
the script analysis, and developing the initial script patch.
2023-12-14 16:26:00 -08:00
sluicebox
6ee2a62779 SCI: Fix BRAIN2 art puzzle lockup
Fixes bug #14543
2023-12-12 21:55:06 -08:00
sluicebox
b7522b2bb9 SCI: Fix BRAIN2 crash in robot maze
Fixes bug #14556

Thanks to @eriktorbjorn for finding this
2023-12-12 12:05:19 -08:00
sluicebox
e5b9c7c010 SCI: Cleanup GfxView 2023-12-09 21:47:56 -08:00
Eugene Sandulenko
ec2dd2726b ENGINES: Added optional parameter to canSave/LoadGameStateCurrently() for indicating the reason 2023-12-08 12:21:16 +01:00
sluicebox
62a5b6dc95 SCI: Refactor away SciEngine::exitGame 2023-11-21 22:02:54 -08:00
sluicebox
8dac2204cd SCI: Clean up SegManager
Fewer casts, pointers, and parameters
2023-11-21 22:02:54 -08:00
sluicebox
2bbf060740 SCI32: Update "Inside the Chest" description 2023-11-21 22:02:53 -08:00
sluicebox
f2d0b0b33a SCI: Prevent potential stack overflow in errorString 2023-11-21 22:02:53 -08:00
sluicebox
ff779d72dd SCI: Limit SCI0Early MT32.DRV parsing to expected versions
Fixes erroring when initializing a non-MT32 game like Rama when
MT32 is set as the preferred device.

Fixes bug #13946
2023-11-19 20:07:18 -08:00
sluicebox
5dbffb3402 SCI: Remove redundant test from run_vm
The same code occurs a few lines earlier
2023-11-17 15:59:08 -08:00
sluicebox
49a2fac05e SCI: Reduce global engine usage 2023-11-16 18:44:42 -08:00
sluicebox
0d60cfafcc SCI: Remove script_abort_flag Console command
script_abort_flag is an unsafe and redundant command.
We already have safe versions: quit and restart_game.
2023-11-15 16:46:38 -08:00
sluicebox
d18b63bee4 SCI: Remove completed TODO
We have a console command to list classes: class_table
2023-11-15 14:32:27 -08:00
sluicebox
c6bf55f1fc SCI: Update header guards 2023-11-14 16:40:53 -08:00
sluicebox
44436a91f2 SCI: Remove SciCallOrigin from error messages
`errorString` now adds this context (and more) to `error` messages
2023-11-14 16:06:45 -08:00
sluicebox
d15e95009a SCI: Update comments in sci.h 2023-11-14 15:38:06 -08:00
sluicebox
e491dd4e81 SCI: Replace fan-made patch message box with warning
We no longer need an unskippable message box about fan-made patches.

We really just want to know if a fan-made patch is present when
diagnosing a bug report, just in case that's part of the problem.
This lets us re-enable detection of the patches that GOG includes
in their releases.
2023-11-14 15:38:05 -08:00
sluicebox
c59521f979 SCI32: Fix PHANT1 crash when leaving Harriet in the barn
Thanks to speedrunner @hitmarty for discovering this.

Thanks to @deckarep for the recent `errorString` feature that
helped diagnose this script bug from a screenshot.
2023-11-13 12:59:36 -08:00
sluicebox
3e339b0097 SCI: Update errorString
- Fixes stack overflow when `error` is called from kernel function
- Includes most recent pc when `error` is called from kernel function
- Handles script procedures in addition to object methods
- Uses target name to identify game to log variant/fallback info
- Condenses errorString to a single-line header
2023-11-09 14:50:58 -08:00
sluicebox
cfa1ad6de2 SCI: Fix errorString version query 2023-11-08 01:09:59 -07:00
sluicebox
cb233df64d SCI: Fix errorString when execution stack isn't initialized 2023-11-07 20:47:31 -07:00
sluicebox
5cc1ac3a98 SCI: Initialize EngineState::_segMan
Destructor deletes a potentially uninitialized pointer
2023-11-07 20:47:30 -07:00
sluicebox
26ba48aba7 SCI: Make parameter const ref 2023-11-07 16:07:10 -08:00
sluicebox
d0f0287e15 SCI: Remove double assignments in debugger. PVS-Studio V1048 2023-11-07 16:07:10 -08:00
sluicebox
bf0e734377 SCI: Add getCurrentCallOrigin error check
Coverity CID 1363393
2023-11-07 16:07:10 -08:00
sluicebox
a54b882502 SCI: Clarify text-code processing. PVS-Studio V560 2023-11-07 16:07:10 -08:00
sluicebox
9dc86697f0 SCI32: Clarify logging function. PVS-Studio V547 2023-11-07 16:07:10 -08:00
Filippos Karapetis
e9e88003dc SCI: Add sanity checks to SciEngine::errorString()
It would crash in errors thrown during resource loading
2023-11-05 11:44:36 +02:00
sluicebox
b85d24a83a SCI: Clarify operator precedence in getAudioStream 2023-11-03 20:54:41 -07:00
sluicebox
e397f36be2 SCI: Remove redundant checks 2023-11-03 20:53:50 -07:00
sluicebox
7da3c93c14 SCI: Remove unused variable from kDoBresen 2023-11-03 15:12:42 -07:00
sluicebox
1f4124b121 SCI: Remove or disable unused functions 2023-11-03 15:12:41 -07:00