Commit Graph

4239 Commits

Author SHA1 Message Date
Donovan Watteau
a46253647a COMMON: BUILD: Try detecting UBSan when not using configure
Newer versions of Clang can tell us when UBSan has been enabled, which
is useful to define SCUMM_NEED_ALIGNMENT when -fsanitize=alignment is
in use (https://reviews.llvm.org/D52386).

Can be useful to avoid some false positives about alignment when doing
a build with UBSan but without using the "configure" script which
already tries to detect this setting.

See earlier commit 8a73f5d496.
2023-06-21 12:56:58 +02:00
elasota
eda8c2698f COMMON: Fix incorrect StuffIt directory paths 2023-06-21 08:26:28 +03:00
elasota
b9175e1810 COMMON: Fix up comments 2023-06-19 21:59:24 +03:00
elasota
8cb45fe696 COMMON: Update comment to explain buggy normalization behavior more clearly 2023-06-19 21:59:24 +03:00
elasota
8ce2ffd68b COMMON: Move Gentee Installer from V-Cruise to Common 2023-06-19 21:59:24 +03:00
elasota
654f7fd8d0 COMMON: Add comments on usage 2023-06-19 08:45:32 +03:00
elasota
907252ecbd COMMON: Return correct path separator for InstallShieldV3 2023-06-19 08:45:32 +03:00
elasota
e53d2ec594 COMMON: Add "getPathSeparator" to Archive and return ":" for Mac archive formats 2023-06-19 08:45:32 +03:00
elasota
7be3c8f602 COMMON: Add "flattenTree" param to createStuffItArchive and preserve directory structure by default 2023-06-19 08:45:32 +03:00
Misty De Meo
e05e33a06e
COMMON: remove unused variable assignment 2023-06-17 10:08:24 -07:00
Harishankar Kumar
7d8dcebeb7
COMMON: Fix memory leak when invalid PE executable is loaded
In function `PEResources::loadFromEXE`, there were memory leaks
because of not properly handling with streams, and thus when the
loaded movie was bad/non-exe file, the memory was not freed.

This was undetected in normal exe loading because there the streams
were being assigned and closed properly.
2023-06-14 13:57:50 +02:00
Paul Gilbert
eb80a2119b COMMON: Fix string method comments in forbidden.h 2023-06-12 19:14:09 -07:00
Scott Percival
d69dac6016 COMMON: Fix file handle leak in generateZipSet() 2023-06-08 09:16:30 +02:00
Misty De Meo
90c4b57e9a
COMMON: punycode: move npos guard up
b0d722473b introduced code that used
ni before this guard that ensures it has a proper value for strings
that contain no ASCII component.
2023-06-07 14:55:41 -07:00
Misty De Meo
fb5982eacb
COMMON: do not process the tail if there is no tail
If the illegal character scanner flags the final character, it
shouldn't continue on try to process the tail - it's the end of the
string, and indexing past that is invalid.
2023-06-07 11:58:05 -07:00
Eugene Sandulenko
bc6b225eed
COMMON: Include <limits> by default
We discussed it in https://github.com/scummvm/scummvm/pull/3966, so
std::numeric_limits is OK to use in the ScummVM codebase.
2023-06-05 17:17:19 +02:00
grisenti
7698d18a9b COMMON: Fix StableMap API to conform to std::map 2023-06-03 23:23:09 +02:00
grisenti
b8f7e9416b COMMON: Remove unused method in Common::RBTree 2023-06-03 23:11:03 +02:00
grisenti
09db135b3a COMMON: Fix documentation for Common::RBTree 2023-06-03 23:09:19 +02:00
grisenti
40d305c92b COMMON: Improve documentation for Common::StableMap 2023-06-03 23:08:18 +02:00
grisenti
deb22d6bc1 COMMON: Improve documentation for Common::RBTree 2023-06-03 22:39:10 +02:00
grisenti
88062119f9 COMMON: Fix documentation for lower/upperBound 2023-06-01 23:18:12 +02:00
grisenti
9380f2f7da COMMON: Improve documentation for lower/upperBound 2023-06-01 19:10:59 +02:00
grisenti
4248f351f3 COMMON: add upperBound and lowerBound to algorithm 2023-06-01 18:28:01 +02:00
hax0kartik
b8f6af8dfe COMMON: Update documentation for Common::remove() 2023-06-01 16:32:03 +02:00
hax0kartik
698bb261d1 COMMON: Add remove() to algorithm 2023-06-01 16:32:03 +02:00
hax0kartik
9be3246a3e COMMON: Fix operator[] of StableMap 2023-05-31 08:09:14 +02:00
grisenti
2c2cc1720b COMMON: Add std::map and std::multimap replacements
moved from hpl1/std
2023-05-30 19:14:04 +02:00
elasota
6823514318 COMMON: Add Bulgarian language code 2023-05-29 23:50:15 +02:00
elasota
0e99ed1ad1 COMMON: Add Rect constructor that accepts a top-left coordinate, width, and height 2023-05-27 11:10:18 +03:00
elasota
bf087e4ad3 COMMON: Add Rect constructor that accepts top-left and bottom-right coordinates as points 2023-05-27 11:10:18 +03:00
Vladimir Serbinenko
9874d200c8 COMMON: Fix logic error in macresman 2023-05-20 14:32:53 +02:00
elasota
3adb30e4bf COMMON: Avoid makeUnique on string if trim wouldn't modify it. 2023-05-14 23:07:32 +02:00
elasota
ee758dee53 BACKENDS: Undo some formatting-only changes. 2023-05-14 22:42:59 +02:00
elasota
6c8ceeae25 BACKENDS: Refactor some things to make getDoubleClickTime behavior with event recorder simpler. 2023-05-14 22:42:59 +02:00
elasota
74ddbe5eaa BACKENDS: Add double-click time feature to support OS-configurable double-click intervals, implement it for Windows. 2023-05-14 22:42:59 +02:00
Vladimir Serbinenko
31b150d7a0 COMMON: Make BitArray::get const 2023-05-14 20:32:38 +02:00
elasota
e219e4e04e COMMON: Strip whitespace before checking if an INI line is a comment.
Fixes some versions of Reah failing to parse subtitle data.
2023-05-11 00:22:14 +03:00
Vladimir Serbinenko
088b14a83a COMMON: Add function to open data fork from macbinary stream 2023-05-10 22:44:04 +02:00
Vladimir Serbinenko
f9b6669241 COMMON: Add DBCS-oriented variant of String 2023-05-10 13:18:54 +02:00
Einar Johan Trøan Sømåen
c1eedd42c5 COMMON: Make the Common::String()/U32String() constructor constexpr
This lets us have constexpr structs/classes that contain Common::String
2023-04-29 13:10:23 +02:00
Einar Johan Trøan Sømåen
6057d12816 COMMON: Make the Common::Rect() / Common::Point() constructor constexpr
This lets us have constexpr structs/classes that contain Rect / Point
2023-04-29 13:10:23 +02:00
Einar Johan Trøan Sømåen
f5491c9e65 COMMON: Make the Common::List() constructor constexpr
This lets us have constexpr structs/classes that contain Common::List
2023-04-29 13:10:23 +02:00
Einar Johan Trøan Sømåen
5b1239eb93 COMMON: Make the Common::Array() constructor constexpr
This lets us have constexpr structs/classes that contain Common::Array
2023-04-29 13:10:23 +02:00
Eugene Sandulenko
7c59a77aca
COMMON: Added string splitter to StringTokenizer class 2023-04-23 16:20:37 +02:00
Kaloyan Chehlarski
d99d325747 COMMON: Detect obfuscated and invalid files in InstallShield cabs
Files marked as invalid are now ignored in all IS versions. Trying to
extract an obfuscated file now results in a warning instead of just failing.
2023-04-09 13:02:30 +02:00
Kaloyan Chehlarski
ba11cf87cd COMMON: Fix incorrectly marked split files in InstallShield cabinets 2023-04-09 13:02:30 +02:00
Kaloyan Chehlarski
6efa793a25 COMMON: Fix InstallShield v5 file list reading
Fixed the InstallShield archive code to correctly load the file list in
multi-cabinet v5 archives.
2023-04-09 13:02:30 +02:00
Kaloyan Chehlarski
9fb08caa4e COMMON: Upgrade InstallShield archive code
Added support for files split across volumes, and for multi-volume
v5 archives to the InstallShield cabfile code.
2023-04-09 13:02:30 +02:00
Alexander Tkachov
cc38b31ae7 CLOUD: Janitorial
- rename JSON::getPreparedContents() to JSON::untaintContents();
- minor changes to ConnectCloudClientHandler and CloudConnectionWizard.
2023-04-08 16:20:11 +02:00