The particular scene with Indy and Donovan's men had all sorts of pathfinding issues compared to DOSBox:
- Indy's initial facing was downwards instead of to the right when walking from the window to the "meeting point" and the path he walked wasn't exactly correct.
- One of Donovan's men was facing down instead of left.
- Indy would take several weird up and down walks at the walk box transition from box 1 to box 3
- Indy would walk over the grass instead of on the road.
All fixes are from disasm. Some code I have removed (or rather commented out) seems to have been meant as a fix for bug no. 1778. So maybe that one has to be fixed again (correctly), but I don't know that yet.
The scene is not 100% fixed yet. Donovan's men walk a bit too much upwards in the beginning. But I can do that separately...
It will really be necessary to do some testing (and possibly more fixing) in the catacombs, in castle brunwald and in the zeppelin maze.
Adds 5 new gameIDs and 16 new md5 entries.
This commit includes:
* 2 English digital magazines
* 1 French digital magazine
* 1 English covermount
* 1 Finnish covermount
* 1 Russian covermount
Adds 27 new gameIDs and 54 new md5 entries.
This commit includes:
* 10 new games
* 10 new demos
* 5 screen savers
* 4 desktop clocks
* 1 multimedia CD
* 2 games on new platforms
* 1 localization
* 1 unsupported demo
This is a remnant of adding these before UTF-8 encoding was available
for game descriptions. Some games had translated titles written in
Latin script. Many of these were fixed in PR #3049 before they had
been merged to master. This commit reverts the remainder to Japanese
script with romaji titles in comments where needed.
Adds 14 new gameIDs and 16 new md5 entries.
This commit covers products without an English language release.
Please note that this does not necessarily indicate the country of
origin. Game descriptions for various languages are added here based
on the developers' language, whether or not we posess a copy in that
language.
This commit includes:
* 2 Danish games (+1 screen saver)
* 2 French games
* 3 Italian games
* 2 Spanish multimedia CDs
* 3 Russian demos
* 1 Brazilian catalog
Also known as ECD, CD+, CD+Extra, Blue Book standard
Adds 17 new gameIDs and 71 new md5 entries.
This commit includes:
* 10 CDs with Director content
* 1 box set (16 of 22 discs)
* 4 bonus standalone apps
* 1 screen saver
* 1 product demo
Adds 21 new gameIDs and 33 new md5 entries.
This commit includes:
* 6 new multimedia CD-ROMs
* 3 bonus features
* 3 new demos
* 6 new screen savers
* 2 electronic press kits
* 1 shareware game
Adds 8 new gameIDs and 15 new md5 entries.
This commit covers games with an English language release. Please note
that this does not necessarily mean an English entry has been added to
detection. Games for various languages are added here if an English
version exists, whether or not we possess a copy of the English version
The filename `demo` was used to detect the Operation Stealth Amiga
demo. This would often produce false matches when the same filename
was present in data files for other engines, especially Mac Director.
We can use the filename `demo_os` instead. This is the file used for
the DOS demo (with a different md5).
DefaultSaveFileManager::loadTimestamps() was parsing strings from the
timestamps file by checking for end-of-stream after using the byte it
attempted to read. This worked because ReadStream::readByte() returns 0
on error, but that's undefined behavior with a FIXME to remove.
This bug was exposed by the recently added warning when 0 is appended
to a String: ab06f27d43
This is not the best solution as it removes the warning when this
code is used by devtools such as create_titanic, but getting this to
link would need inclusion of textconsole.o via shim and then still
breaks on g_system, so fastest solution to restore build.
While it's not needed to build ScummVM, apparently some of the other
tools that use String do not include textconsole.h and complain that
warning() is undefined.
Some engines do this, and it's not really known what should happen. We
need to decide on a behavior, and stick to that. This warning is to help
find where it happens.
From my own tests, it can happen in at least ADL, Avalanche, Chewy,
Director, Blazing Dragons, MacVenture, MADS, Prince, Stark, Startrek,
and Trecision. Only ADL is known to be broken by the current behavior.
The result of my test can be found at
http://www.update.uu.se/~d91tan/tmp/string.txt
