scummvm/engines/bladerunner/audio_mixer.cpp
antoniou79 1a25c2b69a BLADERUNNER: Remove timerprocs for next track and fadeout
The timers are replaced with "application" timers, which are checked in AudioMixer::tick()

The timerprocs for next and fadeout could potentially cause a game freeze.
This is because they could, under certain race conditions, come to a deadend
while trying to lock the mutexes for access to AudioMixer and Music methods.
The particular use case (non-deterministic) for this was loading a save game
while playing a game that had a music track playing (eg. at MA05, McCoy's balcony).
Here's a rough explanation of a possible lock situation (others could also be possible)
The "Main Thread" and "SDLTimer" threads (as reported from MSVC debug) could become hardlocked.
::Main Thread::
	A. LoadGame() calls _music->stop(0u);
		A1. Locks a Music::_mutex
		A2. Calls vm->_audioMixer->stop()
		A3. AudioMixer::stop() locks AudioMixer::_mutex [THIS DONE]
		A4. calls the endCallback for the music which is Music::ended()
			at Music::ended,
			A41. lock a Music::_mutex (presumably this is ok, even though it's a second lock, because it's the same thread(?))
			A42. call installTimerProc()
				A421. which tries to lock DefaultTimerManager::_mutex from default-timer [THIS FREEZES] - conflict with B11
::SDLTimer::
	B. calls timer_handler,
		B1. calls DefaultTimerManager::handler()
			B11. locks the DefaultTimerManager::_mutex from default-timer [THIS IS DONE]
			B12. we try to service the callbacks from TimerProcs that are currently entered in the TimerSlots queue
				B121. Such a slot is the AudioMixer BladeRunnerAudioMixerTimer, which has the AudioMixer::timerCallback()
				B1211. which calls the at AudioMixer::tick().
						tick() tries to lock the AudioMixer::_mutex [THIS FREEZES] conflict with A3
2021-06-12 14:58:07 +03:00

283 lines
9.8 KiB
C++

/* ScummVM - Graphic Adventure Engine
*
* ScummVM is the legal property of its developers, whose names
* are too numerous to list here. Please refer to the COPYRIGHT
* file distributed with this source distribution.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
*/
#include "bladerunner/audio_mixer.h"
#include "bladerunner/bladerunner.h"
#include "bladerunner/music.h"
#include "bladerunner/time.h"
#include "audio/audiostream.h"
#include "audio/mixer.h"
#include "common/timer.h"
namespace BladeRunner {
AudioMixer::AudioMixer(BladeRunnerEngine *vm) {
_vm = vm;
for (int i = 0; i < kChannels; ++i) {
_channels[i].isPresent = false;
}
#if !BLADERUNNER_ORIGINAL_BUGS
for (int i = 0; i < kAudioMixerAppTimersNum; ++i) {
_audioMixerAppTimers[i].started = false;
_audioMixerAppTimers[i].lastFired = 0u;
_audioMixerAppTimers[i].intervalMillis = 0u;
}
#endif // BLADERUNNER_ORIGINAL_BUGS
_vm->getTimerManager()->installTimerProc(timerCallback, (1000 / kUpdatesPerSecond) * 1000, this, "BladeRunnerAudioMixerTimer");
}
AudioMixer::~AudioMixer() {
for (int i = 0; i < kChannels; ++i) {
stop(i, 0u);
}
_vm->getTimerManager()->removeTimerProc(timerCallback);
}
int AudioMixer::play(Audio::Mixer::SoundType type, Audio::RewindableAudioStream *stream, int priority, bool loop, int volume, int pan, void (*endCallback)(int, void *), void *callbackData, uint32 trackDurationMs) {
Common::StackLock lock(_mutex);
int channel = -1;
int lowestPriority = 1000000;
int lowestPriorityChannel = -1;
for (int i = 0; i < kUsableChannels; ++i) {
if (!_channels[i].isPresent) {
channel = i;
break;
}
if (_channels[i].priority < lowestPriority) {
lowestPriority = _channels[i].priority;
lowestPriorityChannel = i;
}
}
if (channel == -1) {
if (priority < lowestPriority) {
//debug("No available audio channel found - giving up");
return -1;
}
//debug("Stopping lowest priority channel %d with lower prio %d!", lowestPriorityChannel, lowestPriority);
stop(lowestPriorityChannel, 0u);
channel = lowestPriorityChannel;
}
return playInChannel(channel, type, stream, priority, loop, volume, pan, endCallback, callbackData, trackDurationMs);
}
int AudioMixer::playMusic(Audio::RewindableAudioStream *stream, int volume, void(*endCallback)(int, void *), void *callbackData, uint32 trackDurationMs) {
Common::StackLock lock(_mutex);
return playInChannel(kMusicChannel, Audio::Mixer::kMusicSoundType, stream, 100, false, volume, 0, endCallback, callbackData, trackDurationMs);
}
// Note: time tends to be the requested time in seconds multiplied by 60u
void AudioMixer::stop(int channel, uint32 time) {
Common::StackLock lock(_mutex);
if (_channels[channel].isPresent) {
if (time) {
adjustVolume(channel, 0, time);
} else {
_channels[channel].isPresent = false;
if (_channels[channel].sentToMixer) {
_vm->_mixer->stopHandle(_channels[channel].handle);
}
if (_channels[channel].endCallback != nullptr) {
_channels[channel].endCallback(channel, _channels[channel].callbackData);
}
}
}
}
int AudioMixer::playInChannel(int channel, Audio::Mixer::SoundType type, Audio::RewindableAudioStream *stream, int priority, bool loop, int volume, int pan, void(*endCallback)(int, void *), void *callbackData, uint32 trackDurationMs) {
_channels[channel].isPresent = true;
_channels[channel].stream = stream;
_channels[channel].priority = priority;
_channels[channel].loop = loop;
_channels[channel].volume = volume;
_channels[channel].volumeTarget = 0;
_channels[channel].volumeDelta = 0;
_channels[channel].pan = pan;
_channels[channel].panTarget = 0;
_channels[channel].panDelta = 0;
_channels[channel].endCallback = endCallback;
_channels[channel].callbackData = callbackData;
_channels[channel].timeStarted = _vm->_time->currentSystem();
_channels[channel].trackDurationMs = trackDurationMs;
Audio::AudioStream *audioStream = stream;
if (loop) {
audioStream = new Audio::LoopingAudioStream(stream, 0, DisposeAfterUse::YES);
}
if (!_vm->_mixer->isReady()) {
_channels[channel].sentToMixer = false;
return channel;
}
_channels[channel].sentToMixer = true;
_vm->_mixer->playStream(
type,
&_channels[channel].handle,
audioStream,
-1,
volume * 255 / 100,
pan * 127 / 100);
return channel;
}
bool AudioMixer::isActive(int channel) const {
Common::StackLock lock(_mutex);
return _channels[channel].isPresent
&& ((_channels[channel].sentToMixer && _vm->_mixer->isSoundHandleActive(_channels[channel].handle))
|| (!_channels[channel].sentToMixer && !_channels[channel].loop && (_vm->_time->currentSystem() - _channels[channel].timeStarted < _channels[channel].trackDurationMs)));
}
void AudioMixer::timerCallback(void *self) {
((AudioMixer *)self)->tick();
}
// Note: time tends to be the requested time in seconds multiplied by 60u
void AudioMixer::adjustVolume(int channel, int newVolume, uint32 time) {
Common::StackLock lock(_mutex);
if (_channels[channel].isPresent) {
_channels[channel].volumeTarget = newVolume;
_channels[channel].volumeDelta = ((newVolume - _channels[channel].volume) / (time / 60.0f)) / (float)kUpdatesPerSecond;
}
}
// Note: time tends to be the requested time in seconds multiplied by 60u
void AudioMixer::adjustPan(int channel, int newPan, uint32 time) {
Common::StackLock lock(_mutex);
if (_channels[channel].isPresent) {
newPan = CLIP(newPan, -100, 100);
_channels[channel].panTarget = newPan;
_channels[channel].panDelta = ((newPan - _channels[channel].pan) / (time / 60.0f)) / (float)kUpdatesPerSecond;
}
}
void AudioMixer::tick() {
Common::StackLock lock(_mutex);
for (int i = 0; i < kChannels; ++i) {
Channel *channel = &_channels[i];
if (!channel->isPresent) {
continue;
}
if (channel->volumeDelta != 0.0f) {
// apply volumeDelta to volume (common use for adjustVolume or stop playing - ie mainly for fadeIn, fadeOut)
channel->volume = CLIP(channel->volume + channel->volumeDelta, 0.0f, 100.0f);
if ((channel->volumeDelta < 0 && channel->volume <= channel->volumeTarget)
|| (channel->volumeDelta > 0 && channel->volume >= channel->volumeTarget)) {
channel->volumeDelta = 0.0f;
}
if (channel->sentToMixer) {
_vm->_mixer->setChannelVolume(channel->handle, (channel->volume * Audio::Mixer::kMaxChannelVolume) / 100); // map [0..100] to [0..kMaxChannelVolume]
}
if (channel->volume <= 0.0f) {
stop(i, 0u);
}
}
if (channel->panDelta != 0.0) {
// apply panDelta to pan (common use for adjusting pan)
channel->pan = CLIP(channel->pan + channel->panDelta, -100.0f, 100.0f);
if ((channel->panDelta < 0 && channel->pan <= channel->panTarget) || (channel->panDelta > 0 && channel->pan >= channel->panTarget)) {
channel->panDelta = 0.0f;
}
if (channel->sentToMixer) {
_vm->_mixer->setChannelBalance(channel->handle, (channel->pan * 127) / 100); // map [-100..100] to [-127..127]
}
}
if ((channel->sentToMixer && !_vm->_mixer->isSoundHandleActive(channel->handle))
|| channel->stream->endOfStream()
|| (!channel->sentToMixer && !channel->loop && _vm->_time->currentSystem() - channel->timeStarted >= channel->trackDurationMs)
) {
stop(i, 0u);
}
}
#if !BLADERUNNER_ORIGINAL_BUGS
// piggyback the realtime triggered tick() actions, with a check for the virtual timers (app timers)
for (int i = 0; i < kAudioMixerAppTimersNum; ++i) {
if (_audioMixerAppTimers[i].started
&& _vm->_time->currentSystem() - _audioMixerAppTimers[i].lastFired > _audioMixerAppTimers[i].intervalMillis) {
// We actually need to have the _vm->_time->currentSystem() check in the if clause
// and not use a var that stores the current time before we enter the loop
// because the functions for these timers may affect the lastFired, by setting it to the a current system time
// and then lastFired would have been greater than our stored system time here.
_audioMixerAppTimers[i].lastFired = _vm->_time->currentSystem();
switch (i) {
case kAudioMixerAppTimerMusicNext:
_vm->_music->next();
break;
case kAudioMixerAppTimerMusicFadeOut:
_vm->_music->fadeOut();
break;
default:
// error - but probably won't happen
error("Unknown Audio Mixer App Timer Id");
break;
}
}
}
#endif // !BLADERUNNER_ORIGINAL_BUGS
}
#if !BLADERUNNER_ORIGINAL_BUGS
void AudioMixer::startAppTimerProc(int audioMixAppTimerId, uint32 intervalMillis) {
// Attempt to lock the mutex, since we reach here from another thread (main thread)
Common::StackLock lock(_mutex);
if (audioMixAppTimerId < 0 || audioMixAppTimerId >= kAudioMixerAppTimersNum) {
return;
}
_audioMixerAppTimers[audioMixAppTimerId].started = true;
_audioMixerAppTimers[audioMixAppTimerId].intervalMillis = intervalMillis;
_audioMixerAppTimers[audioMixAppTimerId].lastFired = _vm->_time->currentSystem();
}
void AudioMixer::stopAppTimerProc(int audioMixAppTimerId) {
// Attempt to lock the mutex, since we reach here from another thread (main thread)
Common::StackLock lock(_mutex);
if (audioMixAppTimerId < 0 || audioMixAppTimerId >= kAudioMixerAppTimersNum) {
return;
}
_audioMixerAppTimers[audioMixAppTimerId].started = false;
}
#endif // !BLADERUNNER_ORIGINAL_BUGS
} // End of namespace BladeRunner