scummvm/test/common/array.h
Max Horn 94dfc8f638 Fixed a bug in Common::Array (including a unit test for it), and changed the way the internal storage growth over time.
The bug could result in incorrect results when using push_back (or insert_at)
to insert data from an array into itself if this insertions would cause the
internal array storage to grow. Also added a unit test for this bug.

Furthermore, if the internal storage needs to grow, it will now be resized to the next power of two,
instead of being increased by 32.

svn-id: r40907
2009-05-26 11:28:38 +00:00

235 lines
5.0 KiB
C++

#include <cxxtest/TestSuite.h>
#include "common/array.h"
#include "common/str.h"
class ArrayTestSuite : public CxxTest::TestSuite
{
public:
void test_empty_clear() {
Common::Array<int> array;
TS_ASSERT(array.empty());
array.push_back(17);
array.push_back(33);
TS_ASSERT(!array.empty());
array.clear();
TS_ASSERT(array.empty());
}
void test_iterator() {
Common::Array<int> array;
Common::Array<int>::iterator iter;
// Fill the array with some random data
array.push_back(17);
array.push_back(33);
array.push_back(-11);
// Iterate over the array and verify that we encounter the elements in
// the order we expect them to be.
iter = array.begin();
TS_ASSERT_EQUALS(*iter, 17);
++iter;
TS_ASSERT_DIFFERS(iter, array.end());
TS_ASSERT_EQUALS(*iter, 33);
++iter;
TS_ASSERT_DIFFERS(iter, array.end());
// Also test the postinc
TS_ASSERT_EQUALS(*iter, -11);
iter++;
TS_ASSERT_EQUALS(iter, array.end());
}
void test_direct_access() {
Common::Array<int> array;
// Fill the array with some random data
array.push_back(17);
array.push_back(33);
array.push_back(-11);
TS_ASSERT_EQUALS(array[0], 17);
TS_ASSERT_EQUALS(array[1], 33);
TS_ASSERT_EQUALS(array[2], -11);
}
void test_insert_at() {
Common::Array<int> array;
// First of all some data
array.push_back(-12);
array.push_back(17);
array.push_back(25);
array.push_back(-11);
// Insert some data
array.insert_at(2, 33);
TS_ASSERT_EQUALS(array[0], -12);
TS_ASSERT_EQUALS(array[1], 17);
TS_ASSERT_EQUALS(array[2], 33);
TS_ASSERT_EQUALS(array[3], 25);
TS_ASSERT_EQUALS(array[4], -11);
TS_ASSERT_EQUALS(array.size(), (unsigned int)5);
}
void test_remove_at() {
Common::Array<int> array;
// First of all some data
array.push_back(-12);
array.push_back(17);
array.push_back(33);
array.push_back(25);
array.push_back(-11);
// Remove some data
array.remove_at(1);
TS_ASSERT_EQUALS(array[0], -12);
TS_ASSERT_EQUALS(array[1], 33);
TS_ASSERT_EQUALS(array[2], 25);
TS_ASSERT_EQUALS(array[3], -11);
TS_ASSERT_EQUALS(array.size(), (unsigned int)4);
}
void test_push_back() {
Common::Array<int> array1, array2;
// Some data for both
array1.push_back(-3);
array1.push_back(5);
array1.push_back(9);
array2.push_back(3);
array2.push_back(-2);
array2.push_back(-131);
array1.push_back(array2);
TS_ASSERT_EQUALS(array1[0], -3);
TS_ASSERT_EQUALS(array1[1], 5);
TS_ASSERT_EQUALS(array1[2], 9);
TS_ASSERT_EQUALS(array1[3], 3);
TS_ASSERT_EQUALS(array1[4], -2);
TS_ASSERT_EQUALS(array1[5], -131);
TS_ASSERT_EQUALS(array1.size(), (unsigned int)6);
TS_ASSERT_EQUALS(array2.size(), (unsigned int)3);
}
struct SafeInt {
int val;
SafeInt() : val(0) {}
SafeInt(int v) : val(v) {}
~SafeInt() { val = -1; }
bool operator==(int v) {
return val == v;
}
};
void test_push_back_ex() {
// This test makes sure that inserting an element invalidates
// references/iterators/pointers to elements in the array itself
// only *after* their value has been copied.
Common::Array<SafeInt> array;
array.push_back(42);
for (int i = 0; i < 40; ++i) {
array.push_back(array[0]);
TS_ASSERT_EQUALS(array[i], 42);
}
}
void test_copy_constructor() {
Common::Array<int> array1;
// Some data for both
array1.push_back(-3);
array1.push_back(5);
array1.push_back(9);
Common::Array<int> array2(array1);
TS_ASSERT_EQUALS(array2[0], -3);
TS_ASSERT_EQUALS(array2[1], 5);
TS_ASSERT_EQUALS(array2[2], 9);
TS_ASSERT_EQUALS(array2.size(), (unsigned int)3);
}
void test_array_constructor() {
const int array1[] = { -3, 5, 9 };
Common::Array<int> array2(array1, 3);
TS_ASSERT_EQUALS(array2[0], -3);
TS_ASSERT_EQUALS(array2[1], 5);
TS_ASSERT_EQUALS(array2[2], 9);
TS_ASSERT_EQUALS(array2.size(), (unsigned int)3);
}
void test_array_constructor_str() {
const char *array1[] = { "a", "b", "c" };
Common::StringList array2(array1, 3);
TS_ASSERT_EQUALS(array2[0], "a");
TS_ASSERT_EQUALS(array2[1], "b");
TS_ASSERT_EQUALS(array2[2], "c");
TS_ASSERT_EQUALS(array2.size(), (unsigned int)3);
}
void test_front_back_push_pop() {
Common::Array<int> container;
container.push_back( 42);
container.push_back(-23);
TS_ASSERT_EQUALS(container.front(), 42);
TS_ASSERT_EQUALS(container.back(), -23);
container.front() = -17;
container.back() = 163;
TS_ASSERT_EQUALS(container.front(), -17);
TS_ASSERT_EQUALS(container.back(), 163);
container.pop_back();
TS_ASSERT_EQUALS(container.front(), -17);
TS_ASSERT_EQUALS(container.back(), -17);
}
void test_resize() {
Common::Array<int> array;
array.resize(3);
TS_ASSERT_EQUALS(array.size(), (unsigned int)3);
array[0] = -3;
array[1] = 163;
array[2] = 17;
array.resize(100);
TS_ASSERT_EQUALS(array.size(), (unsigned int)100);
TS_ASSERT_EQUALS(array[0], -3);
TS_ASSERT_EQUALS(array[1], 163);
TS_ASSERT_EQUALS(array[2], 17);
TS_ASSERT_EQUALS(array[99], 0);
array.resize(2);
TS_ASSERT_EQUALS(array.size(), (unsigned int)2);
TS_ASSERT_EQUALS(array[0], -3);
TS_ASSERT_EQUALS(array[1], 163);
}
};