mirror of
https://github.com/libretro/scummvm.git
synced 2025-01-01 23:18:44 +00:00
d087c9605f
Previously, a C-style cast was used to convert a Common::Array<Plugin *>, populated with pointers to StaticPlugin and DynamicPlugin instances, to a Common::Array<PluginSubclass<T> *>, but PluginSubclass<T> is a *sibling* class to StaticPlugin/DynamicPlugin, so this cast was invalid and the results undefined. The methods for retrieving subclasses of plugins can't be easily changed to just generate an array of temporary wrapper objects that expose an identical API which dereferences to the preferred PluginObject subclass because pointers to these objects are retained by other parts of ScummVM, so the wrappers would needed to be persisted or they would need to just re-expose the underlying Plugin object again. This indicated that a way to solve this problem is to have the callers receive Plugin objects and get the PluginObject from the Plugin by explicitly stating their desired type, in a similar manner to std::get(std::variant), so that the pattern used by this patch to solve the problem. Closes gh-1051. |
||
|---|---|---|
| .. | ||
| commandLine.cpp | ||
| commandLine.h | ||
| internal_revision.h.in | ||
| internal_version.h | ||
| internal_version.h.in | ||
| main.cpp | ||
| main.h | ||
| module.mk | ||
| plugins.cpp | ||
| plugins.h | ||
| version.cpp | ||
| version.h | ||