mirror of
https://github.com/libretro/virtualjaguar-libretro.git
synced 2026-11-07 04:36:00 -10:00
Joseph MattielloandClaude Opus 5
026279c365
From the Copilot review on PR #724, which flagged that
vfs_implementation_cdrom.h was removed while still included under
HAVE_CDROM.
The finding is right that the include dangles, but wrong on causation:
deleting the header (616edf0) did not break HAVE_CDROM builds. They were
already impossible, because that header includes <cdrom/cdrom.h> and
libretro-common/include/cdrom/ was NEVER vendored here -- this core
carries a subset of libretro-common.
Actually supporting HAVE_CDROM would mean vendoring the whole cdrom
subsystem to supply the six retro_vfs_file_*_cdrom symbols the 12 blocks
in this file need -- code this core has no use for, since its Jaguar CD
support is its own implementation in src/cd/. That is not a release-time
change, and restoring the header alone would just reinstate a file that
cannot compile.
So the right-sized fix is to make the unsupported path say so, rather
than leave a missing-header error for whoever tries it. Nothing in this
repo defines HAVE_CDROM, so this #error never fires in any of our builds
-- confirmed by the full suite and by CI across 16 platforms.
Verified: make TEST_EXPORTS=1 test exit 0, zero FAILs.
Co-Authored-By: Claude Opus 5 <[email protected]>