mirror of
https://github.com/linkedin/Liger-Kernel.git
synced 2026-10-12 02:17:47 +00:00
Support transfomers v5 (#994)
>[!IMPORTANT] >Do not merge this PR before all issues are resolved! > >Testing with three versions: `4.52.0` , `4.57.6` and the latest stable version >[!NOTE] >nvi-ci is split into correctness test ci and convergence test ci to speed up testing in this PR >, and more jobs for testing bc with transformers v4 (4.49.0 and 4.57.6) > >Whether keeping this change or not is yet to be discussed ## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> This is a dev branch for aggregating PRs related to transformers v5 changes. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [x] run `make test` to ensure correctness - [x] run `make checkstyle` to ensure code style - [x] run `make test-convergence` to ensure convergence --------- Signed-off-by: Tcc0403 <[email protected]> Co-authored-by: Yunwei Dai <[email protected]> Co-authored-by: Vaibhav Jindal <[email protected]> Co-authored-by: Yuki Uehara <[email protected]> Co-authored-by: Chun-Mao Lai <[email protected]> Co-authored-by: Vaibhav Jindal <[email protected]> Co-authored-by: Michael Lai <[email protected]>
This commit is contained in:
co-authored by
Yunwei Dai
Vaibhav Jindal
Yuki Uehara
Chun-Mao Lai
Vaibhav Jindal
Michael Lai
parent
7d82f73d1e
commit
175cdf0e37
@@ -46,7 +46,7 @@ jobs:
|
||||
- name: Run checkstyle
|
||||
run: make checkstyle
|
||||
|
||||
tests:
|
||||
correctness-tests:
|
||||
runs-on: ubuntu-latest
|
||||
needs: [checkstyle]
|
||||
env:
|
||||
@@ -69,15 +69,14 @@ jobs:
|
||||
|
||||
- name: Run tests
|
||||
run: |
|
||||
modal run dev.modal.tests
|
||||
modal run dev.modal.tests::liger_correctness_tests
|
||||
|
||||
tests-bwd:
|
||||
convergence-tests:
|
||||
runs-on: ubuntu-latest
|
||||
needs: [checkstyle]
|
||||
env:
|
||||
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
|
||||
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
|
||||
REBUILD_IMAGE: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
@@ -95,4 +94,109 @@ jobs:
|
||||
|
||||
- name: Run tests
|
||||
run: |
|
||||
modal run dev.modal.tests_bwd
|
||||
modal run dev.modal.tests::liger_convergence_tests
|
||||
|
||||
|
||||
correctness-tests-with-transformers-4-52-0:
|
||||
runs-on: ubuntu-latest
|
||||
needs: [checkstyle]
|
||||
env:
|
||||
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
|
||||
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v6
|
||||
|
||||
- name: Set up Python
|
||||
uses: actions/setup-python@v6
|
||||
with:
|
||||
python-version: '3.10'
|
||||
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
python -m pip install --upgrade pip
|
||||
pip install modal
|
||||
|
||||
- name: Run tests
|
||||
run: |
|
||||
modal run dev.modal.tests::liger_oldest_v4_correctness_tests
|
||||
|
||||
|
||||
|
||||
convergence-tests-with-transformers-4-52-0:
|
||||
runs-on: ubuntu-latest
|
||||
needs: [checkstyle]
|
||||
env:
|
||||
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
|
||||
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v6
|
||||
|
||||
- name: Set up Python
|
||||
uses: actions/setup-python@v6
|
||||
with:
|
||||
python-version: '3.10'
|
||||
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
python -m pip install --upgrade pip
|
||||
pip install modal
|
||||
|
||||
- name: Run tests
|
||||
run: |
|
||||
modal run dev.modal.tests::liger_oldest_v4_convergence_tests
|
||||
|
||||
correctness-tests-with-transformers-4-57-6:
|
||||
runs-on: ubuntu-latest
|
||||
needs: [checkstyle]
|
||||
env:
|
||||
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
|
||||
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v6
|
||||
|
||||
- name: Set up Python
|
||||
uses: actions/setup-python@v6
|
||||
with:
|
||||
python-version: '3.10'
|
||||
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
python -m pip install --upgrade pip
|
||||
pip install modal
|
||||
|
||||
- name: Run tests
|
||||
run: |
|
||||
modal run dev.modal.tests::liger_latest_v4_correctness_tests
|
||||
|
||||
|
||||
|
||||
convergence-tests-with-transformers-4-57-6:
|
||||
runs-on: ubuntu-latest
|
||||
needs: [checkstyle]
|
||||
env:
|
||||
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
|
||||
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v6
|
||||
|
||||
- name: Set up Python
|
||||
uses: actions/setup-python@v6
|
||||
with:
|
||||
python-version: '3.10'
|
||||
|
||||
- name: Install dependencies
|
||||
run: |
|
||||
python -m pip install --upgrade pip
|
||||
pip install modal
|
||||
|
||||
- name: Run tests
|
||||
run: |
|
||||
modal run dev.modal.tests::liger_latest_v4_convergence_tests
|
||||
Reference in New Issue
Block a user