mirror of
https://github.com/linkedin/Liger-Kernel.git
synced 2026-10-12 02:17:47 +00:00
Improve ROCm source install extras (#1243)
## Summary Update ROCm source install instructions to install ROCm PyTorch wheels before installing Liger, so `pip install -e .` and `pip install -e ".[dev]"` work without replacing the ROCm torch stack. Align AMD CI with the same install order and ROCm wheel index. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence
This commit is contained in:
@@ -7,12 +7,18 @@ on:
|
||||
paths:
|
||||
- "src/**"
|
||||
- "test/**"
|
||||
- "setup.py"
|
||||
- "pyproject.toml"
|
||||
- ".github/workflows/amd-ci.yml"
|
||||
pull_request:
|
||||
branches:
|
||||
- main
|
||||
paths:
|
||||
- "src/**"
|
||||
- "test/**"
|
||||
- "setup.py"
|
||||
- "pyproject.toml"
|
||||
- ".github/workflows/amd-ci.yml"
|
||||
merge_group:
|
||||
branches:
|
||||
- main
|
||||
@@ -28,7 +34,7 @@ jobs:
|
||||
runs-on: linux-mi300-gpu-1
|
||||
strategy:
|
||||
matrix:
|
||||
rocm_version: ['6.3']
|
||||
rocm_version: ['7.1']
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
@@ -43,8 +49,8 @@ jobs:
|
||||
run: |
|
||||
rocm-smi
|
||||
python -m pip install --upgrade pip
|
||||
pip install -e .[dev]
|
||||
pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm${{ matrix.rocm_version }}/
|
||||
pip3 install torch torchvision --index-url https://download.pytorch.org/whl/rocm${{ matrix.rocm_version }}
|
||||
pip install -e ".[dev]"
|
||||
|
||||
- name: List Python Environments
|
||||
run: python -m pip list
|
||||
|
||||
Reference in New Issue
Block a user