mirror of
https://github.com/linkedin/Liger-Kernel.git
synced 2026-10-12 02:17:47 +00:00
Vaibhav Jindal
e2c374b6f7
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> Add -m flag for modal runs. Otherwise modal runs fail with ``` Run modal run dev.modal.tests::liger_oldest_v4_correctness_tests ╭─ Error ──────────────────────────────────────────────────────────────────────╮ │ Python module paths must be specified with the -m flag. Use `modal run -m │ │ dev.modal.tests` instead. │ ╰──────────────────────────────────────────────────────────────────────────────╯ ``` Also, updated secrets with a temporary modal secrets to test things out. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence