mirror of
https://github.com/linkedin/Liger-Kernel.git
synced 2026-10-12 02:17:47 +00:00
Vaibhav JindalandSteven Shimizu
389d9cf369
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> 1. Recent PR (https://github.com/linkedin/Liger-Kernel/pull/876) added functionality to run tests in parallel. However, this leads to GPU OOM errors breaking the CI. Even commands like `pytest test/transformers/test_tvd.py` are not working on a single GPU setup because of parallelism. This PR fixes this issue by changing the behavior to run tests sequentially. 2. Fixes flaky tests for bf16 for glm4v models by increasing tolerance. 3. Use H100 for nvidia tests. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [x] run `make test` to ensure correctness - [x] run `make checkstyle` to ensure code style - [x] run `make test-convergence` to ensure convergence --------- Co-authored-by: Steven Shimizu <[email protected]>
75 lines
2.5 KiB
Makefile
75 lines
2.5 KiB
Makefile
.PHONY: test checkstyle test-convergence all serve build clean
|
|
|
|
|
|
all: checkstyle test test-convergence
|
|
|
|
# Command to run pytest for correctness tests
|
|
test:
|
|
python -m pytest --disable-warnings \
|
|
--cov=src/liger_kernel \
|
|
--cov-report=term-missing \
|
|
--ignore=test/convergence \
|
|
test/
|
|
|
|
# Command to run coverage report
|
|
coverage:
|
|
coverage report -m
|
|
|
|
# Command to run ruff for linting and formatting code
|
|
checkstyle:
|
|
ruff check .; ruff_check_status=$$?; \
|
|
ruff format --check .; ruff_format_status=$$?; \
|
|
ruff check . --fix; \
|
|
ruff format .; \
|
|
if [ $$ruff_check_status -ne 0 ] || [ $$ruff_format_status -ne 0 ]; then \
|
|
exit 1; \
|
|
fi
|
|
|
|
# Command to run pytest for convergence tests
|
|
# We have to explicitly set HF_DATASETS_OFFLINE=1, or dataset will silently try to send metrics and timeout (80s) https://github.com/huggingface/datasets/blob/37a603679f451826cfafd8aae00738b01dcb9d58/src/datasets/load.py#L286
|
|
test-convergence:
|
|
HF_DATASETS_OFFLINE=1 python -m pytest --disable-warnings test/convergence/fp32/test_mini_models.py
|
|
HF_DATASETS_OFFLINE=1 python -m pytest --disable-warnings test/convergence/fp32/test_mini_models_multimodal.py
|
|
HF_DATASETS_OFFLINE=1 python -m pytest --disable-warnings test/convergence/fp32/test_mini_models_with_logits.py
|
|
|
|
HF_DATASETS_OFFLINE=1 python -m pytest --disable-warnings test/convergence/bf16/test_mini_models.py
|
|
HF_DATASETS_OFFLINE=1 python -m pytest --disable-warnings test/convergence/bf16/test_mini_models_multimodal.py
|
|
HF_DATASETS_OFFLINE=1 python -m pytest --disable-warnings test/convergence/bf16/test_mini_models_with_logits.py
|
|
|
|
# Command to run all benchmark scripts and update benchmarking data file
|
|
# By default this doesn't overwrite existing data for the same benchmark experiment
|
|
# run with `make run-benchmarks OVERWRITE=1` to overwrite existing benchmark data
|
|
BENCHMARK_DIR = benchmark/scripts
|
|
BENCHMARK_SCRIPTS = $(wildcard $(BENCHMARK_DIR)/benchmark_*.py)
|
|
OVERWRITE ?= 0
|
|
|
|
run-benchmarks:
|
|
@for script in $(BENCHMARK_SCRIPTS); do \
|
|
echo "Running benchmark: $$script"; \
|
|
if [ $(OVERWRITE) -eq 1 ]; then \
|
|
python $$script --overwrite; \
|
|
else \
|
|
python $$script; \
|
|
fi; \
|
|
done
|
|
|
|
# MkDocs Configuration
|
|
MKDOCS = mkdocs
|
|
CONFIG_FILE = mkdocs.yml
|
|
SITE_DIR = site
|
|
|
|
# MkDocs targets
|
|
|
|
# Serve the documentation
|
|
serve:
|
|
$(MKDOCS) serve -f $(CONFIG_FILE)
|
|
|
|
# Build the documentation into the specified site directory
|
|
build:
|
|
$(MKDOCS) build -f $(CONFIG_FILE) --site-dir $(SITE_DIR)
|
|
|
|
# Clean the output directory
|
|
clean:
|
|
rm -rf $(SITE_DIR)/
|
|
|