Python fix native function default parameter (#2474)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
solve #2473  and add unit test to prevent this from happening again. 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Abby Harrison <[email protected]>
This commit is contained in:
Joowon
2023-08-21 22:54:02 +00:00
committed by GitHub
co-authored by Abby Harrison
parent 2cf2fbf2c7
commit e42f7fabe8
2 changed files with 101 additions and 0 deletions
@@ -0,0 +1,100 @@
# Copyright (c) Microsoft. All rights reserved.
from semantic_kernel.orchestration.sk_function import SKFunction
from semantic_kernel.skill_definition.sk_function_decorator import sk_function
def test_init_native_function_with_input_description():
class MockMethodWithInputDescription:
__sk_function__ = True
__sk_function_name__ = "mock_function"
__sk_function_description__ = "Mock description"
__sk_function_input_description__ = "Mock input description"
__sk_function_input_default_value__ = "default_input_value"
__sk_function_context_parameters__ = [
{
"name": "param1",
"description": "Param 1 description",
"default_value": "default_param1_value",
}
]
mock_method = MockMethodWithInputDescription
native_function = SKFunction.from_native_method(mock_method, "MockSkill")
assert native_function._function == mock_method
assert native_function._parameters[0].name == "input"
assert native_function._parameters[0].description == "Mock input description"
assert native_function._parameters[0].default_value == "default_input_value"
assert native_function._parameters[1].name == "param1"
assert native_function._parameters[1].description == "Param 1 description"
assert native_function._parameters[1].default_value == "default_param1_value"
def test_init_native_function_without_input_description():
class MockMethodWithoutInputDescription:
__sk_function__ = True
__sk_function_name__ = "mock_function_no_input_desc"
__sk_function_description__ = "Mock description no input desc"
__sk_function_context_parameters__ = [
{
"name": "param1",
"description": "Param 1 description",
"default_value": "default_param1_value",
}
]
mock_method = MockMethodWithoutInputDescription
native_function = SKFunction.from_native_method(mock_method, "MockSkill")
assert native_function._function == mock_method
assert native_function._parameters[0].name == "param1"
assert native_function._parameters[0].description == "Param 1 description"
assert native_function._parameters[0].default_value == "default_param1_value"
def test_init_native_function_from_sk_function_decorator():
@sk_function(
description="Test description",
name="test_function",
input_description="Test input description",
input_default_value="test_default_value",
)
def decorated_function():
pass
assert decorated_function.__sk_function__ is True
assert decorated_function.__sk_function_description__ == "Test description"
assert decorated_function.__sk_function_name__ == "test_function"
assert (
decorated_function.__sk_function_input_description__ == "Test input description"
)
assert (
decorated_function.__sk_function_input_default_value__ == "test_default_value"
)
native_function = SKFunction.from_native_method(decorated_function, "MockSkill")
assert native_function._function == decorated_function
assert native_function._parameters[0].name == "input"
assert native_function._parameters[0].description == "Test input description"
assert native_function._parameters[0].default_value == "test_default_value"
def test_init_native_function_from_sk_function_decorator_defaults():
@sk_function()
def decorated_function():
pass
assert decorated_function.__sk_function__ is True
assert decorated_function.__sk_function_description__ == ""
assert decorated_function.__sk_function_name__ == "decorated_function"
assert decorated_function.__sk_function_input_description__ == ""
assert decorated_function.__sk_function_input_default_value__ == ""
native_function = SKFunction.from_native_method(decorated_function, "MockSkill")
assert native_function._function == decorated_function
assert len(native_function._parameters) == 0