Files
semantic-kernel/python/semantic_kernel/contents/binary_content.py
T
Tao Chen d5c2b9d889 Python: Improves the robustness of filename handling (#13643)
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Improves the robustness of filename handling in the Bedrock agent
integration. Ensures that filenames sourced from external responses are
properly sanitized before use in file operations, and adds safer
defaults for file write behavior.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
1. Sanitize filenames received from Bedrock agent responses.
2. Add overwrite parameter to BinaryContent.write_to_file (defaults to
False).
3. Add tests.
4. Update samples.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
2026-03-12 17:02:02 +00:00

264 lines
9.3 KiB
Python

# Copyright (c) Microsoft. All rights reserved.
import logging
import os
from pathlib import Path
from typing import Annotated, Any, ClassVar, Literal, TypeVar
from xml.etree.ElementTree import Element # nosec
from numpy import ndarray
from pydantic import Field, FilePath, PrivateAttr, UrlConstraints, computed_field
from pydantic_core import Url
from semantic_kernel.contents.const import BINARY_CONTENT_TAG, ContentTypes
from semantic_kernel.contents.kernel_content import KernelContent
from semantic_kernel.contents.utils.data_uri import DataUri
from semantic_kernel.exceptions.content_exceptions import ContentException, ContentInitializationError
from semantic_kernel.utils.feature_stage_decorator import experimental
logger = logging.getLogger(__name__)
_T = TypeVar("_T", bound="BinaryContent")
DataUrl = Annotated[Url, UrlConstraints(allowed_schemes=["data"])]
@experimental
class BinaryContent(KernelContent):
"""This is a base class for different types of binary content.
This can be created either the bytes data or a data uri, additionally it can have a uri.
The uri is a reference to the source, and might or might not point to the same thing as the data.
Ideally only subclasses of this class are used, like ImageContent.
Methods:
__str__: Returns the string representation of the content.
Raises:
ValidationError: If any arguments are malformed.
"""
content_type: Literal[ContentTypes.BINARY_CONTENT] = Field(default=BINARY_CONTENT_TAG, init=False) # type: ignore
uri: Url | str | None = None
default_mime_type: ClassVar[str] = "text/plain"
tag: ClassVar[str] = BINARY_CONTENT_TAG
_data_uri: DataUri | None = PrivateAttr(default=None)
def __init__(
self,
uri: Url | str | None = None,
data_uri: DataUrl | str | None = None,
data: str | bytes | ndarray | None = None,
data_format: str | None = None,
mime_type: str | None = None,
**kwargs: Any,
):
"""Create a Binary Content object, either from a data_uri or data.
Args:
uri: The reference uri of the content.
data_uri: The data uri of the content.
data: The data of the content.
data_format: The format of the data (e.g. base64).
mime_type: The mime type of the content, not always relevant.
kwargs: Any additional arguments:
inner_content: The inner content of the response,
this should hold all the information from the response so even
when not creating a subclass a developer can leverage the full thing.
ai_model_id: The id of the AI model that generated this response.
metadata: Any metadata that should be attached to the response.
"""
temp_data_uri: DataUri | None = None
if data_uri:
temp_data_uri = DataUri.from_data_uri(data_uri, self.default_mime_type)
kwargs.setdefault("metadata", {})
kwargs["metadata"].update(temp_data_uri.parameters)
elif data is not None:
match data:
case bytes():
temp_data_uri = DataUri(
data_bytes=data, data_format=data_format, mime_type=mime_type or self.default_mime_type
)
case ndarray():
temp_data_uri = DataUri(
data_array=data, data_format=data_format, mime_type=mime_type or self.default_mime_type
)
case str():
temp_data_uri = DataUri(
data_str=data, data_format=data_format, mime_type=mime_type or self.default_mime_type
)
if uri is not None:
if isinstance(uri, str) and os.path.exists(uri):
if os.path.isfile(uri):
uri = str(Path(uri))
else:
raise ContentInitializationError("URI must be a file path, not a directory.")
elif isinstance(uri, str):
uri = Url(uri)
super().__init__(uri=uri, **kwargs)
self._data_uri = temp_data_uri
@computed_field # type: ignore
@property
def data_uri(self) -> str:
"""Get the data uri."""
if self._data_uri:
return self._data_uri.to_string(self.metadata)
return ""
@data_uri.setter
def data_uri(self, value: str):
"""Set the data uri."""
if not self._data_uri:
self._data_uri = DataUri.from_data_uri(value, self.default_mime_type)
else:
self._data_uri.update_data(value)
self.metadata.update(self._data_uri.parameters)
@property
def data_string(self) -> str:
"""Returns the data as a string, using the data format."""
if self._data_uri:
return self._data_uri._data_str()
return ""
@property
def data(self) -> bytes | ndarray:
"""Get the data."""
if self._data_uri and self._data_uri.data_array is not None:
return self._data_uri.data_array.tobytes()
if self._data_uri and self._data_uri.data_bytes:
return self._data_uri.data_bytes
return b""
@data.setter
def data(self, value: str | bytes | ndarray):
"""Set the data."""
if self._data_uri:
self._data_uri.update_data(value)
return
match value:
case ndarray():
self._data_uri = DataUri(data_array=value, mime_type=self.mime_type)
case str():
self._data_uri = DataUri(data_str=value, mime_type=self.mime_type)
case bytes():
self._data_uri = DataUri(data_bytes=value, mime_type=self.mime_type)
case _:
raise ContentException("Data must be a string, bytes, or numpy array.")
@property
def mime_type(self) -> str:
"""Get the mime type."""
if self._data_uri and self._data_uri.mime_type:
return self._data_uri.mime_type
return self.default_mime_type
@mime_type.setter
def mime_type(self, value: str):
"""Set the mime type."""
if self._data_uri:
self._data_uri.mime_type = value
@property
def can_read(self) -> bool:
"""Get whether the content can be read.
Returns True if the content has data available for reading.
"""
return self._data_uri is not None
@classmethod
def from_file(
cls: type[_T],
file_path: str | Path,
mime_type: str | None = None,
) -> _T:
"""Create BinaryContent from a file.
Args:
file_path: Path to the file to read
mime_type: MIME type of the file content
Returns:
BinaryContent instance with file data
Raises:
FileNotFoundError: If the file doesn't exist
ContentInitializationError: If the path is not a file
"""
from semantic_kernel.exceptions.content_exceptions import ContentInitializationError
path = Path(file_path)
if not path.exists():
raise FileNotFoundError(f"File not found: {file_path}")
if not path.is_file():
raise ContentInitializationError(f"Path is not a file: {file_path}")
# Read file as binary data to handle all file types properly
data = path.read_bytes()
return cls(
data=data,
mime_type=mime_type,
uri=str(path),
data_format="base64",
)
def __str__(self) -> str:
"""Return the string representation of the content."""
return self.data_uri if self._data_uri else str(self.uri)
def to_element(self) -> Element:
"""Convert the instance to an Element."""
element = Element(self.tag)
if self._data_uri:
element.text = self.data_uri
if self.uri:
element.set("uri", str(self.uri))
return element
@classmethod
def from_element(cls: type[_T], element: Element) -> _T:
"""Create an instance from an Element."""
if element.tag != cls.tag:
raise ContentInitializationError(f"Element tag is not {cls.tag}") # pragma: no cover
if element.text:
return cls(data_uri=element.text, uri=element.get("uri", None))
return cls(uri=element.get("uri", None))
def write_to_file(self, path: str | FilePath, *, overwrite: bool = False) -> None:
"""Write the data to a file.
Args:
path: The path to write the file to.
overwrite: If True, overwrite existing files. If False, raise an error if file exists.
Defaults to False.
Raises:
FileExistsError: If overwrite is False and the file already exists.
"""
file_path = Path(path)
if not overwrite and file_path.exists():
raise FileExistsError(f"File already exists and overwrite is disabled: {path}")
if self._data_uri and self._data_uri.data_array is not None:
self._data_uri.data_array.tofile(path)
return
with open(path, "wb") as file:
assert isinstance(self.data, bytes) # nosec
file.write(self.data)
def to_dict(self) -> dict[str, Any]:
"""Convert the instance to a dictionary."""
return {"type": "binary", "binary": {"uri": str(self)}}