mirror of
https://github.com/microsoft/semantic-kernel.git
synced 2026-10-12 02:19:06 +00:00
a1749f78b4
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Java: Connectors - Memory - Unit test coverage #1598 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Run unit tests with coverage and add additional tests to try to increase coverage. Added positive tests cases for AzureCognitiveSearchMemory. Negative tests and coverage need to be addressed. Because this is somewhat time consuming, I suggest that be done in a separate PR rather than hold this PR. I have created [Java: Increase coverage of AzureCognitiveSearchMemoryTests ](https://github.com/microsoft/semantic-kernel/issues/1797) for that purpose. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>