mirror of
https://github.com/microsoft/semantic-kernel.git
synced 2026-10-12 11:19:56 +00:00
Eduard van Valkenburg
ccbeb7b285
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We got a report stating that a empty chat_history between two other params, didn't work, so had to change some things in the way chat_history xml is done, and subsequent improved the parsing, now using xml fully. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Added to_element methods to CMC classes, to_prompt uses that. - Redid the chat_history from_prompt method to fully utilize xml parsing. - Added chat_history tags to detect an empty chatHistory in a prompt. - Made sure when only 1 message is put into the ChatHistory after rendering that that is a USER message, instead of SYSTEM, if multiple the first one is still SYSTEM. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄