mirror of
https://github.com/microsoft/semantic-kernel.git
synced 2026-10-12 02:19:06 +00:00
d9520ee716
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adding memory connector for MySQL with a couple of updates to the JDBC connector column names to make most methods compatible with MySQL and other SQL engines. Also adding one more test to check successful memory store initialization when existing database objects have already been created. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]> Co-authored-by: David Grieve <[email protected]>
120 lines
3.7 KiB
XML
120 lines
3.7 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<FindBugsFilter>
|
|
|
|
<!-- NullMemory.getInstance() may expose internal representation by returning NullMemory.DEFAULT, but NullMemory has no internal representation. -->
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.memory.NullMemory"/>
|
|
<Method name="getInstance"/>
|
|
<Bug pattern="MS_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<!-- DefaultSemanticTextMemory(MemoryStore, EmbeddingGeneration) may expose internal representation by storing an externally mutable object into DefaultSemanticTextMemory._storage -->
|
|
<!-- TODO: This should be a temporary exclusion pending a proper fix, if possible. -->
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.memory.DefaultSemanticTextMemory"/>
|
|
<Field name="_storage"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.Kernel$Builder"/>
|
|
<Method name="withMemoryStore"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.Kernel$Builder"/>
|
|
<Method name="withMemory"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.DefaultKernel"/>
|
|
<Field name="memoryStore"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.DefaultKernel"/>
|
|
<Method name="getMemory"/>
|
|
<Bug pattern="EI_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.DefaultKernel"/>
|
|
<Field name="memory"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.DefaultKernel"/>
|
|
<Method name="registerMemory"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.ai.embeddings.Embedding"/>
|
|
<Method name="getVector"/>
|
|
<Bug pattern="EI_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.memory.DefaultSemanticTextMemory$Builder"/>
|
|
<Method name="withStorage"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.skilldefinition.DefaultSkillCollection"/>
|
|
<Method name="getSkillCollection"/>
|
|
<Bug pattern="EI_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.jdbc.JDBCConnector"/>
|
|
<Method name="<init>"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.jdbc.JDBCMemoryStore"/>
|
|
<Method name="<init>"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.jdbc.JDBCMemoryStore$Builder"/>
|
|
<Method name="withConnection"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.sqlite.SQLiteMemoryStore$Builder"/>
|
|
<Method name="withConnection"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.postgresql.PostgreSQLMemoryStore$Builder"/>
|
|
<Method name="withConnection"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.mysql.MySQLMemoryStore$Builder"/>
|
|
<Method name="withConnection"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.azurecognitivesearch.AzureCognitiveSearchMemoryRecord"/>
|
|
<Bug pattern="EI_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.connectors.memory.azurecognitivesearch.AzureCognitiveSearchMemoryStore"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
</FindBugsFilter>
|