mirror of
https://github.com/milvus-io/milvus.git
synced 2026-10-12 02:19:10 +00:00
Li LiuandClaude Opus 5
a7941e8b6f
issue: #53283 ## What Add `internal/core/src/storage/minio/MinioChunkManager.cpp` to the `milvus_storage` section of `scripts/segcore_error_boundary_baseline.txt`. ## Why master's `make static-check` is currently broken: ``` Start check segcore error boundaries ERROR: new file(s) reference 'milvus_storage' (ratcheted library). internal/core/src/storage/minio/MinioChunkManager.cpp ``` - #50768 (merged 09-11) introduced the ratcheted segcore error boundary check. - #53284 (merged 09-14 09:13Z) added `milvus_storage::` references to `MinioChunkManager.cpp`. Its CI ran without the check in scope, so the baseline was never updated. Evidence that this breaks things: - master post-merge `build-ut-cov` on `e3654ef` fails in Code-Check with this error ([#31153](https://jenkins-milvus-ci.milvus.io/job/MILVUS-CI-V2-PR-PIPELINES/job/milvus-build-ut-ciloop-pipeline/31153/)). - PRs whose head includes #53284 fail the same way, e.g. #53377 ([#31143](https://jenkins-milvus-ci.milvus.io/job/MILVUS-CI-V2-PR-PIPELINES/job/milvus-build-ut-ciloop-pipeline/31143/)) and #53456 ([#31158](https://jenkins-milvus-ci.milvus.io/job/MILVUS-CI-V2-PR-PIPELINES/job/milvus-build-ut-ciloop-pipeline/31158/)). - PRs merged after #53284 were not affected only because their CI ran before it landed. ## Why a baseline entry is acceptable The check requires a new consumer to classify errors on every path. In the new code, the only failing `milvus_storage` call (`BuildGcpProviderFromConfig`) is already mapped with `throw milvus_storage::ToSegcoreError(provider.status())`. That form is explicitly allowlisted by the script. ## Notes - The line was added by hand. Regenerating with `UPDATE_SEGCORE_ERROR_BASELINE=1` on macOS reorders entries (locale-dependent sort) and drops `pb/index_cgo_msg.pb.h`, which only exists after proto generation. - #53145 also adds this baseline line, but at a different position. A three-way merge applies without conflict but leaves a duplicate line. The duplicate is harmless to the script (it compares sorted sets), but whichever PR lands second should drop its copy. ## Verification `bash scripts/check_segcore_error_boundaries.sh` on upstream master `5c86e948be`: - before: exit 1 with the error above - after: `segcore error boundaries OK`, exit 0 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PGMeYPnXk9FbvEB2uCJLj9 Signed-off-by: Li Liu <[email protected]> Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
Compile and install milvus cluster
Environment
OS: Ubuntu 20.04
go：1.21
cmake: >=3.18
gcc: >= 11
Install dependencies
Install compile dependencies
$ sudo apt install -y g++ gcc make libssl-dev zlib1g-dev libboost-regex-dev \
libboost-program-options-dev libboost-system-dev libboost-filesystem-dev \
libboost-serialization-dev python3-dev libboost-python-dev libcurl4-openssl-dev gfortran libtbb-dev
$ export GO111MODULE=on
$ go get github.com/golang/protobuf/[email protected]
OpenBLAS is managed by Conan for C++ core builds. Install the compiler toolchain and Fortran runtime needed by Conan, then run the normal third-party build step.
Compile
Generate the go files from proto file
$ make check-proto-product
Check code specifications
$ make verifiers
Compile milvus
$ make milvus
Install docker-compose
refer: https://docs.docker.com/compose/install/
$ sudo curl -L "https://github.com/docker/compose/releases/download/1.27.4/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
$ sudo chmod +x /usr/local/bin/docker-compose
$ sudo ln -s /usr/local/bin/docker-compose /usr/bin/docker-compose
$ docker-compose --version
$ docker compose --version
Start service
Start third-party service:
$ cd [milvus project path]/deployments/docker/cluster
$ docker-compose up -d
$ docker compose up -d
Start milvus cluster:
$ cd [milvus project path]
$ ./scripts/start_cluster.sh
Run unittest
Run all unittest including go and cpp cases:
$ make unittest
You also can run go unittest only:
$ make test-go
Run cpp unittest only:
$ make test-cpp
Run code coverage
Run code coverage including go and cpp:
$ make codecov
You also can run go code coverage only:
$ make codecov-go
Run cpp code coverage only:
$ make codecov-cpp