mirror of
https://github.com/milvus-io/milvus.git
synced 2026-10-12 02:19:10 +00:00
issue: #50615 ## What this PR does Makes the C++ core build cleanly on **macOS (Apple Silicon) with Homebrew LLVM/clang 19**. > [!IMPORTANT] > **Scope / impact is NOT macOS-only.** Although this PR is framed as macOS/clang-19 enablement, two of the changes are **top-level `requires(...)` in `internal/core/conanfile.py`, so they apply to every platform, including Linux production builds:** > - **`azure-sdk-for-cpp` `1.11.3@milvus/dev` → `1.16.0@milvus/dev`** (5 minor versions, `force=True`). This is the SDK Arrow uses for the **Azure Blob remote-storage path**, so this is effectively a major Azure SDK bump on the **production Azure object-storage path for Linux deployments** too. > - **`arrow` recipe `17.0.0@milvus/dev-2.6#c743ea7a…` → `17.0.0@milvus/dev#f411aa73…`** — same Arrow version, but **rebuilt against azure 1.16.0** with a patched `FindAzure.cmake`. The Arrow **`package_id` (recipe revision) DID change**; it is not the same binary as before. > - **`libbson/1.30.6@milvus/dev`** added (also global, but new — no pre-existing behavior to regress). > > **Testing blind spot:** CI green proves compile/link/UT/e2e pass, but the UT and integration suites **do not exercise real Azure Blob read/write**, so the Azure object-storage path is **not covered** by this PR's CI. A real Azure Blob remote-storage regression is recommended before merge (see Verification). ### Why the dependency bumps are required for clang 19 - **azure 1.16.0**: azure 1.11.3 bundles an older `nlohmann/json` that uses `std::char_traits<unsigned char>`, which was **removed in libc++ 19** → 1.11.3 fails to compile on clang 19. 1.16.0 fixes this. - **arrow rebuilt against azure 1.16.0**: when Arrow is built from source on clang 19 it must link the same azure 1.16.0; the recipe also patches `FindAzure.cmake` to the monolithic `Azure` config so `find_package(Azure)` resolves. Hence a new Arrow recipe revision. ### Toolchain / build enablement - **`scripts/setenv.sh`**: probe LLVM 19/20/21 first (libc++ 17/18 `chrono operator<<` clashes with Arrow's vendored `date`; libc++ 19 fixes it). - **`scripts/3rdparty_build.sh`**: arm64 `-march=armv8-a+crypto+crc` so folly's F14 (SimdAndCrc on Apple Silicon) matches core/knowhere — fixes `F14LinkCheck` undefined-symbol link errors. - **`InvertedIndexTantivy.cpp`**: drop spurious `->template` on non-template members (clang 19 `-Wmissing-template-arg-list-after-template-kw`). ### Drop bsoncxx / libmongoc → libbson only The BSON layer used the **bsoncxx** C++ driver, whose CMake unconditionally builds mongo-cxx-driver → **libmongoc** → bundled **utf8proc**, which fails to configure under newer CMake/clang on macOS. Milvus only needs BSON (de)serialization. - New Conan package **`libbson/1.30.6@milvus/dev`** (libbson-only, `ENABLE_MONGOC=OFF`; recipe published to milvus conanfiles & production). - New **`src/common/bson_shim.h`** — a thin `milvus::bson` C++ layer over libbson's C API. - Migrated `bson_view.h`, `bson_builder.{h,cpp}`, json_stats consumers and unit tests off bsoncxx. - CMake: `find_package(bson-1.0)` + link `mongo::bson_shared`; removed FetchContent `thirdparty/bsoncxx`. All three global Conan requires (arrow / libbson / azure) pin an explicit recipe `#revision` for reproducibility. ## Verification - Full clean rebuild on macOS arm64 / clang 19: `bin/milvus` builds; `libmilvus_core` links **only `libbson-1.0.dylib`** (no libmongoc/mongocxx/utf8proc). - libbson / arrow / azure resolve from production Conan at the pinned revisions. - All 21 BSON unit tests (BsonView / BsonBuilder / DomNode) pass. - Full ci-v2 suite green on Linux (build / build-ut-cov / ut-cpp / ut-go / integration / e2e / go-sdk). - **TODO before merge:** real Azure Blob remote-storage read/write regression to cover the azure-1.16.0 / arrow-rebuild blast radius (not exercised by UT/integration). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: xiaofanluan <[email protected]> Co-authored-by: xiaofanluan <[email protected]> Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
469 lines
17 KiB
CMake
469 lines
17 KiB
CMake
# Licensed to the LF AI & Data foundation under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
cmake_minimum_required( VERSION 3.18 )
|
|
|
|
if ( APPLE )
|
|
set( CMAKE_CROSSCOMPILING TRUE )
|
|
set( RUN_HAVE_GNU_POSIX_REGEX 0 )
|
|
endif ()
|
|
|
|
add_definitions(-DELPP_THREAD_SAFE)
|
|
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
|
|
message( STATUS "Building using CMake version: ${CMAKE_VERSION}" )
|
|
|
|
if ( BUILD_UNIT_TEST STREQUAL "ON" )
|
|
add_definitions(-DWITHOUT_GO_LOGGING)
|
|
endif()
|
|
|
|
if ( MILVUS_GPU_VERSION )
|
|
add_definitions(-DMILVUS_GPU_VERSION)
|
|
endif ()
|
|
|
|
if ( USE_DYNAMIC_SIMD )
|
|
add_definitions(-DUSE_DYNAMIC_SIMD)
|
|
endif()
|
|
|
|
project(core)
|
|
include(CheckCXXCompilerFlag)
|
|
if ( APPLE )
|
|
message(STATUS "==============Darwin Environment==============")
|
|
elseif (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
|
|
message(STATUS "==============Linux Environment===============")
|
|
set(LINUX TRUE)
|
|
elseif ( MSYS )
|
|
message( STATUS "==============MSYS Environment===============" )
|
|
else ()
|
|
message(FATAL_ERROR "Unsupported platform!" )
|
|
endif ()
|
|
|
|
# Use -g1 (minimal debug info) for Release to speed up compile & link;
|
|
# full -g for Debug/RelWithDebInfo where detailed debugging matters.
|
|
if (CMAKE_BUILD_TYPE STREQUAL "Release" OR CMAKE_BUILD_TYPE STREQUAL "MinSizeRel")
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g1")
|
|
else ()
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g")
|
|
endif ()
|
|
|
|
# Use pipes between compiler stages instead of temp files (faster I/O)
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pipe")
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pipe")
|
|
|
|
# Enable hardware popcnt for all compilation units on x86_64.
|
|
# PopCountHelper in bitset/detail/popcount.h is header-only; without this flag,
|
|
# __builtin_popcountll falls back to __popcountdi2 software emulation.
|
|
if (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "x86_64")
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mpopcnt")
|
|
endif()
|
|
|
|
if (CMAKE_COMPILER_IS_GNUCC)
|
|
if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 11.99)
|
|
# ignore deprecated declarations for gcc>=12
|
|
# TODO: this workaround may removed when protobuf upgraded
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=deprecated-declarations")
|
|
endif ()
|
|
if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 12.99)
|
|
# gcc>=13 removed implicit includes for <cstdint>, <cstdlib>, <algorithm> etc.
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -include cstdint -include cstdlib -include algorithm")
|
|
endif ()
|
|
endif ()
|
|
|
|
set( CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake" )
|
|
include( Utils )
|
|
|
|
# ---- Split DWARF (Linux only) ----
|
|
# Moves debug info into .dwo files, dramatically reducing .o file sizes
|
|
# and link time. Requires GCC 4.8+ or Clang 3.7+.
|
|
if (LINUX AND NOT USE_ASAN STREQUAL "ON")
|
|
check_cxx_compiler_flag("-gsplit-dwarf" HAS_SPLIT_DWARF)
|
|
if (HAS_SPLIT_DWARF)
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -gsplit-dwarf")
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -gsplit-dwarf")
|
|
message(STATUS "Using -gsplit-dwarf for faster linking")
|
|
endif ()
|
|
endif ()
|
|
|
|
|
|
# **************************** Build time, type and code version ****************************
|
|
get_current_time( BUILD_TIME )
|
|
message( STATUS "Build time = ${BUILD_TIME}" )
|
|
|
|
get_build_type( TARGET BUILD_TYPE DEFAULT "Release" )
|
|
message( STATUS "Build type = ${BUILD_TYPE}" )
|
|
|
|
get_milvus_version( TARGET MILVUS_VERSION DEFAULT "2.0" )
|
|
message( STATUS "Build version = ${MILVUS_VERSION}" )
|
|
|
|
get_last_commit_id( LAST_COMMIT_ID )
|
|
message( STATUS "LAST_COMMIT_ID = ${LAST_COMMIT_ID}" )
|
|
|
|
set( CMAKE_EXPORT_COMPILE_COMMANDS ON )
|
|
|
|
# **************************** Project ****************************
|
|
project( milvus VERSION "${MILVUS_VERSION}" )
|
|
|
|
# Unity (jumbo) build: merge multiple .cpp files per target into fewer
|
|
# translation units, dramatically reducing redundant header parsing.
|
|
if ( MILVUS_UNITY_BUILD )
|
|
set( CMAKE_UNITY_BUILD ON )
|
|
# ~8 sources per unity chunk is a good balance between speed and memory.
|
|
set( CMAKE_UNITY_BUILD_BATCH_SIZE 8 )
|
|
message( STATUS "Unity build enabled (batch size ${CMAKE_UNITY_BUILD_BATCH_SIZE})" )
|
|
endif ()
|
|
|
|
set( CMAKE_CXX_STANDARD 20 )
|
|
set( CMAKE_CXX_STANDARD_REQUIRED on )
|
|
|
|
# Use std::shared_ptr/std::string_view etc. instead of opentelemetry::nostd::
|
|
# equivalents. This MUST be consistent across every translation unit that
|
|
# includes OTel headers; a mismatch causes an ODR violation / ABI break
|
|
# because nostd::shared_ptr has a completely different memory layout (32-byte
|
|
# PlacementBuffer) compared to std::shared_ptr (16 bytes).
|
|
add_compile_definitions( OPENTELEMETRY_STL_VERSION=2017 )
|
|
|
|
set( MILVUS_SOURCE_DIR ${PROJECT_SOURCE_DIR} )
|
|
set( MILVUS_BINARY_DIR ${PROJECT_BINARY_DIR} )
|
|
set( MILVUS_ENGINE_SRC ${PROJECT_SOURCE_DIR}/src )
|
|
set( MILVUS_THIRDPARTY_SRC ${PROJECT_SOURCE_DIR}/thirdparty )
|
|
|
|
# This will set RPATH to all excutable TARGET
|
|
# self-installed dynamic libraries will be correctly linked by excutable
|
|
set( CMAKE_INSTALL_RPATH "/usr/lib" "${CMAKE_INSTALL_PREFIX}/lib" "${CMAKE_INSTALL_PREFIX}/lib64" )
|
|
set( CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE )
|
|
# The FetchContent-built libbson shared lib is placed in ${CMAKE_BINARY_DIR}/lib.
|
|
# The linker needs -rpath-link to resolve it (e.g. libmilvus_core.so ->
|
|
# libbson-1.0.so) when linking test binaries.
|
|
set( CMAKE_BUILD_RPATH "${CMAKE_BINARY_DIR}/lib" )
|
|
|
|
# **************************** Dependencies ****************************
|
|
# Conan 2: CMakeToolchain sets CMAKE_PREFIX_PATH via toolchain file
|
|
# CMakeDeps generates <pkg>-config.cmake files for find_package()
|
|
list( APPEND CMAKE_MODULE_PATH ${CMAKE_BINARY_DIR}/conan )
|
|
|
|
find_package(Protobuf REQUIRED)
|
|
find_package(Boost REQUIRED)
|
|
find_package(glog REQUIRED)
|
|
find_package(folly REQUIRED)
|
|
find_package(RocksDB REQUIRED)
|
|
find_package(Arrow REQUIRED)
|
|
find_package(gRPC REQUIRED)
|
|
find_package(opentelemetry-cpp REQUIRED)
|
|
find_package(google-cloud-cpp REQUIRED)
|
|
find_package(prometheus-cpp REQUIRED)
|
|
find_package(yaml-cpp REQUIRED)
|
|
find_package(nlohmann_json REQUIRED)
|
|
find_package(fmt REQUIRED)
|
|
find_package(re2 REQUIRED)
|
|
find_package(OpenSSL REQUIRED)
|
|
find_package(CURL REQUIRED)
|
|
find_package(ZLIB REQUIRED)
|
|
find_package(lz4 REQUIRED)
|
|
find_package(zstd REQUIRED)
|
|
find_package(Snappy REQUIRED)
|
|
find_package(roaring REQUIRED)
|
|
find_package(marisa REQUIRED)
|
|
find_package(geos REQUIRED)
|
|
find_package(ICU REQUIRED COMPONENTS uc)
|
|
find_package(xxHash REQUIRED)
|
|
find_package(TBB REQUIRED)
|
|
find_package(libsodium REQUIRED)
|
|
find_package(double-conversion REQUIRED)
|
|
find_package(gflags REQUIRED)
|
|
find_package(xsimd REQUIRED)
|
|
find_package(unordered_dense REQUIRED)
|
|
find_package(absl REQUIRED)
|
|
find_package(bson-1.0 REQUIRED)
|
|
find_package(simde REQUIRED)
|
|
find_package(milvus-common REQUIRED)
|
|
if (LINUX)
|
|
find_package(OpenBLAS CONFIG REQUIRED)
|
|
endif()
|
|
find_package(LibLZMA REQUIRED)
|
|
find_package(RdKafka REQUIRED)
|
|
find_package(GTest REQUIRED)
|
|
find_package(benchmark REQUIRED)
|
|
find_package(googleapis REQUIRED)
|
|
find_package(libavrocpp REQUIRED)
|
|
find_package(AWSSDK REQUIRED)
|
|
find_package(Azure REQUIRED)
|
|
|
|
include( CTest )
|
|
include( BuildUtils )
|
|
include( DefineOptions )
|
|
using_ccache_if_defined(MILVUS_USE_CCACHE)
|
|
|
|
include( ExternalProject )
|
|
include( GNUInstallDirs )
|
|
include( FetchContent )
|
|
|
|
include_directories( thirdparty )
|
|
|
|
set( FETCHCONTENT_BASE_DIR ${MILVUS_BINARY_DIR}/3rdparty_download )
|
|
set( FETCHCONTENT_QUIET OFF )
|
|
include( ThirdPartyPackages )
|
|
|
|
# **************************** Compiler arguments ****************************
|
|
message( STATUS "Building Milvus CPU version" )
|
|
|
|
if (LINUX OR MSYS)
|
|
append_flags( CMAKE_CXX_FLAGS
|
|
FLAGS
|
|
"-fPIC"
|
|
"-DELPP_THREAD_SAFE"
|
|
"-fopenmp"
|
|
"-Wno-error"
|
|
"-Wno-all"
|
|
)
|
|
if (USE_ASAN STREQUAL "ON")
|
|
message( STATUS "Building Milvus Core Using AddressSanitizer")
|
|
add_compile_options(-fno-stack-protector -fno-omit-frame-pointer -fno-var-tracking -fsanitize=address)
|
|
add_link_options(-fno-stack-protector -fno-omit-frame-pointer -fno-var-tracking -fsanitize=address)
|
|
endif()
|
|
if (CMAKE_BUILD_TYPE STREQUAL "Release")
|
|
append_flags( CMAKE_CXX_FLAGS
|
|
"-O3"
|
|
)
|
|
endif()
|
|
endif ()
|
|
|
|
if ( APPLE )
|
|
append_flags( CMAKE_CXX_FLAGS
|
|
FLAGS
|
|
"-fPIC"
|
|
"-DELPP_THREAD_SAFE"
|
|
"-fopenmp"
|
|
"-pedantic"
|
|
"-Wall"
|
|
"-D_DARWIN_C_SOURCE"
|
|
"-Wno-gnu-zero-variadic-macro-arguments"
|
|
"-Wno-variadic-macros"
|
|
"-Wno-reorder-ctor"
|
|
"-Wno-c++11-narrowing"
|
|
"-DBOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED=1"
|
|
)
|
|
# Fix for macOS 14+ (Sonoma) linker requiring SG_READ_ONLY flag
|
|
# Disable fixup chains to avoid __DATA_CONST segment issues with third-party libraries
|
|
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-no_fixup_chains")
|
|
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-no_fixup_chains")
|
|
|
|
# Folly's Exception.cpp references __cxa_increment/decrement_exception_refcount
|
|
# from libc++abi, which lives in <llvm-root>/lib/c++/ and is not on the default
|
|
# linker search path. Derive the path from CMAKE_CXX_COMPILER.
|
|
get_filename_component(_CXX_BIN_DIR "${CMAKE_CXX_COMPILER}" DIRECTORY)
|
|
get_filename_component(_LLVM_ROOT "${_CXX_BIN_DIR}" DIRECTORY)
|
|
set(_LLVM_CXXABI_DIR "${_LLVM_ROOT}/lib/c++")
|
|
if(EXISTS "${_LLVM_CXXABI_DIR}/libc++abi.dylib")
|
|
link_directories("${_LLVM_CXXABI_DIR}")
|
|
link_libraries(c++abi)
|
|
endif()
|
|
endif ()
|
|
|
|
# **************************** Coding style check tools ****************************
|
|
find_package( ClangTools )
|
|
set( BUILD_SUPPORT_DIR "${CMAKE_SOURCE_DIR}/build-support" )
|
|
message(STATUS "CMAKE_SOURCE_DIR is at ${CMAKE_SOURCE_DIR}" )
|
|
|
|
if("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1" OR CLANG_TIDY_FOUND)
|
|
# Generate a Clang compile_commands.json "compilation database" file for use
|
|
# with various development tools, such as Vim's YouCompleteMe plugin.
|
|
# See http://clang.llvm.org/docs/JSONCompilationDatabase.html
|
|
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
|
|
endif()
|
|
|
|
#
|
|
# "make lint" target
|
|
#
|
|
if ( NOT MILVUS_VERBOSE_LINT )
|
|
set( MILVUS_LINT_QUIET "--quiet" )
|
|
endif ()
|
|
|
|
if ( NOT LINT_EXCLUSIONS_FILE )
|
|
# source files matching a glob from a line in this file
|
|
# will be excluded from linting (cpplint, clang-tidy, clang-format)
|
|
set( LINT_EXCLUSIONS_FILE ${BUILD_SUPPORT_DIR}/lint_exclusions.txt )
|
|
endif ()
|
|
|
|
add_custom_target(lint
|
|
${PYTHON_EXECUTABLE} ${BUILD_SUPPORT_DIR}/run_cpplint.py
|
|
--cpplint_binary ${CPPLINT_BIN}
|
|
--exclude_globs ${LINT_EXCLUSIONS_FILE}
|
|
--source_dir ${CMAKE_CURRENT_SOURCE_DIR}/src
|
|
${MILVUS_LINT_QUIET}
|
|
)
|
|
|
|
|
|
find_program( CPPLINT_BIN NAMES cpplint cpplint.py HINTS ${BUILD_SUPPORT_DIR} )
|
|
message( STATUS "Found cpplint executable at ${CPPLINT_BIN}" )
|
|
|
|
# Use the first Python installation on PATH, not the newest one
|
|
set(Python3_FIND_STRATEGY "LOCATION")
|
|
# On Windows, use registry last, not first
|
|
set(Python3_FIND_REGISTRY "LAST")
|
|
# On macOS, use framework last, not first
|
|
set(Python3_FIND_FRAMEWORK "LAST")
|
|
find_package(Python3)
|
|
set(PYTHON_EXECUTABLE ${Python3_EXECUTABLE})
|
|
|
|
message( STATUS "Found Python at ${PYTHON_EXECUTABLE}")
|
|
|
|
#
|
|
# "make clang-format" and "make check-clang-format" targets
|
|
#
|
|
if ( ${CLANG_FORMAT_FOUND} )
|
|
# runs clang format and updates files in place.
|
|
add_custom_target( clang-format
|
|
${PYTHON_EXECUTABLE} ${BUILD_SUPPORT_DIR}/run_clang_format.py
|
|
--clang_format_binary ${CLANG_FORMAT_BIN}
|
|
--exclude_globs ${LINT_EXCLUSIONS_FILE}
|
|
--source_dir ${CMAKE_CURRENT_SOURCE_DIR}/src
|
|
--fix
|
|
${MILVUS_LINT_QUIET} )
|
|
|
|
# runs clang format and exits with a non-zero exit code if any files need to be reformatted
|
|
add_custom_target( check-clang-format
|
|
${PYTHON_EXECUTABLE} ${BUILD_SUPPORT_DIR}/run_clang_format.py
|
|
--clang_format_binary ${CLANG_FORMAT_BIN}
|
|
--exclude_globs ${LINT_EXCLUSIONS_FILE}
|
|
--source_dir ${CMAKE_CURRENT_SOURCE_DIR}/src
|
|
${MILVUS_LINT_QUIET} )
|
|
endif ()
|
|
|
|
#
|
|
# "make clang-tidy" and "make check-clang-tidy" targets
|
|
#
|
|
if ( ${CLANG_TIDY_FOUND} )
|
|
# runs clang-tidy and attempts to fix any warning automatically
|
|
add_custom_target( clang-tidy
|
|
${PYTHON_EXECUTABLE} ${BUILD_SUPPORT_DIR}/run_clang_tidy.py
|
|
--clang_tidy_binary ${CLANG_TIDY_BIN}
|
|
--exclude_globs ${LINT_EXCLUSIONS_FILE}
|
|
--compile_commands ${CMAKE_BINARY_DIR}/compile_commands.json
|
|
--source_dir ${CMAKE_CURRENT_SOURCE_DIR}/src
|
|
--fix
|
|
${MILVUS_LINT_QUIET} )
|
|
|
|
# runs clang-tidy and exits with a non-zero exit code if any errors are found.
|
|
add_custom_target( check-clang-tidy
|
|
${PYTHON_EXECUTABLE} ${BUILD_SUPPORT_DIR}/run_clang_tidy.py
|
|
--clang_tidy_binary ${CLANG_TIDY_BIN}
|
|
--exclude_globs ${LINT_EXCLUSIONS_FILE}
|
|
--compile_commands ${CMAKE_BINARY_DIR}/compile_commands.json
|
|
--source_dir ${CMAKE_CURRENT_SOURCE_DIR}/src
|
|
${MILVUS_LINT_QUIET} )
|
|
endif ()
|
|
|
|
#
|
|
# Validate and print out Milvus configuration options
|
|
#
|
|
config_summary()
|
|
|
|
# **************************** Source files ****************************
|
|
if ( BUILD_UNIT_TEST STREQUAL "ON" AND BUILD_COVERAGE STREQUAL "ON" )
|
|
append_flags( CMAKE_CXX_FLAGS
|
|
FLAGS
|
|
"-fprofile-arcs"
|
|
"-ftest-coverage"
|
|
)
|
|
# Also add coverage flags to linker (required on macOS with Clang)
|
|
append_flags( CMAKE_EXE_LINKER_FLAGS
|
|
FLAGS
|
|
"--coverage"
|
|
)
|
|
append_flags( CMAKE_SHARED_LINKER_FLAGS
|
|
FLAGS
|
|
"--coverage"
|
|
)
|
|
endif ()
|
|
|
|
if ( BUILD_DISK_ANN STREQUAL "ON" )
|
|
ADD_DEFINITIONS(-DBUILD_DISK_ANN=${BUILD_DISK_ANN})
|
|
endif ()
|
|
|
|
ADD_DEFINITIONS(-DBOOST_GEOMETRY_INDEX_DETAIL_EXPERIMENTAL)
|
|
|
|
# Warning: add_subdirectory(src) must be after append_flags("-ftest-coverage"),
|
|
# otherwise cpp code coverage tool will miss src folder
|
|
add_subdirectory( thirdparty )
|
|
add_subdirectory( src )
|
|
|
|
# Unittest lib
|
|
if ( BUILD_UNIT_TEST STREQUAL "ON" )
|
|
append_flags( CMAKE_CXX_FLAGS FLAGS "-DELPP_DISABLE_LOGS")
|
|
add_subdirectory(unittest)
|
|
add_subdirectory(benchmark)
|
|
endif ()
|
|
|
|
add_custom_target( Clean-All COMMAND ${CMAKE_BUILD_TOOL} clean )
|
|
|
|
# **************************** Install ****************************
|
|
|
|
# Install storage
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/storage/
|
|
DESTINATION include/storage
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
|
|
# Install segcore
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/segcore/
|
|
DESTINATION include/segcore
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
|
|
# Install exec/expression/function
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/exec/expression/function/
|
|
DESTINATION include/exec/expression/function
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
|
|
# Install indexbuilder
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/indexbuilder/
|
|
DESTINATION include/indexbuilder
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
|
|
# Install clustering
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/clustering/
|
|
DESTINATION include/clustering
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
|
|
# Install common
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/common/
|
|
DESTINATION include/common
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
# cgo consumers need milvus-common headers in the core output include path.
|
|
foreach(MILVUS_COMMON_INCLUDE_DIR IN LISTS milvus-common_INCLUDE_DIRS)
|
|
install(DIRECTORY ${MILVUS_COMMON_INCLUDE_DIR}/
|
|
DESTINATION include
|
|
)
|
|
endforeach()
|
|
|
|
# Install monitor
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/monitor/
|
|
DESTINATION include/monitor
|
|
FILES_MATCHING PATTERN "*_c.h"
|
|
)
|
|
|
|
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/futures/
|
|
DESTINATION include/futures
|
|
FILES_MATCHING PATTERN "*.h"
|
|
)
|
|
|
|
install(DIRECTORY ${CMAKE_BINARY_DIR}/lib/
|
|
DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}
|
|
)
|