mirror of
https://github.com/morluto/rea.git
synced 2026-10-12 02:19:24 +00:00
Keep failed reader, root descriptor, and output-tree cleanup with the caller. Drain admitted work before close, retry the same retained owners, and block new resource work while cleanup is incomplete. Preserve primary failures and complete inventory observations. Thread ownership through JavaScript reconstruction, the CLI's one-shot scope, MCP server shutdown, verifier scripts, and test fixtures. Remove redundant ownership flags and the unused validated test wrapper. Validate with 850 passing focused tests across 90 suites (two skipped), targeted classification and cleanup retries, static and unused-code checks, and real macOS CLI/MCP directory, ZIP, and DMG workflows. Native Windows and deep-analysis providers were not verified. BREAKING CHANGE: Direct artifact inventory/extraction and JavaScript analysis APIs require an explicit caller-owned ArtifactResourceScope. CLI and MCP input contracts are unchanged.
204 lines
6.7 KiB
JavaScript
204 lines
6.7 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
import { realpath } from "node:fs/promises";
|
|
import { parseArgs } from "node:util";
|
|
|
|
import { analyzeJavaScriptApplicationWithOwnedScope } from "../../lib/javascript-application-analysis.mjs";
|
|
import {
|
|
compareApplicationVersionsEvidence,
|
|
compareJavaScriptExportShapesEvidence,
|
|
traceApplicationFeatureEvidence,
|
|
} from "../../../dist/application/javascript/JavaScriptApplicationWorkflowService.js";
|
|
import { applicationVersionComparisonResultSchema } from "../../../dist/domain/javascript/javascriptApplicationVersionComparisonSchemas.js";
|
|
import { applicationFeatureTraceResultSchema } from "../../../dist/domain/javascript/javascriptFeatureTraceSchemas.js";
|
|
import { javaScriptExportShapeComparisonResultSchema } from "../../../dist/domain/javascript/javascriptExportShapeComparisonSchemas.js";
|
|
import {
|
|
completeVerifierRun,
|
|
createVerifierRun,
|
|
} from "../../lib/verifier-run.mjs";
|
|
|
|
const verifierRun = createVerifierRun();
|
|
|
|
const options = parseArgs({
|
|
options: {
|
|
left: { type: "string" },
|
|
right: { type: "string" },
|
|
"seed-kind": { type: "string", default: "module" },
|
|
"seed-value": { type: "string" },
|
|
"left-module-path": { type: "string" },
|
|
"left-export-name": { type: "string" },
|
|
"right-module-path": { type: "string" },
|
|
"right-export-name": { type: "string" },
|
|
},
|
|
strict: true,
|
|
allowPositionals: false,
|
|
}).values;
|
|
|
|
if (options.left === undefined || options.right === undefined)
|
|
throw new Error(
|
|
"--left and --right must name operator-provided app/ASAR paths",
|
|
);
|
|
const [leftPath, rightPath] = await Promise.all([
|
|
realpath(options.left),
|
|
realpath(options.right),
|
|
]);
|
|
if (leftPath === rightPath)
|
|
throw new Error("--left and --right must resolve to distinct paths");
|
|
const [left, right] = await Promise.all([
|
|
analyze(leftPath),
|
|
analyze(rightPath),
|
|
]);
|
|
const comparison = compareApplicationVersionsEvidence({ left, right });
|
|
if (!comparison.ok) throw comparison.error;
|
|
const comparisonResult = applicationVersionComparisonResultSchema.parse(
|
|
comparison.value.normalized_result,
|
|
);
|
|
const seedValue =
|
|
options["seed-value"] ??
|
|
left.normalized_result.graph.nodes.find(
|
|
({ kind }) => kind === "javascript-module",
|
|
)?.observations[0]?.label;
|
|
const trace =
|
|
seedValue === undefined
|
|
? null
|
|
: traceApplicationFeatureEvidence({
|
|
application: left,
|
|
seed: {
|
|
kind: options["seed-kind"],
|
|
value: seedValue,
|
|
match: "exact",
|
|
case_sensitive: false,
|
|
},
|
|
direction: "both",
|
|
});
|
|
if (trace !== null && !trace.ok) throw trace.error;
|
|
const traceResult =
|
|
trace === null
|
|
? null
|
|
: applicationFeatureTraceResultSchema.parse(trace.value.normalized_result);
|
|
const exportShapeSelector = resolveExportShapeSelector(left, right, options);
|
|
const exportShapeComparison =
|
|
exportShapeSelector === null
|
|
? null
|
|
: compareJavaScriptExportShapesEvidence({
|
|
left,
|
|
right,
|
|
...exportShapeSelector,
|
|
});
|
|
if (exportShapeComparison !== null && !exportShapeComparison.ok)
|
|
throw exportShapeComparison.error;
|
|
const exportShapeResult =
|
|
exportShapeComparison === null
|
|
? null
|
|
: javaScriptExportShapeComparisonResultSchema.parse(
|
|
exportShapeComparison.value.normalized_result,
|
|
);
|
|
|
|
process.stdout.write(
|
|
`${JSON.stringify({
|
|
verifier_run: await completeVerifierRun(verifierRun),
|
|
comparison_id: comparisonResult.comparison_id,
|
|
evidence_id: comparison.value.evidence_id,
|
|
left: comparisonResult.left,
|
|
right: comparisonResult.right,
|
|
summary: comparisonResult.summary,
|
|
matching: comparisonResult.matching,
|
|
coverage: comparisonResult.coverage,
|
|
export_shape_comparison:
|
|
exportShapeResult === null
|
|
? null
|
|
: {
|
|
comparison_id: exportShapeResult.comparison_id,
|
|
evidence_id: exportShapeComparison.value.evidence_id,
|
|
left: exportShapeResult.left,
|
|
right: exportShapeResult.right,
|
|
summary: exportShapeResult.summary,
|
|
changes: exportShapeResult.changes,
|
|
coverage: exportShapeResult.coverage,
|
|
runtime_validation: exportShapeResult.runtime_validation,
|
|
},
|
|
trace:
|
|
traceResult === null
|
|
? null
|
|
: {
|
|
trace_id: traceResult.trace_id,
|
|
evidence_id: trace.value.evidence_id,
|
|
seed: traceResult.seed,
|
|
summary: traceResult.summary,
|
|
coverage: traceResult.coverage,
|
|
native_handoffs: traceResult.native_handoffs.map((handoff) => ({
|
|
artifact_sha256: handoff.artifact_sha256,
|
|
status: handoff.status,
|
|
requested_exports: handoff.requested_exports,
|
|
evidence_ids: handoff.evidence_ids,
|
|
})),
|
|
},
|
|
verified: true,
|
|
})}\n`,
|
|
);
|
|
|
|
function resolveExportShapeSelector(left, right, values) {
|
|
const explicit = [
|
|
values["left-module-path"],
|
|
values["left-export-name"],
|
|
values["right-module-path"],
|
|
values["right-export-name"],
|
|
];
|
|
if (explicit.some((value) => value !== undefined)) {
|
|
if (explicit.some((value) => value === undefined))
|
|
throw new Error(
|
|
"Explicit export-shape verification requires all left/right module and export selectors",
|
|
);
|
|
return {
|
|
left_module_path: explicit[0],
|
|
left_export_name: explicit[1],
|
|
right_module_path: explicit[2],
|
|
right_export_name: explicit[3],
|
|
};
|
|
}
|
|
const leftSelectors = returnShapeSelectors(left.normalized_result.graph);
|
|
const rightSelectors = new Set(
|
|
returnShapeSelectors(right.normalized_result.graph).map(selectorKey),
|
|
);
|
|
const common = leftSelectors.find((selector) =>
|
|
rightSelectors.has(selectorKey(selector)),
|
|
);
|
|
return common === undefined
|
|
? null
|
|
: {
|
|
left_module_path: common.modulePath,
|
|
left_export_name: common.exportName,
|
|
right_module_path: common.modulePath,
|
|
right_export_name: common.exportName,
|
|
};
|
|
}
|
|
|
|
function returnShapeSelectors(graph) {
|
|
const selectors = [];
|
|
for (const node of graph.nodes) {
|
|
for (const observation of node.observations) {
|
|
const properties = observation.properties;
|
|
if (
|
|
properties.semantic_role === "export-return-shapes" &&
|
|
typeof properties.module_path === "string" &&
|
|
typeof properties.exported_name === "string"
|
|
)
|
|
selectors.push({
|
|
modulePath: properties.module_path,
|
|
exportName: properties.exported_name,
|
|
});
|
|
}
|
|
}
|
|
return selectors.sort((left, right) =>
|
|
selectorKey(left).localeCompare(selectorKey(right), "en"),
|
|
);
|
|
}
|
|
|
|
function selectorKey(selector) {
|
|
return `${selector.modulePath}\0${selector.exportName}`;
|
|
}
|
|
|
|
async function analyze(path) {
|
|
return analyzeJavaScriptApplicationWithOwnedScope({ input_path: path });
|
|
}
|