mupen64plus-ae/mupen64plus-video-glide64mk2
1
0
Fork 0
mirror of https://github.com/mupen64plus-ae/mupen64plus-video-glide64mk2.git synced 2024-11-23 05:29:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Protect against out of bounds access in ucode02

Browse Source
This commit is contained in:
Francisco Zurita 2022-01-06 08:50:42 -05:00
parent 08554ba969
commit 7c2820bce6
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Glide64/ucode02.h
View File

@ -230,10 +230,21 @@ static void uc2_culldl ()
{
wxUint16 vStart = (wxUint16)(rdp.cmd0 & 0xFFFF) >> 1;
wxUint16 vEnd = (wxUint16)(rdp.cmd1 & 0xFFFF) >> 1;
// Protect against out of bounds access
vStart &= MAX_VTX - 1;
vEnd &= MAX_VTX - 1;
wxUint32 cond = 0;
FRDP ("uc2:culldl start: %d, end: %d\n", vStart, vEnd);
if (vEnd < vStart) return;
if (vEnd < vStart) {
// Aidyn Chronicles - The First Mage seems to pass parameters in reverse order.
const wxUint16 vTemp = vStart;
vStart = vEnd;
vEnd = vTemp;
}
for (wxUint16 i=vStart; i<=vEnd; i++)
{
/*