mirror of
https://github.com/mvschwarz/openrig.git
synced 2026-11-08 17:31:56 -10:00
shell-redesign V1 attempt-3 Phase 4 process-gap fix: drawer primitives reachability proof
guard-3 PROCESS-BLOCKER on4932f5dsurfaced 3 legitimate gaps; this is the fix-on-top commit. Two gaps live entirely in substrate (ACK file edits; ACK §4 actual_at_4932f5d + deferred_to_phase_5 blocks added; ACK §5 drift disclosures DRIFT P4-D1 site-of-use deferral + P4-D2 unlisted modifications recorded honestly); only this test file is product-code work. NEW packages/ui/test/drawer-primitives.test.tsx (17 tests, all passing): - Each viewer renders without crashing with canonical-shape props (QueueItemViewer, FileViewer, SubSpecPreview, SeatDetailViewer; the last via vi.mock on NodeDetailPanel to bypass deep query/router deps) - Each trigger fires setSelection on click with the correct DrawerSelection discriminator + payload (qitem | file | sub-spec | seat-detail kinds via DrawerSelectionContext.Provider with vi.fn spy) - SharedDetailDrawer routes selection.type to the correct viewer testId; selection=null returns null (SC-6 default-closed contract) Closes ritual #6 reachability proof gap for the 4 viewers + 4 triggers that have no live consumers at4932f5d(P4-2 site-of-use wiring deferred to Phase 5 per DRIFT P4-D1). Verification: - pnpm -F @openrig/ui exec tsc --noEmit: clean - pnpm exec vitest run test/drawer-primitives.test.tsx: 17/17 pass - pnpm -F @openrig/ui build: built in 1.86s - Pre-existing library-review.test.tsx Send-to-seat failure unchanged (baseline 24db2b0; not Phase 4 related) Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This commit is contained in:
mvschwarzandClaude Opus 4.7 committed
1 parent
4932f5d68e
commit
336a37bc73
1 file changed
+247
@@ -0,0 +1,247 @@
|
||||
// V1 attempt-3 Phase 4 — drawer primitives reachability proof (ritual #6).
|
||||
//
|
||||
// Phase 4 P4-2 site-of-use trigger wiring DEFERRED to Phase 5; with no live
|
||||
// consumers, the 4 viewers + 4 triggers need a minimum unit-level proof so
|
||||
// regressions can't slip in unnoticed. Coverage:
|
||||
//
|
||||
// - Each viewer renders without crashing when given canonical-shape props.
|
||||
// - Each trigger fires setSelection on click with the correct DrawerSelection
|
||||
// discriminator (`type: "qitem" | "file" | "sub-spec" | "seat-detail"`)
|
||||
// and the matching payload.
|
||||
// - SharedDetailDrawer routes selection.type to the correct viewer component.
|
||||
//
|
||||
// SeatDetailViewer wraps NodeDetailPanel (which does its own /api fetches via
|
||||
// React Query); the mock below bypasses that depth so the wrapper itself is
|
||||
// the thing under test.
|
||||
|
||||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
import { render, fireEvent, cleanup } from "@testing-library/react";
|
||||
|
||||
// Mock NodeDetailPanel so SeatDetailViewer renders without React Query / fetches.
|
||||
vi.mock("../src/components/NodeDetailPanel.js", () => ({
|
||||
NodeDetailPanel: ({ rigId, logicalId }: { rigId: string; logicalId: string }) => (
|
||||
<div data-testid="node-detail-panel-mock">{rigId}::{logicalId}</div>
|
||||
),
|
||||
}));
|
||||
|
||||
import {
|
||||
DrawerSelectionContext,
|
||||
type DrawerSelection,
|
||||
} from "../src/components/AppShell.js";
|
||||
import { QueueItemViewer } from "../src/components/drawer-viewers/QueueItemViewer.js";
|
||||
import { FileViewer } from "../src/components/drawer-viewers/FileViewer.js";
|
||||
import { SubSpecPreview } from "../src/components/drawer-viewers/SubSpecPreview.js";
|
||||
import { SeatDetailViewer } from "../src/components/drawer-viewers/SeatDetailViewer.js";
|
||||
import { QueueItemTrigger } from "../src/components/drawer-triggers/QueueItemTrigger.js";
|
||||
import { FileReferenceTrigger } from "../src/components/drawer-triggers/FileReferenceTrigger.js";
|
||||
import { SubSpecTrigger } from "../src/components/drawer-triggers/SubSpecTrigger.js";
|
||||
import { SeatDetailTrigger } from "../src/components/drawer-triggers/SeatDetailTrigger.js";
|
||||
import { SharedDetailDrawer } from "../src/components/SharedDetailDrawer.js";
|
||||
|
||||
beforeEach(() => {
|
||||
cleanup();
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Viewers — render-without-crash with canonical-shape props
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("Drawer viewers (P4-1) render with canonical props", () => {
|
||||
it("QueueItemViewer renders header + body preview given canonical qitem shape", () => {
|
||||
const { getByTestId } = render(
|
||||
<QueueItemViewer
|
||||
qitemId="qitem-20260506-test"
|
||||
source="orch-lead@openrig-velocity"
|
||||
destination="redo3-driver-3@openrig-velocity"
|
||||
state="pending"
|
||||
tags={["code-review"]}
|
||||
createdAt="2026-05-06T18:00:00Z"
|
||||
body={"line 1\nline 2\nline 3"}
|
||||
related={[{ kind: "file", label: "review-notes.md", href: "/files/review-notes.md" }]}
|
||||
/>,
|
||||
);
|
||||
expect(getByTestId("queue-item-viewer")).toBeTruthy();
|
||||
expect(getByTestId("qitem-body").textContent).toContain("line 1");
|
||||
});
|
||||
|
||||
it("QueueItemViewer empty-state when no qitemId", () => {
|
||||
const { getByTestId } = render(<QueueItemViewer qitemId="" />);
|
||||
expect(getByTestId("queue-item-viewer-empty")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("FileViewer renders markdown content when kind=markdown + content present", () => {
|
||||
const { getByTestId } = render(
|
||||
<FileViewer path="docs/guide.md" kind="markdown" content="# Hello" />,
|
||||
);
|
||||
const root = getByTestId("file-viewer");
|
||||
expect(root.getAttribute("data-file-kind")).toBe("markdown");
|
||||
});
|
||||
|
||||
it("FileViewer infers kind from path extension when kind omitted", () => {
|
||||
const { getByTestId } = render(
|
||||
<FileViewer path="config/agent.yaml" content="name: test" />,
|
||||
);
|
||||
expect(getByTestId("file-viewer").getAttribute("data-file-kind")).toBe("yaml");
|
||||
});
|
||||
|
||||
it("FileViewer empty-state when no content/imageUrl and not binary", () => {
|
||||
const { getByTestId } = render(<FileViewer path="missing.md" kind="markdown" />);
|
||||
expect(getByTestId("file-viewer-empty")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("SubSpecPreview renders header + manifest excerpt; no Link when entryId omitted", () => {
|
||||
const { getByTestId, queryByTestId } = render(
|
||||
<SubSpecPreview
|
||||
specKind="rig"
|
||||
specName="openrig-velocity"
|
||||
version="0.2.0"
|
||||
source="builtin"
|
||||
manifestExcerpt="name: openrig-velocity\nversion: 0.2.0"
|
||||
/>,
|
||||
);
|
||||
expect(getByTestId("sub-spec-preview")).toBeTruthy();
|
||||
// entryId omitted → no open-in-center Link rendered (avoids router context dep).
|
||||
expect(queryByTestId("sub-spec-open-center")).toBeNull();
|
||||
});
|
||||
|
||||
it("SeatDetailViewer wraps NodeDetailPanel with rigId + logicalId", () => {
|
||||
const { getByTestId } = render(
|
||||
<SeatDetailViewer rigId="rig-1" logicalId="dev.impl" />,
|
||||
);
|
||||
expect(getByTestId("seat-detail-viewer")).toBeTruthy();
|
||||
expect(getByTestId("node-detail-panel-mock").textContent).toBe("rig-1::dev.impl");
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Triggers — click → setSelection with correct DrawerSelection shape
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
function renderWithDrawerCtx(
|
||||
ui: React.ReactNode,
|
||||
): { setSelection: ReturnType<typeof vi.fn> } & ReturnType<typeof render> {
|
||||
const setSelection = vi.fn();
|
||||
const utils = render(
|
||||
<DrawerSelectionContext.Provider value={{ selection: null, setSelection }}>
|
||||
{ui}
|
||||
</DrawerSelectionContext.Provider>,
|
||||
);
|
||||
return { setSelection, ...utils };
|
||||
}
|
||||
|
||||
describe("Drawer triggers (P4-2) fire setSelection with correct kind on click", () => {
|
||||
it("QueueItemTrigger click → setSelection({ type: 'qitem', data })", () => {
|
||||
const data = { qitemId: "qitem-T", body: "preview" };
|
||||
const { setSelection, getByTestId } = renderWithDrawerCtx(
|
||||
<QueueItemTrigger data={data}>open</QueueItemTrigger>,
|
||||
);
|
||||
fireEvent.click(getByTestId("queue-item-trigger"));
|
||||
expect(setSelection).toHaveBeenCalledOnce();
|
||||
expect(setSelection).toHaveBeenCalledWith({ type: "qitem", data });
|
||||
});
|
||||
|
||||
it("FileReferenceTrigger click → setSelection({ type: 'file', data })", () => {
|
||||
const data = { path: "notes.md", kind: "markdown" as const, content: "# h" };
|
||||
const { setSelection, getByTestId } = renderWithDrawerCtx(
|
||||
<FileReferenceTrigger data={data}>open</FileReferenceTrigger>,
|
||||
);
|
||||
fireEvent.click(getByTestId("file-reference-trigger"));
|
||||
expect(setSelection).toHaveBeenCalledWith({ type: "file", data });
|
||||
});
|
||||
|
||||
it("SubSpecTrigger click → setSelection({ type: 'sub-spec', data })", () => {
|
||||
const data = { specKind: "rig", specName: "openrig-velocity" };
|
||||
const { setSelection, getByTestId } = renderWithDrawerCtx(
|
||||
<SubSpecTrigger data={data}>open</SubSpecTrigger>,
|
||||
);
|
||||
fireEvent.click(getByTestId("sub-spec-trigger"));
|
||||
expect(setSelection).toHaveBeenCalledWith({ type: "sub-spec", data });
|
||||
});
|
||||
|
||||
it("SeatDetailTrigger click → setSelection({ type: 'seat-detail', rigId, logicalId })", () => {
|
||||
const { setSelection, getByTestId } = renderWithDrawerCtx(
|
||||
<SeatDetailTrigger rigId="rig-1" logicalId="dev.impl">open</SeatDetailTrigger>,
|
||||
);
|
||||
fireEvent.click(getByTestId("seat-detail-trigger"));
|
||||
expect(setSelection).toHaveBeenCalledWith({
|
||||
type: "seat-detail",
|
||||
rigId: "rig-1",
|
||||
logicalId: "dev.impl",
|
||||
});
|
||||
});
|
||||
|
||||
it("trigger custom testId override is respected (predicate-consistency probe)", () => {
|
||||
const data = { qitemId: "q", body: "b" };
|
||||
const { setSelection, getByTestId } = renderWithDrawerCtx(
|
||||
<QueueItemTrigger data={data} testId="custom-q-trigger">x</QueueItemTrigger>,
|
||||
);
|
||||
fireEvent.click(getByTestId("custom-q-trigger"));
|
||||
expect(setSelection).toHaveBeenCalledWith({ type: "qitem", data });
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// SharedDetailDrawer routing — selection.type → correct viewer component
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
const NOOP_PROPS = {
|
||||
events: [],
|
||||
selectedDiscoveredId: null as string | null,
|
||||
onSelectDiscoveredId: () => {},
|
||||
placementTarget: null,
|
||||
onClearPlacement: () => {},
|
||||
};
|
||||
|
||||
describe("SharedDetailDrawer (Phase 4) routes selection.type to the correct viewer", () => {
|
||||
it("selection=null renders nothing (default-closed contract — SC-6)", () => {
|
||||
const { container } = render(
|
||||
<SharedDetailDrawer selection={null} onClose={() => {}} {...NOOP_PROPS} />,
|
||||
);
|
||||
expect(container.querySelector("[data-testid='shared-detail-drawer']")).toBeNull();
|
||||
});
|
||||
|
||||
it("selection.type='qitem' → QueueItemViewer mounts in drawer", () => {
|
||||
const selection: DrawerSelection = {
|
||||
type: "qitem",
|
||||
data: { qitemId: "qitem-routing-test", body: "x" },
|
||||
};
|
||||
const { getByTestId } = render(
|
||||
<SharedDetailDrawer selection={selection} onClose={() => {}} {...NOOP_PROPS} />,
|
||||
);
|
||||
expect(getByTestId("queue-item-viewer")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("selection.type='file' → FileViewer mounts in drawer", () => {
|
||||
const selection: DrawerSelection = {
|
||||
type: "file",
|
||||
data: { path: "x.md", kind: "markdown", content: "# h" },
|
||||
};
|
||||
const { getByTestId } = render(
|
||||
<SharedDetailDrawer selection={selection} onClose={() => {}} {...NOOP_PROPS} />,
|
||||
);
|
||||
expect(getByTestId("file-viewer")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("selection.type='sub-spec' → SubSpecPreview mounts in drawer", () => {
|
||||
const selection: DrawerSelection = {
|
||||
type: "sub-spec",
|
||||
data: { specKind: "rig", specName: "openrig-velocity" },
|
||||
};
|
||||
const { getByTestId } = render(
|
||||
<SharedDetailDrawer selection={selection} onClose={() => {}} {...NOOP_PROPS} />,
|
||||
);
|
||||
expect(getByTestId("sub-spec-preview")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("selection.type='seat-detail' → SeatDetailViewer mounts in drawer", () => {
|
||||
const selection: DrawerSelection = {
|
||||
type: "seat-detail",
|
||||
rigId: "rig-1",
|
||||
logicalId: "dev.impl",
|
||||
};
|
||||
const { getByTestId } = render(
|
||||
<SharedDetailDrawer selection={selection} onClose={() => {}} {...NOOP_PROPS} />,
|
||||
);
|
||||
expect(getByTestId("seat-detail-viewer")).toBeTruthy();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user