ollama/ollama-python
1
0
Fork 0
mirror of https://github.com/ollama/ollama-python.git synced 2026-07-21 09:05:23 -04:00
Code Issues 101 Packages Projects Releases 10 Wiki Activity

Tool call doesn't honor the function definition when responding #194

New Issue
Closed
opened 2026-02-15 16:28:38 -05:00 by yindo · 1 comment
yindo commented 2026-02-15 16:28:38 -05:00
Owner
Copy Link
Copy Source

Originally created by @2b3pro on GitHub (Dec 30, 2024).

Given this parameter definition in the function def:

'parameters': {'type': 'object', 'properties': {'weight_kg': {'type': 'number', 'description': 'Weight in kilograms'}, 'height_m': {'type': 'number', 'description': 'Height in meters'}}…

The result is:

tool_call=Function(name='calculate_bmi', arguments={'height_m': '1.78', 'weight_kg': '78'})

…where the numbers are converted to strings. They should be numbers (floats).

Originally created by @2b3pro on GitHub (Dec 30, 2024). Given this parameter definition in the function def: `'parameters': {'type': 'object', 'properties': {'weight_kg': {'type': 'number', 'description': 'Weight in kilograms'}, 'height_m': {'type': 'number', 'description': 'Height in meters'}}`… The result is: `tool_call=Function(name='calculate_bmi', arguments={'height_m': '1.78', 'weight_kg': '78'})` …where the numbers are converted to strings. They should be **numbers** (floats).
yindo closed this issue 2026-02-15 16:28:38 -05:00
yindo commented 2026-02-15 16:28:39 -05:00
Author
Owner
Copy Link
Copy Source

@ParthSareen commented on GitHub (Jan 2, 2025):

This is a common issue that I've seen occur - especially with smaller models. We are possibly looking to do sampling with grammars to get structured tools back, however for now I'd recommend either using a larger model or adding type safety + retries. So you could do just do float(value) before passing it into the function

@ParthSareen commented on GitHub (Jan 2, 2025): This is a common issue that I've seen occur - especially with smaller models. We are possibly looking to do sampling with grammars to get structured tools back, however for now I'd recommend either using a larger model or adding type safety + retries. So you could do just do `float(value)` before passing it into the function
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
 thinking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ollama/ollama-python#194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?