ollama/ollama-python
1
0
Fork 0
mirror of https://github.com/ollama/ollama-python.git synced 2026-07-21 09:05:23 -04:00
Code Issues 101 Packages Projects Releases 10 Wiki Activity

[PR #8] [MERGED] fix: remote create new file #324

New Issue
Closed
opened 2026-02-15 16:29:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 16:29:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama-python/pull/8
Author: @BruceMacD
Created: 1/12/2024
Status: ✅ Merged
Merged: 1/12/2024
Merged by: @mxyng

Base: main ← Head: brucemacd/remote-create

📝 Commits (2)

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 ollama/_client.py (+3 -3)
📝 tests/test_client.py (+2 -2)

📄 Description

Just noticed this while working on the ollama-js library, two bugs.

  • A new-line in the Modelfile causes path.exists() to not be true.
  • The blob creation endpoint is POST rather than PUT

Example Modelfile:

FROM ~/models/nous-capybara/nous-capybara-34b.Q4_0.gguf
TEMPLATE "USER: { .Prompt } ASSISTANT: "

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama-python/pull/8 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 1/12/2024 **Status:** ✅ Merged **Merged:** 1/12/2024 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `brucemacd/remote-create` --- ### 📝 Commits (2) - [`b232a6c`](https://github.com/ollama/ollama-python/commit/b232a6c04d1eef82a86af70ed98c02e90e9c7a8c) fix: remote create new file - [`e3733a2`](https://github.com/ollama/ollama-python/commit/e3733a235db9181d35c2c4be1a13f641d57a3cf9) fix tests ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `ollama/_client.py` (+3 -3) 📝 `tests/test_client.py` (+2 -2) </details> ### 📄 Description Just noticed this while working on the `ollama-js` library, two bugs. - A new-line in the Modelfile causes `path.exists()` to not be true. - The blob creation endpoint is `POST` rather than `PUT` Example Modelfile: ``` FROM ~/models/nous-capybara/nous-capybara-34b.Q4_0.gguf TEMPLATE "USER: { .Prompt } ASSISTANT: " ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 16:29:58 -05:00
yindo closed this issue 2026-02-15 16:29:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
 thinking
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ollama/ollama-python#324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?