json format do not return all the results #57

New Issue

2026-02-15T16:27:46-05:00

yindo commented

2026-02-15 16:27:46 -05:00

Originally created by @jojogh on GitHub (Mar 20, 2024).

The code is below and problem i met is below:

code = """

package org.demo.codesmell.config;

public class AppConfig {

public static final String APP_PASSWORD = "appPassword";

public static final String Password = "password";
}

"""
prompt = f"""
Please review the following code, and you must find all the issues in the code:{code}"""

import ollama #ollama run codellama:34b-instruct-q5_K_M
from ollama import Options

response = ollama.chat(model='codellama:34b-instruct-q5_K_M',
messages=[
{
'role': 'user',
'content': prompt,
},

],
#format="json",
#stream=True,
options=Options(
temperature=0,
#top_p=0.9,
#max_tokens=1024,
num_ctx=8192,
num_predict=-1)
)
print(response['message']["content"])

It will return the following informations, 5 issues
The code you provided is a Java class that defines some constants for an application configuration. Here are the issues I found:

The naming convention for constants is not consistent. Some constants are in all caps, while others are camelCase. It's best to use a consistent naming convention throughout the code.
The Password constant is misspelled. It should be APP_PASSWORD.
The APP_PASSWORD constant is not used anywhere in the code. If it's not being used, it can be removed.
There are no getters or setters for the constants. It's best to provide getters and setters for each constant so that they can be accessed and modified from outside the class.
The class is not final, which means it can be extended. However, there is no need to extend this class as it only contains constants. It would be better to make the class final to prevent unintended inheritance.

But, as I just use the option, format="json", it just return 2 issues in json format, is that a bug?

Originally created by @jojogh on GitHub (Mar 20, 2024). The code is below and problem i met is below: code = """ package org.demo.codesmell.config; public class AppConfig { public static final String APP_PASSWORD = "appPassword"; public static final String Password = "password"; } """ prompt = f""" Please review the following code, and you must find all the issues in the code:{code}""" import ollama #ollama run codellama:34b-instruct-q5_K_M from ollama import Options response = ollama.chat(model='codellama:34b-instruct-q5_K_M', messages=[ { 'role': 'user', 'content': prompt, }, ], #format="json", #stream=True, options=Options( temperature=0, #top_p=0.9, #max_tokens=1024, num_ctx=8192, num_predict=-1) ) print(response['message']["content"]) It will return the following informations, 5 issues The code you provided is a Java class that defines some constants for an application configuration. Here are the issues I found: 1. The naming convention for constants is not consistent. Some constants are in all caps, while others are camelCase. It's best to use a consistent naming convention throughout the code. 2. The `Password` constant is misspelled. It should be `APP_PASSWORD`. 3. The `APP_PASSWORD` constant is not used anywhere in the code. If it's not being used, it can be removed. 4. There are no getters or setters for the constants. It's best to provide getters and setters for each constant so that they can be accessed and modified from outside the class. 5. The class is not final, which means it can be extended. However, there is no need to extend this class as it only contains constants. It would be better to make the class final to prevent unintended inheritance. But, as I just use the option, format="json", it just return 2 issues in json format, is that a bug?

yindo commented

2026-02-15 16:27:47 -05:00

@gautam-fairpe commented on GitHub (Apr 13, 2024):

No, It is not a bug. When you force model to return in specified json format, result will not be as good as normal generation.

@gautam-fairpe commented on GitHub (Apr 13, 2024): No, It is not a bug. When you force model to return in specified json format, result will not be as good as normal generation.

yindo commented

2026-02-15 16:27:47 -05:00

@gautam-fairpe commented on GitHub (Apr 13, 2024):

I faced similar issue while using llama cpp python with lm-format-enforcer.

https://github.com/noamgat/lm-format-enforcer#:~:text=Diagnostics%20%2D%20Will%20I%20always%20get%20good%20results%3F

@gautam-fairpe commented on GitHub (Apr 13, 2024): I faced similar issue while using llama cpp python with lm-format-enforcer. https://github.com/noamgat/lm-format-enforcer#:~:text=Diagnostics%20%2D%20Will%20I%20always%20get%20good%20results%3F

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ollama/ollama-python#57