[PR #155] [CLOSED] feat: implement mcp resource #179

Closed
opened 2026-02-15 21:15:14 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/mcpo/pull/155
Author: @dheerapat
Created: 5/24/2025
Status: Closed

Base: devHead: dheeto/resource-implementation


📝 Commits (3)

  • 27af7a6 Merge pull request #135 from taylorwilsdon/issues/73
  • 96dc949 feat: add resource route and register to main app
  • 0b1b039 feat: image result will store in memory and return uri

📊 Changes

3 files changed (+61 additions, -3 deletions)

View changed files

📝 src/mcpo/main.py (+6 -1)
📝 src/mcpo/utils/main.py (+8 -2)
src/mcpo/utils/resource_handler.py (+47 -0)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Added

  • mcpo/utils/resource_handler.py

Changed

  • in mcpo/utils/main.py under process_tool_response method, if tool return image content, add that image in to resource and return URI to client

Deprecated

None

Removed

None

Fixed

None

Security

None

Breaking Changes

None


Additional Information

Screenshots or Videos

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/mcpo/pull/155 **Author:** [@dheerapat](https://github.com/dheerapat) **Created:** 5/24/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dheeto/resource-implementation` --- ### 📝 Commits (3) - [`27af7a6`](https://github.com/open-webui/mcpo/commit/27af7a6f221944b92aacfc74c5f745753147dc72) Merge pull request #135 from taylorwilsdon/issues/73 - [`96dc949`](https://github.com/open-webui/mcpo/commit/96dc9490f7a180306dccbaf00b8060184c6fc96b) feat: add resource route and register to main app - [`0b1b039`](https://github.com/open-webui/mcpo/commit/0b1b0392de1347b74c2439c799b9b830c73ac9a5) feat: image result will store in memory and return uri ### 📊 Changes **3 files changed** (+61 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/mcpo/main.py` (+6 -1) 📝 `src/mcpo/utils/main.py` (+8 -2) ➕ `src/mcpo/utils/resource_handler.py` (+47 -0) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - MCP Resource implementation according to [this](https://modelcontextprotocol.io/docs/concepts/resources) allow mcpo to correctly serve binary file to the client correctly solve #134 and #64 ### Added - `mcpo/utils/resource_handler.py` ### Changed - in `mcpo/utils/main.py` under `process_tool_response` method, if tool return image content, add that image in to resource and return URI to client ### Deprecated None ### Removed None ### Fixed None ### Security None ### Breaking Changes None --- ### Additional Information - #134 - #64 ### Screenshots or Videos ![image](https://github.com/user-attachments/assets/21bf30e1-e042-4845-add4-0502f28d59d8) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:15:14 -05:00
yindo closed this issue 2026-02-15 21:15:14 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: open-webui/mcpo#179