[PR #183] [CLOSED] feat: Allow for disabling of request argument logging #187

Closed
opened 2026-02-15 21:15:15 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/mcpo/pull/183
Author: @bbartels
Created: 6/23/2025
Status: Closed

Base: devHead: main


📝 Commits (10+)

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 src/mcpo/main.py (+3 -0)
📝 src/mcpo/utils/main.py (+8 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Allows disabling of request arguments when sending request to MCP server. This is to ensure that possibly sensitive information isn't logged

Added

  • A feature flag to disable logging via CLI args

Changed

  • A simple toggle to log or not log request arguments

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

Allows for disabling of logging of possibly sensitive data

Breaking Changes

N/A


Additional Information

N/A

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/mcpo/pull/183 **Author:** [@bbartels](https://github.com/bbartels) **Created:** 6/23/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `main` --- ### 📝 Commits (10+) - [`101c513`](https://github.com/open-webui/mcpo/commit/101c513aebf2744225a17d51deef27f2a2d98ea4) Gracefully shutdown uvicorn.Server on task cancellation in run() - [`663f731`](https://github.com/open-webui/mcpo/commit/663f7312bb98ec17f3af4b6ec573a179da82b111) Merge pull request #162 from 021gink/graceful-uvicorn-shutdown - [`4758d30`](https://github.com/open-webui/mcpo/commit/4758d30f6cb921658c10cb9675320a598b31addb) Merge pull request #140 from open-webui/dev - [`747cd45`](https://github.com/open-webui/mcpo/commit/747cd456a433652235b3d6acf0d2a7820cd91a81) Adds ability to disable printing args - [`b2b09b3`](https://github.com/open-webui/mcpo/commit/b2b09b31e0b1551a38a928dbbae41133c590d7be) Fixes - [`ddf27f3`](https://github.com/open-webui/mcpo/commit/ddf27f389bb83117046628a585ac9ef0a4ec3cff) Update main.py - [`9b8f792`](https://github.com/open-webui/mcpo/commit/9b8f792879944c99fe5f2fb0fa35cc97f68dc132) Update main.py - [`775b297`](https://github.com/open-webui/mcpo/commit/775b2976f4aa81bf6df45051634b317990654528) Update main.py - [`f7bae43`](https://github.com/open-webui/mcpo/commit/f7bae43fdad1821d7e0acf0beb26b80493444af0) Update main.py - [`b463985`](https://github.com/open-webui/mcpo/commit/b463985646c1a387d5821aca4974e1c49993dd19) Update main.py ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/mcpo/main.py` (+3 -0) 📝 `src/mcpo/utils/main.py` (+8 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Allows disabling of request arguments when sending request to MCP server. This is to ensure that possibly sensitive information isn't logged ### Added - A feature flag to disable logging via CLI args ### Changed - A simple toggle to log or not log request arguments ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security Allows for disabling of logging of possibly sensitive data ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:15:15 -05:00
yindo closed this issue 2026-02-15 21:15:15 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: open-webui/mcpo#187