openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-21 19:25:25 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #55] [MERGED] fix(comments): stop updating skills.updatedAt on comment add/remove #234

New Issue
Closed
opened 2026-02-15 17:16:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:24 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/55
Author: @sethconvex
Created: 1/27/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @steipete

Base: main ← Head: fix-comments-invalidation

📝 Commits (3)

  • d8c7250 fix(comments): stop updating skills.updatedAt on comment add/remove
  • edd83fd test(comments): add updatedAt invalidation regression coverage
  • 872d5c0 Merge origin/main into fix-comments-invalidation

📊 Changes

2 files changed (+137 additions, -47 deletions)

View changed files

➕ convex/comments.test.ts (+75 -0)
📝 convex/comments.ts (+62 -47)

📄 Description

Summary

  • Remove updatedAt: Date.now() from comment add and remove mutations
  • Comments are not content changes, so they shouldn't invalidate skill list queries

This complements #54 by fixing another source of query invalidation.

Test plan

  • Add a comment to a skill - verify skill list queries don't re-run
  • Remove a comment - verify skill list queries don't re-run

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/55 **Author:** [@sethconvex](https://github.com/sethconvex) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@steipete](https://github.com/steipete) **Base:** `main` ← **Head:** `fix-comments-invalidation` --- ### 📝 Commits (3) - [`d8c7250`](https://github.com/openclaw/clawhub/commit/d8c7250cf2b3730f4f3264cd5a04afa96fc1377e) fix(comments): stop updating skills.updatedAt on comment add/remove - [`edd83fd`](https://github.com/openclaw/clawhub/commit/edd83fdf855e32a972af4263725a890dbeb8ee96) test(comments): add updatedAt invalidation regression coverage - [`872d5c0`](https://github.com/openclaw/clawhub/commit/872d5c082cf1a500bd8c1b47e196e99f86d987ed) Merge origin/main into fix-comments-invalidation ### 📊 Changes **2 files changed** (+137 additions, -47 deletions) <details> <summary>View changed files</summary> ➕ `convex/comments.test.ts` (+75 -0) 📝 `convex/comments.ts` (+62 -47) </details> ### 📄 Description ## Summary - Remove `updatedAt: Date.now()` from comment `add` and `remove` mutations - Comments are not content changes, so they shouldn't invalidate skill list queries This complements #54 by fixing another source of query invalidation. ## Test plan - [ ] Add a comment to a skill - verify skill list queries don't re-run - [ ] Remove a comment - verify skill list queries don't re-run 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:24 -05:00
yindo closed this issue 2026-02-15 17:16:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#234
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?