openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-21 19:25:25 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #107] [CLOSED] feat: Add waves-claim skill for SURF Waves Cards #261

New Issue
Closed
opened 2026-02-15 17:16:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/107
Author: @howlonghasitBen
Created: 2/2/2026
Status: ❌ Closed

Base: main ← Head: feat/waves-claim-skill

📝 Commits (2)

  • 5564368 feat: Add waves-claim skill for SURF Waves Cards
  • 31699dc fix: Address review comments on waves-claim skill

📊 Changes

4 files changed (+406 additions, -0 deletions)

View changed files

➕ skills/waves-claim/SKILL.md (+195 -0)
➕ skills/waves-claim/install.sh (+49 -0)
➕ skills/waves-claim/scripts/check-claim.sh (+66 -0)
➕ skills/waves-claim/scripts/claim.sh (+96 -0)

📄 Description

Summary

Adds the waves-claim skill for claiming free SURF Waves Card NFTs on Base.

What's included

  • SKILL.md - Skill documentation with contract info and usage
  • install.sh - One-click installer
  • scripts/check-claim.sh - Check claim eligibility
  • scripts/claim.sh - Claim a card

Contract Details

Property Value
ClaimVault 0xAF1906B749339adaE38A1cba9740fffA168897c2
NFT Contract 0xcc2d6ba8564541e6e51fe5522e26d4f4bbdd458b
Network Base (Chain ID: 8453)
Cooldown 2 hours
Available 259 cards

Usage

clawhub install waves-claim
./scripts/claim.sh

Links

Greptile Overview

Greptile Summary

This PR adds a new waves-claim skill under skills/waves-claim/ with documentation (SKILL.md), an installer (install.sh), and two helper scripts to check eligibility and submit a claim transaction via Foundry cast.

Main things to double-check are the shell scripts’ handling of cast call return values and exit codes; currently several values are treated as decimals even though cast returns hex by default, and the claim script’s success/failure detection can misbehave due to checking $? after command substitution.

Confidence Score: 3/5

  • Reasonably safe to merge, but the claim/check scripts have a few logic bugs that can cause incorrect eligibility/availability reporting and unreliable error handling.
  • The changes are isolated to a new skill and don’t affect existing runtime code paths, but the scripts as written may mis-handle cast outputs (hex vs decimal) and may proceed when the vault is empty or mis-report cooldown, which undermines the feature’s correctness.
  • skills/waves-claim/scripts/claim.sh; skills/waves-claim/scripts/check-claim.sh

(4/5) You can add custom instructions or style guidelines for the agent here!

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/107 **Author:** [@howlonghasitBen](https://github.com/howlonghasitBen) **Created:** 2/2/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/waves-claim-skill` --- ### 📝 Commits (2) - [`5564368`](https://github.com/openclaw/clawhub/commit/55643687bac045a91760ff5d808d9783e3c400bc) feat: Add waves-claim skill for SURF Waves Cards - [`31699dc`](https://github.com/openclaw/clawhub/commit/31699dc6ff3a60b82dcd3e85f09ff1e9e950ae23) fix: Address review comments on waves-claim skill ### 📊 Changes **4 files changed** (+406 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `skills/waves-claim/SKILL.md` (+195 -0) ➕ `skills/waves-claim/install.sh` (+49 -0) ➕ `skills/waves-claim/scripts/check-claim.sh` (+66 -0) ➕ `skills/waves-claim/scripts/claim.sh` (+96 -0) </details> ### 📄 Description ## Summary Adds the `waves-claim` skill for claiming free SURF Waves Card NFTs on Base. ## What's included - `SKILL.md` - Skill documentation with contract info and usage - `install.sh` - One-click installer - `scripts/check-claim.sh` - Check claim eligibility - `scripts/claim.sh` - Claim a card ## Contract Details | Property | Value | |----------|-------| | **ClaimVault** | `0xAF1906B749339adaE38A1cba9740fffA168897c2` | | **NFT Contract** | `0xcc2d6ba8564541e6e51fe5522e26d4f4bbdd458b` | | **Network** | Base (Chain ID: 8453) | | **Cooldown** | 2 hours | | **Available** | 259 cards | ## Usage ```bash clawhub install waves-claim ./scripts/claim.sh ``` ## Links - [OpenSea Collection](https://opensea.io/collection/surf-waves-cards) - [ClaimVault on BaseScan](https://basescan.org/address/0xAF1906B749339adaE38A1cba9740fffA168897c2) <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> This PR adds a new `waves-claim` skill under `skills/waves-claim/` with documentation (`SKILL.md`), an installer (`install.sh`), and two helper scripts to check eligibility and submit a claim transaction via Foundry `cast`. Main things to double-check are the shell scripts’ handling of `cast call` return values and exit codes; currently several values are treated as decimals even though `cast` returns hex by default, and the claim script’s success/failure detection can misbehave due to checking `$?` after command substitution. <h3>Confidence Score: 3/5</h3> - Reasonably safe to merge, but the claim/check scripts have a few logic bugs that can cause incorrect eligibility/availability reporting and unreliable error handling. - The changes are isolated to a new skill and don’t affect existing runtime code paths, but the scripts as written may mis-handle `cast` outputs (hex vs decimal) and may proceed when the vault is empty or mis-report cooldown, which undermines the feature’s correctness. - skills/waves-claim/scripts/claim.sh; skills/waves-claim/scripts/check-claim.sh <!-- greptile_other_comments_section --> <sub>(4/5) You can add custom instructions or style guidelines for the agent [here](https://app.greptile.com/review/github)!</sub> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=a1d58d20-b4dd-4cbb-973a-9fd7824e1921)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:32 -05:00
yindo closed this issue 2026-02-15 17:16:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?